* [PATCH v2] Follow up patch to Tegra186 AHCI support patch series
@ 2021-04-08 20:55 Sowjanya Komatineni
2021-04-08 20:55 ` [PATCH v2] ata: ahci_tegra: call tegra_powergate_power_off only when PM domain is not present Sowjanya Komatineni
0 siblings, 1 reply; 5+ messages in thread
From: Sowjanya Komatineni @ 2021-04-08 20:55 UTC (permalink / raw)
To: skomatineni, axboe, thierry.reding, digetx
Cc: jonathanh, linux-ide, linux-tegra, linux-kernel
This includes a follow up patch to Tegra186 AHCI support patch series
https://lore.kernel.org/patchwork/cover/1408752/
Delta between patch versions:
[v2]: v1 has missing PM domain check in error path. Fixed in v2.
Sowjanya Komatineni (1):
ata: ahci_tegra: call tegra_powergate_power_off only when PM domain is
not present
drivers/ata/ahci_tegra.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] ata: ahci_tegra: call tegra_powergate_power_off only when PM domain is not present
2021-04-08 20:55 [PATCH v2] Follow up patch to Tegra186 AHCI support patch series Sowjanya Komatineni
@ 2021-04-08 20:55 ` Sowjanya Komatineni
2021-04-09 0:19 ` Dmitry Osipenko
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Sowjanya Komatineni @ 2021-04-08 20:55 UTC (permalink / raw)
To: skomatineni, axboe, thierry.reding, digetx
Cc: jonathanh, linux-ide, linux-tegra, linux-kernel
This patch adds check to call legacy power domain API
tegra_powergate_power_off() only when PM domain is not present.
This is a follow-up patch to Tegra186 AHCI support patch series.
---
drivers/ata/ahci_tegra.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/ata/ahci_tegra.c b/drivers/ata/ahci_tegra.c
index 56612af..4fb94db 100644
--- a/drivers/ata/ahci_tegra.c
+++ b/drivers/ata/ahci_tegra.c
@@ -268,7 +268,8 @@ static int tegra_ahci_power_on(struct ahci_host_priv *hpriv)
disable_power:
clk_disable_unprepare(tegra->sata_clk);
- tegra_powergate_power_off(TEGRA_POWERGATE_SATA);
+ if (!tegra->pdev->dev.pm_domain)
+ tegra_powergate_power_off(TEGRA_POWERGATE_SATA);
disable_regulators:
regulator_bulk_disable(tegra->soc->num_supplies, tegra->supplies);
@@ -287,7 +288,8 @@ static void tegra_ahci_power_off(struct ahci_host_priv *hpriv)
reset_control_assert(tegra->sata_cold_rst);
clk_disable_unprepare(tegra->sata_clk);
- tegra_powergate_power_off(TEGRA_POWERGATE_SATA);
+ if (!tegra->pdev->dev.pm_domain)
+ tegra_powergate_power_off(TEGRA_POWERGATE_SATA);
regulator_bulk_disable(tegra->soc->num_supplies, tegra->supplies);
}
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] ata: ahci_tegra: call tegra_powergate_power_off only when PM domain is not present
2021-04-08 20:55 ` [PATCH v2] ata: ahci_tegra: call tegra_powergate_power_off only when PM domain is not present Sowjanya Komatineni
@ 2021-04-09 0:19 ` Dmitry Osipenko
2021-04-09 11:26 ` Thierry Reding
2021-04-09 14:01 ` Jens Axboe
2 siblings, 0 replies; 5+ messages in thread
From: Dmitry Osipenko @ 2021-04-09 0:19 UTC (permalink / raw)
To: Sowjanya Komatineni, axboe, thierry.reding
Cc: jonathanh, linux-ide, linux-tegra, linux-kernel
08.04.2021 23:55, Sowjanya Komatineni пишет:
> This patch adds check to call legacy power domain API
> tegra_powergate_power_off() only when PM domain is not present.
>
> This is a follow-up patch to Tegra186 AHCI support patch series.
> ---
> drivers/ata/ahci_tegra.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/ata/ahci_tegra.c b/drivers/ata/ahci_tegra.c
> index 56612af..4fb94db 100644
> --- a/drivers/ata/ahci_tegra.c
> +++ b/drivers/ata/ahci_tegra.c
> @@ -268,7 +268,8 @@ static int tegra_ahci_power_on(struct ahci_host_priv *hpriv)
> disable_power:
> clk_disable_unprepare(tegra->sata_clk);
>
> - tegra_powergate_power_off(TEGRA_POWERGATE_SATA);
> + if (!tegra->pdev->dev.pm_domain)
> + tegra_powergate_power_off(TEGRA_POWERGATE_SATA);
>
> disable_regulators:
> regulator_bulk_disable(tegra->soc->num_supplies, tegra->supplies);
> @@ -287,7 +288,8 @@ static void tegra_ahci_power_off(struct ahci_host_priv *hpriv)
> reset_control_assert(tegra->sata_cold_rst);
>
> clk_disable_unprepare(tegra->sata_clk);
> - tegra_powergate_power_off(TEGRA_POWERGATE_SATA);
> + if (!tegra->pdev->dev.pm_domain)
> + tegra_powergate_power_off(TEGRA_POWERGATE_SATA);
>
> regulator_bulk_disable(tegra->soc->num_supplies, tegra->supplies);
> }
>
Looks good, thank you.
Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] ata: ahci_tegra: call tegra_powergate_power_off only when PM domain is not present
2021-04-08 20:55 ` [PATCH v2] ata: ahci_tegra: call tegra_powergate_power_off only when PM domain is not present Sowjanya Komatineni
2021-04-09 0:19 ` Dmitry Osipenko
@ 2021-04-09 11:26 ` Thierry Reding
2021-04-09 14:01 ` Jens Axboe
2 siblings, 0 replies; 5+ messages in thread
From: Thierry Reding @ 2021-04-09 11:26 UTC (permalink / raw)
To: Sowjanya Komatineni
Cc: axboe, digetx, jonathanh, linux-ide, linux-tegra, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 414 bytes --]
On Thu, Apr 08, 2021 at 01:55:15PM -0700, Sowjanya Komatineni wrote:
> This patch adds check to call legacy power domain API
> tegra_powergate_power_off() only when PM domain is not present.
>
> This is a follow-up patch to Tegra186 AHCI support patch series.
> ---
> drivers/ata/ahci_tegra.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] ata: ahci_tegra: call tegra_powergate_power_off only when PM domain is not present
2021-04-08 20:55 ` [PATCH v2] ata: ahci_tegra: call tegra_powergate_power_off only when PM domain is not present Sowjanya Komatineni
2021-04-09 0:19 ` Dmitry Osipenko
2021-04-09 11:26 ` Thierry Reding
@ 2021-04-09 14:01 ` Jens Axboe
2 siblings, 0 replies; 5+ messages in thread
From: Jens Axboe @ 2021-04-09 14:01 UTC (permalink / raw)
To: Sowjanya Komatineni, thierry.reding, digetx
Cc: jonathanh, linux-ide, linux-tegra, linux-kernel
On 4/8/21 2:55 PM, Sowjanya Komatineni wrote:
> This patch adds check to call legacy power domain API
> tegra_powergate_power_off() only when PM domain is not present.
Applied, and added a Fixes line.
--
Jens Axboe
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-04-09 14:01 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-08 20:55 [PATCH v2] Follow up patch to Tegra186 AHCI support patch series Sowjanya Komatineni
2021-04-08 20:55 ` [PATCH v2] ata: ahci_tegra: call tegra_powergate_power_off only when PM domain is not present Sowjanya Komatineni
2021-04-09 0:19 ` Dmitry Osipenko
2021-04-09 11:26 ` Thierry Reding
2021-04-09 14:01 ` Jens Axboe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.