[PATCH v2] staging: rtl8192e: fixed pointer error by adding '*'

[PATCH v2] staging: rtl8192e: fixed pointer error by adding '*'

[Mitali Borkar]

Fixed Comparison to NULL can be written as '!...' by replacing it with
simpler form i.e. boolean expression. This makes code more readable
alternative.
Reported by checkpatch.

Signed-off-by: Mitali Borkar <mitaliborkar810@gmail.com>
---
Changes from v1:- added pointer to the function, which was missed during
fixing v1.

 drivers/staging/rtl8192e/rtl819x_TSProc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c b/drivers/staging/rtl8192e/rtl819x_TSProc.c
index 4457c1acfbf6..78b5b4eaec5f 100644
--- a/drivers/staging/rtl8192e/rtl819x_TSProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_TSProc.c
@@ -327,7 +327,7 @@ bool GetTs(struct rtllib_device *ieee, struct ts_common_info **ppTS,
 	}
 
 	*ppTS = SearchAdmitTRStream(ieee, Addr, UP, TxRxSelect);
-	if (ppTS)
+	if (*ppTS)
 		return true;
 
 	if (!bAddNewTs) {
-- 
2.30.2

Re: [PATCH v2] staging: rtl8192e: fixed pointer error by adding '*'

[Greg KH]

On Sat, Apr 10, 2021 at 06:30:38PM +0530, Mitali Borkar wrote:
> Fixed Comparison to NULL can be written as '!...' by replacing it with
> simpler form i.e. boolean expression. This makes code more readable
> alternative.
> Reported by checkpatch.

Checkpatch did not report this specific problem, Julia did :)

And this changelog text does not reflect the commit you made here.

> 
> Signed-off-by: Mitali Borkar <mitaliborkar810@gmail.com>

We need a "Reported-by:" line here to reflect that someone reported the
problem as well.

Ideally it will have a "Fixes:" tag also, but I can add that if you
don't know how to do that just yet.

thanks,

greg k-h

Re: [Outreachy kernel] [PATCH v2] staging: rtl8192e: fixed pointer error by adding '*'

[Julia Lawall]

On Sat, 10 Apr 2021, Mitali Borkar wrote:

> Fixed Comparison to NULL can be written as '!...' by replacing it with
> simpler form i.e. boolean expression. This makes code more readable
> alternative.
> Reported by checkpatch.
>
> Signed-off-by: Mitali Borkar <mitaliborkar810@gmail.com>
> ---
> Changes from v1:- added pointer to the function, which was missed during
> fixing v1.
>
>  drivers/staging/rtl8192e/rtl819x_TSProc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c b/drivers/staging/rtl8192e/rtl819x_TSProc.c
> index 4457c1acfbf6..78b5b4eaec5f 100644
> --- a/drivers/staging/rtl8192e/rtl819x_TSProc.c
> +++ b/drivers/staging/rtl8192e/rtl819x_TSProc.c
> @@ -327,7 +327,7 @@ bool GetTs(struct rtllib_device *ieee, struct ts_common_info **ppTS,
>  	}
>
>  	*ppTS = SearchAdmitTRStream(ieee, Addr, UP, TxRxSelect);
> -	if (ppTS)
> +	if (*ppTS)

This looks like a patch against your previous patch, and not against the
original code.

julia

>  		return true;
>
>  	if (!bAddNewTs) {
> --
> 2.30.2
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/YHGhdtldqAlRsPHT%40kali.
>

Re: [Outreachy kernel] [PATCH v2] staging: rtl8192e: fixed pointer error by adding '*'

[Julia Lawall]

On Sat, 10 Apr 2021, Mitali Borkar wrote:

> Fixed Comparison to NULL can be written as '!...' by replacing it with
> simpler form i.e. boolean expression. This makes code more readable
> alternative.
> Reported by checkpatch.
>
> Signed-off-by: Mitali Borkar <mitaliborkar810@gmail.com>
> ---
> Changes from v1:- added pointer to the function, which was missed during
> fixing v1.
>
>  drivers/staging/rtl8192e/rtl819x_TSProc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c b/drivers/staging/rtl8192e/rtl819x_TSProc.c
> index 4457c1acfbf6..78b5b4eaec5f 100644
> --- a/drivers/staging/rtl8192e/rtl819x_TSProc.c
> +++ b/drivers/staging/rtl8192e/rtl819x_TSProc.c
> @@ -327,7 +327,7 @@ bool GetTs(struct rtllib_device *ieee, struct ts_common_info **ppTS,
>  	}
>
>  	*ppTS = SearchAdmitTRStream(ieee, Addr, UP, TxRxSelect);
> -	if (ppTS)
> +	if (*ppTS)

This looks like a patch against your previous patch, and not against the
original code.

julia

>  		return true;
>
>  	if (!bAddNewTs) {
> --
> 2.30.2
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/YHGhdtldqAlRsPHT%40kali.
>

Re: [Outreachy kernel] [PATCH v2] staging: rtl8192e: fixed pointer error by adding '*'

[Greg KH]

On Sat, Apr 10, 2021 at 03:23:35PM +0200, Julia Lawall wrote:
> 
> 
> On Sat, 10 Apr 2021, Mitali Borkar wrote:
> 
> > Fixed Comparison to NULL can be written as '!...' by replacing it with
> > simpler form i.e. boolean expression. This makes code more readable
> > alternative.
> > Reported by checkpatch.
> >
> > Signed-off-by: Mitali Borkar <mitaliborkar810@gmail.com>
> > ---
> > Changes from v1:- added pointer to the function, which was missed during
> > fixing v1.
> >
> >  drivers/staging/rtl8192e/rtl819x_TSProc.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c b/drivers/staging/rtl8192e/rtl819x_TSProc.c
> > index 4457c1acfbf6..78b5b4eaec5f 100644
> > --- a/drivers/staging/rtl8192e/rtl819x_TSProc.c
> > +++ b/drivers/staging/rtl8192e/rtl819x_TSProc.c
> > @@ -327,7 +327,7 @@ bool GetTs(struct rtllib_device *ieee, struct ts_common_info **ppTS,
> >  	}
> >
> >  	*ppTS = SearchAdmitTRStream(ieee, Addr, UP, TxRxSelect);
> > -	if (ppTS)
> > +	if (*ppTS)
> 
> This looks like a patch against your previous patch, and not against the
> original code.

That's fine as I already accepted the previous patch.

thanks,

greg k-h

Re: [PATCH v2] staging: rtl8192e: fixed pointer error by adding '*'

[Mitali Borkar]

On Sat, Apr 10, 2021 at 03:14:24PM +0200, Greg KH wrote:
> On Sat, Apr 10, 2021 at 06:30:38PM +0530, Mitali Borkar wrote:
> > Fixed Comparison to NULL can be written as '!...' by replacing it with
> > simpler form i.e. boolean expression. This makes code more readable
> > alternative.
> > Reported by checkpatch.
> 
> Checkpatch did not report this specific problem, Julia did :)
> 
> And this changelog text does not reflect the commit you made here.
> 
Making the changes now.

> > 
> > Signed-off-by: Mitali Borkar <mitaliborkar810@gmail.com>
> 
> We need a "Reported-by:" line here to reflect that someone reported the
> problem as well.
>
I am resending this as patch v3. I have to add reprted by Julia, right?

> Ideally it will have a "Fixes:" tag also, but I can add that if you
> don't know how to do that just yet.
> 
> thanks,
> 
> greg k-h

Re: [PATCH v2] staging: rtl8192e: fixed pointer error by adding '*'

[Greg KH]

On Sat, Apr 10, 2021 at 07:07:08PM +0530, Mitali Borkar wrote:
> On Sat, Apr 10, 2021 at 03:14:24PM +0200, Greg KH wrote:
> > On Sat, Apr 10, 2021 at 06:30:38PM +0530, Mitali Borkar wrote:
> > > Fixed Comparison to NULL can be written as '!...' by replacing it with
> > > simpler form i.e. boolean expression. This makes code more readable
> > > alternative.
> > > Reported by checkpatch.
> > 
> > Checkpatch did not report this specific problem, Julia did :)
> > 
> > And this changelog text does not reflect the commit you made here.
> > 
> Making the changes now.
> 
> > > 
> > > Signed-off-by: Mitali Borkar <mitaliborkar810@gmail.com>
> > 
> > We need a "Reported-by:" line here to reflect that someone reported the
> > problem as well.
> >
> I am resending this as patch v3. I have to add reprted by Julia, right?

Yes please.