All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Yicong Yang <yangyicong@hisilicon.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Wei Xu <xuwei5@hisilicon.com>,
	Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Dmitry Osipenko <digetx@gmail.com>,
	Linux I2C <linux-i2c@vger.kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linuxarm <linuxarm@huawei.com>
Subject: Re: [PATCH] i2c: I2C_HISI should depend on ARCH_HISI && ACPI
Date: Wed, 14 Apr 2021 21:18:33 +0300	[thread overview]
Message-ID: <YHcx+QPbkTA0bv9V@smile.fi.intel.com> (raw)
In-Reply-To: <CAMuHMdVouD+e4GpN_Dur8HSop4B8HVosGSYw7vfTpBEi_inMbw@mail.gmail.com>

On Wed, Apr 14, 2021 at 08:06:18PM +0200, Geert Uytterhoeven wrote:
> On Wed, Apr 14, 2021 at 11:24 AM Yicong Yang <yangyicong@hisilicon.com> wrote:
> > On 2021/4/13 20:26, Geert Uytterhoeven wrote:
> > > The HiSilicon Kunpeng I2C controller is only present on HiSilicon
> > > Kunpeng SoCs, and its driver relies on ACPI to probe for its presence.
> > > Hence add dependencies on ARCH_HISI and ACPI, to prevent asking the user
> > > about this driver when configuring a kernel without Hisilicon platform
> > > or ACPI firmware support.
> >
> > this is a public IP which doesn't specifically depend on ARCH_HISI. I'm
> > not sure all the platform this IP on has ARCH_HISI configured. The driver
> > will not be compiled by default config. This is not correct to have
> > this dependence.
> 
> Thanks for your answer!
> 
> I guess it's still fine to add a dependency on ACPI?

But why?

-- 
With Best Regards,
Andy Shevchenko



WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Yicong Yang <yangyicong@hisilicon.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Wei Xu <xuwei5@hisilicon.com>,
	Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Dmitry Osipenko <digetx@gmail.com>,
	Linux I2C <linux-i2c@vger.kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linuxarm <linuxarm@huawei.com>
Subject: Re: [PATCH] i2c: I2C_HISI should depend on ARCH_HISI && ACPI
Date: Wed, 14 Apr 2021 21:18:33 +0300	[thread overview]
Message-ID: <YHcx+QPbkTA0bv9V@smile.fi.intel.com> (raw)
In-Reply-To: <CAMuHMdVouD+e4GpN_Dur8HSop4B8HVosGSYw7vfTpBEi_inMbw@mail.gmail.com>

On Wed, Apr 14, 2021 at 08:06:18PM +0200, Geert Uytterhoeven wrote:
> On Wed, Apr 14, 2021 at 11:24 AM Yicong Yang <yangyicong@hisilicon.com> wrote:
> > On 2021/4/13 20:26, Geert Uytterhoeven wrote:
> > > The HiSilicon Kunpeng I2C controller is only present on HiSilicon
> > > Kunpeng SoCs, and its driver relies on ACPI to probe for its presence.
> > > Hence add dependencies on ARCH_HISI and ACPI, to prevent asking the user
> > > about this driver when configuring a kernel without Hisilicon platform
> > > or ACPI firmware support.
> >
> > this is a public IP which doesn't specifically depend on ARCH_HISI. I'm
> > not sure all the platform this IP on has ARCH_HISI configured. The driver
> > will not be compiled by default config. This is not correct to have
> > this dependence.
> 
> Thanks for your answer!
> 
> I guess it's still fine to add a dependency on ACPI?

But why?

-- 
With Best Regards,
Andy Shevchenko



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-04-14 18:18 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-13 12:26 [PATCH] i2c: I2C_HISI should depend on ARCH_HISI && ACPI Geert Uytterhoeven
2021-04-13 12:26 ` Geert Uytterhoeven
2021-04-13 12:36 ` Andy Shevchenko
2021-04-13 12:36   ` Andy Shevchenko
2021-04-13 12:48   ` Geert Uytterhoeven
2021-04-13 12:48     ` Geert Uytterhoeven
2021-04-13 14:41     ` Andy Shevchenko
2021-04-13 14:41       ` Andy Shevchenko
2021-04-13 14:44       ` Geert Uytterhoeven
2021-04-13 14:44         ` Geert Uytterhoeven
2021-04-13 15:19         ` Andy Shevchenko
2021-04-13 15:19           ` Andy Shevchenko
2021-04-14  9:19 ` Yicong Yang
2021-04-14  9:19   ` Yicong Yang
2021-04-14 18:06   ` Geert Uytterhoeven
2021-04-14 18:06     ` Geert Uytterhoeven
2021-04-14 18:18     ` Andy Shevchenko [this message]
2021-04-14 18:18       ` Andy Shevchenko
2021-04-14 18:55       ` Geert Uytterhoeven
2021-04-14 18:55         ` Geert Uytterhoeven
2021-04-14 19:14         ` Andy Shevchenko
2021-04-14 19:14           ` Andy Shevchenko
2021-04-14 19:21           ` Geert Uytterhoeven
2021-04-14 19:21             ` Geert Uytterhoeven
2021-04-15  8:50             ` Andy Shevchenko
2021-04-15  8:50               ` Andy Shevchenko
2021-04-19 13:02               ` Geert Uytterhoeven
2021-04-19 13:02                 ` Geert Uytterhoeven
2021-04-19 13:31                 ` Andy Shevchenko
2021-04-19 13:31                   ` Andy Shevchenko
2021-04-19 13:54                   ` Geert Uytterhoeven
2021-04-19 13:54                     ` Geert Uytterhoeven
2021-04-19 13:58                     ` Andy Shevchenko
2021-04-19 13:58                       ` Andy Shevchenko
2021-04-19 14:14                       ` Andy Shevchenko
2021-04-19 14:14                         ` Andy Shevchenko
2021-04-19 14:18                         ` Geert Uytterhoeven
2021-04-19 14:18                           ` Geert Uytterhoeven
2021-04-19 14:27                           ` Andy Shevchenko
2021-04-19 14:27                             ` Andy Shevchenko
2021-04-19 14:15                       ` Geert Uytterhoeven
2021-04-19 14:15                         ` Geert Uytterhoeven
2021-04-19 14:39                         ` Andy Shevchenko
2021-04-19 14:39                           ` Andy Shevchenko
2021-04-15  8:18     ` Yicong Yang
2021-04-15  8:18       ` Yicong Yang
2021-04-15  9:04       ` Yicong Yang
2021-04-15  9:04         ` Yicong Yang
2021-04-15 10:36         ` Andy Shevchenko
2021-04-15 10:36           ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YHcx+QPbkTA0bv9V@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=digetx@gmail.com \
    --cc=geert+renesas@glider.be \
    --cc=geert@linux-m68k.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=wsa+renesas@sang-engineering.com \
    --cc=xuwei5@hisilicon.com \
    --cc=yangyicong@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.