Re: [PATCH 01/14] ASoC: simple-card-utils: enable flexible CPU/Codec/Platform

From: Thierry Reding <thierry.reding@gmail.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Mark Brown <broonie@kernel.org>,
	Linux-ALSA <alsa-devel@alsa-project.org>,
	Jon Hunter <jonathanh@nvidia.com>,
	linux-tegra@vger.kernel.org
Subject: Re: [PATCH 01/14] ASoC: simple-card-utils: enable flexible CPU/Codec/Platform
Date: Thu, 15 Apr 2021 20:01:07 +0200	[thread overview]
Message-ID: <YHh/Y5fXMxm91Ha3@orome.fritz.box> (raw)
In-Reply-To: <87v996od2c.wl-kuninori.morimoto.gx@renesas.com>

[-- Attachment #1: Type: text/plain, Size: 5278 bytes --]

On Thu, Apr 01, 2021 at 01:15:23PM +0900, Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> 
> Current simple-card / audio-graph are assuming fixed
> single-CPU/Codec/Platform.
> This patch prepares multi-CPU/Codec/Platform support.
> 
> Note is that it is not yet full-multi-support.
> 
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
>  include/sound/simple_card_utils.h     |  8 +++
>  sound/soc/generic/audio-graph-card.c  | 22 ++++++++
>  sound/soc/generic/simple-card-utils.c | 72 +++++++++++++++++++--------
>  sound/soc/generic/simple-card.c       | 30 +++++++++++
>  4 files changed, 110 insertions(+), 22 deletions(-)

Hi,

This seems to break display support on a Jetson TX2 board for me, though
I admittedly don't quite understand how it would be related to display
at all. Reverting basically the whole series (because subsequent patches
depend on this on) on top of next-20210415, I get working display again.

There's this in the log, which seems to be related:

[   14.671377] tegra-audio-graph-card sound: too many links
[   14.799645] tegra-audio-graph-card sound: too many links
[   14.845375] tegra-audio-graph-card sound: too many links
[   14.853635] tegra-audio-graph-card sound: too many links
[   14.860934] tegra-audio-graph-card sound: too many links
[   14.868781] tegra-audio-graph-card sound: too many links
[   14.875659] tegra-audio-graph-card sound: too many links
[   14.907874] tegra-audio-graph-card sound: too many links
[   14.917351] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000010
[   14.926255] Mem abort info:
[   14.929096]   ESR = 0x96000047
[   14.932208]   EC = 0x25: DABT (current EL), IL = 32 bits
[   14.937559]   SET = 0, FnV = 0
[   14.940642]   EA = 0, S1PTW = 0
[   14.943867] Data abort info:
[   14.946753]   ISV = 0, ISS = 0x00000047
[   14.950611]   CM = 0, WnR = 1
[   14.953614] user pgtable: 64k pages, 48-bit VAs, pgdp=0000000100b94400
[   14.960185] [0000000000000010] pgd=0800000102280003, p4d=0800000102280003, pud=0800000102280003, pmd=0800000101050003, pte=0000000000000000
[   14.972774] Internal error: Oops: 96000047 [#1] PREEMPT SMP
[   14.978362] Modules linked in: drm_kms_helper snd_soc_tegra210_admaif snd_soc_tegra_pcm snd_soc_tegra210_dmic snd_soc_tegra210_i2s snd_soc_tegra186_dspk cfbfillrect cfbimgblt cfbcopyarea snd_soc_tegra210_ahub snd_soc_tegra_audio_graph_card snd_soc_audio_graph_card snd_soc_simple_card_utils crct10dif_ce at24 tegra_aconnect tegra_bpmp_thermal host1x drm fuse drm_panel_orientation_quirks ipv6
[   15.012917] CPU: 2 PID: 69 Comm: kworker/u12:3 Tainted: G S                5.12.0-rc7-next-20210415 #108
[   15.022390] Hardware name: NVIDIA Jetson TX2 Developer Kit (DT)
[   15.028303] Workqueue: events_unbound deferred_probe_work_func
[   15.034159] pstate: 40000005 (nZcv daif -PAN -UAO -TCO BTYPE=--)
[   15.040162] pc : snd_soc_get_dai_name+0x124/0x150
[   15.044883] lr : snd_soc_get_dai_name+0xa4/0x150
[   15.049521] sp : ffff800011fef780
[   15.052849] x29: ffff800011fef780 x28: ffff00008bc14980
[   15.058181] x27: 0000000000000000 x26: ffff000081aafc10
[   15.063511] x25: ffff0001f7091680 x24: ffff800011538798
[   15.068841] x23: 0000000000000010 x22: ffff800011538778
[   15.074169] x21: ffff800011fef808 x20: 00000000fffffdf4
[   15.079486] x19: ffff0000809c7880 x18: 0000000000000030
[   15.084813] x17: 0000000000000000 x16: 0000000000000000
[   15.090142] x15: ffffffffffffffff x14: ffffffff00000000
[   15.095468] x13: ffffffffffffffff x12: 0000000000000020
[   15.100804] x11: 0101010101010101 x10: 7f7f7f7f7f7f7f7f
[   15.106135] x9 : 7f7f7f7f7f7f7f7f x8 : feff303f73716e6f
[   15.111464] x7 : 00000000ffffffff x6 : 0000314000000000
[   15.116791] x5 : ffff0001f7091d28 x4 : ffff00008c41a010
[   15.122109] x3 : 0000000000000000 x2 : 0000000000000010
[   15.127439] x1 : 0000000000000000 x0 : ffff8000094614d8
[   15.132756] Call trace:
[   15.135201]  snd_soc_get_dai_name+0x124/0x150
[   15.139560]  asoc_simple_parse_dai.part.0+0x70/0xd0 [snd_soc_audio_graph_card]
[   15.146784]  graph_dai_link_of_dpcm+0x100/0x38c [snd_soc_audio_graph_card]
[   15.153672]  __graph_for_each_link+0x1dc/0x204 [snd_soc_audio_graph_card]
[   15.160471]  audio_graph_parse_of+0x148/0x20c [snd_soc_audio_graph_card]
[   15.167178]  tegra_audio_graph_probe+0x6c/0x8c [snd_soc_tegra_audio_graph_card]
[   15.174499]  platform_probe+0x68/0xe0
[   15.178164]  really_probe+0xe4/0x50c
[   15.181754]  driver_probe_device+0x64/0xc4
[   15.185861]  __device_attach_driver+0xb4/0x110
[   15.190314]  bus_for_each_drv+0x78/0xd0
[   15.194149]  __device_attach+0xd8/0x180
[   15.197985]  device_initial_probe+0x14/0x20
[   15.202168]  bus_probe_device+0x9c/0xa4
[   15.206003]  deferred_probe_work_func+0x88/0xc0
[   15.210532]  process_one_work+0x1cc/0x350
[   15.214542]  worker_thread+0x68/0x3ac
[   15.218203]  kthread+0x128/0x134
[   15.221431]  ret_from_fork+0x10/0x34
[   15.225045] Code: fa531004 54ffff81 f9400c00 f9400000 (f90002e0)
[   15.231134] ---[ end trace 671a11645631ca2f ]---

Any ideas what could be wrong?

Adding Jon and linux-tegra for visibility.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]