[RESEND PATCH] cgroup: use tsk->in_iowait instead of delayacct_is_task_waiting_on_io()

[RESEND PATCH] cgroup: use tsk->in_iowait instead of delayacct_is_task_waiting_on_io()

[brookxu]

From: Chunguang Xu <brookxu-1Nz4purKYjRBDgjK7y7TUQ@public.gmane.org>

If delayacct is disabled, then delayacct_is_task_waiting_on_io()
always returns false, which causes the statistical value to be
wrong. Perhaps tsk->in_iowait is better.

Signed-off-by: Chunguang Xu <brookxu-1Nz4purKYjRBDgjK7y7TUQ@public.gmane.org>
---
 kernel/cgroup/cgroup-v1.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/cgroup/cgroup-v1.c b/kernel/cgroup/cgroup-v1.c
index 32596fd..91991e2 100644
--- a/kernel/cgroup/cgroup-v1.c
+++ b/kernel/cgroup/cgroup-v1.c
@@ -727,7 +727,7 @@ int cgroupstats_build(struct cgroupstats *stats, struct dentry *dentry)
 			stats->nr_stopped++;
 			break;
 		default:
-			if (delayacct_is_task_waiting_on_io(tsk))
+			if (tsk->in_iowait)
 				stats->nr_io_wait++;
 			break;
 		}
-- 
1.8.3.1

Re: [RESEND PATCH] cgroup: use tsk->in_iowait instead of delayacct_is_task_waiting_on_io()

[Tejun Heo]

On Tue, Apr 13, 2021 at 09:39:05AM +0800, brookxu wrote:
> From: Chunguang Xu <brookxu-1Nz4purKYjRBDgjK7y7TUQ@public.gmane.org>
> 
> If delayacct is disabled, then delayacct_is_task_waiting_on_io()
> always returns false, which causes the statistical value to be
> wrong. Perhaps tsk->in_iowait is better.
> 
> Signed-off-by: Chunguang Xu <brookxu-1Nz4purKYjRBDgjK7y7TUQ@public.gmane.org>

Applied to cgroup/for-5.13.

Thanks.

-- 
tejun