From: Sasha Levin <sashal@kernel.org>
To: Salvatore Bonaccorso <carnil@debian.org>
Cc: stable <stable@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Miklos Szeredi <mszeredi@redhat.com>,
James Morris <jamorris@linux.microsoft.com>,
Steve Beattie <steve.beattie@canonical.com>
Subject: Re: Please apply commit 7c03e2cda4a5 ("vfs: move cap_convert_nscap() call into vfs_setxattr()") to stable series from 5.10.y back to 4.19.y
Date: Fri, 16 Apr 2021 17:04:04 -0400 [thread overview]
Message-ID: <YHn7xAHwhcKDHdie@sashalap> (raw)
In-Reply-To: <YHnr2D9UO+pQO6uq@eldamar.lan>
On Fri, Apr 16, 2021 at 09:56:08PM +0200, Salvatore Bonaccorso wrote:
>Hi Greg, hi Sasha
>
>Please consider to apply commit 7c03e2cda4a5 ("vfs: move
>cap_convert_nscap() call into vfs_setxattr()") to stable series at
>least back to 4.19.y. It applies to there (but have not tested older
>series) and could test a build on top of 5.10.y with the commit.
>
>The commit was applied in 5.11-rc1 and from the commit message:
>
> vfs: move cap_convert_nscap() call into vfs_setxattr()
>
> cap_convert_nscap() does permission checking as well as conversion of the
> xattr value conditionally based on fs's user-ns.
>
> This is needed by overlayfs and probably other layered fs (ecryptfs) and is
> what vfs_foo() is supposed to do anyway.
>
>Additionally, in fact additionally for distribtuions kernels which do
>allow unprivileged overlayfs mounts this as as well broader
>consequences, as explained in
>https://www.openwall.com/lists/oss-security/2021/04/16/1 .
Is it needed without the rest of the patches in the series it was sent
in
(https://lore.kernel.org/linux-fsdevel/20201207163255.564116-1-mszeredi@redhat.com/)?
--
Thanks,
Sasha
next prev parent reply other threads:[~2021-04-16 21:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 19:56 Please apply commit 7c03e2cda4a5 ("vfs: move cap_convert_nscap() call into vfs_setxattr()") to stable series from 5.10.y back to 4.19.y Salvatore Bonaccorso
2021-04-16 21:04 ` Sasha Levin [this message]
2021-04-17 18:36 ` Salvatore Bonaccorso
2021-04-17 8:40 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YHn7xAHwhcKDHdie@sashalap \
--to=sashal@kernel.org \
--cc=carnil@debian.org \
--cc=gregkh@linuxfoundation.org \
--cc=jamorris@linux.microsoft.com \
--cc=mszeredi@redhat.com \
--cc=stable@vger.kernel.org \
--cc=steve.beattie@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.