[LTP] [PATCH] realtime/func/pi-tests: testpi-2 parser indentation fix

[LTP] [PATCH] realtime/func/pi-tests: testpi-2 parser indentation fix

[Ankit Jain]

There is an indentation issue in parser for testpi-2
which causes incorect parsing of the logs.

Signed-off-by: Ankit Jain <ankitja@vmware.com>
---
 testcases/realtime/func/pi-tests/parse-testpi2.py | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/testcases/realtime/func/pi-tests/parse-testpi2.py b/testcases/realtime/func/pi-tests/parse-testpi2.py
index 69b2748..a455843 100644
--- a/testcases/realtime/func/pi-tests/parse-testpi2.py
+++ b/testcases/realtime/func/pi-tests/parse-testpi2.py
@@ -49,10 +49,8 @@ class TestPi2(Log):
					flag=True
				elif count == 0:
					return False
+			prev_line=line

-
-
-		prev_line=line
		if count>=2:
			return True
		else:
--
2.7.4

[LTP] [PATCH] realtime/func/pi-tests: testpi-2 parser indentation fix

[Petr Vorel]

Hi Ankit,

> There is an indentation issue in parser for testpi-2
> which causes incorect parsing of the logs.

Thanks for your fix, merged!

FYI the patch didn't apply, not sure why, I had to use patch to apply it
(instead of git am). I guess it was wrongly generated, please make sure
you use git format-patch properly.

If pi-tests are really working and worth to keep (one of my colleagues
realtime expert in the past didn't see much value in them), it'd be good
to rewrite these parsers to shell (to avoid unnecessary python3 dependency).

https://github.com/linux-test-project/ltp/issues/547

Also script assign True to flag variable but never uses it.

Kind regards,
Petr

[LTP] [PATCH] realtime/func/pi-tests: testpi-2 parser indentation fix

[Ankit Jain]

> Hi Ankit,
>
> > There is an indentation issue in parser for testpi-2
> > which causes incorect parsing of the logs.
>
> Thanks for your fix, merged!
>
> FYI the patch didn't apply, not sure why, I had to use patch to apply it
> (instead of git am). I guess it was wrongly generated, please make sure
> you use git format-patch properly.

Thanks Petr for merging the patch.
Sorry, you had to apply it through patch instead of git am.
I will take care of it from next time.

> If pi-tests are really working and worth to keep (one of my colleagues
> realtime expert in the past didn't see much value in them), it'd be good
> to rewrite these parsers to shell (to avoid unnecessary python3 dependency).

Is there any other test suite or project which supersede or replaces the pi-tests in LTP?

- Ankit

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20210504/794de4d1/attachment.htm>

[LTP] [PATCH] realtime/func/pi-tests: testpi-2 parser indentation fix

[Petr Vorel]

Hi Ankit,

> > If pi-tests are really working and worth to keep (one of my colleagues
> > realtime expert in the past didn't see much value in them), it'd be good
> > to rewrite these parsers to shell (to avoid unnecessary python3 dependency).

> Is there any other test suite or project which supersede or replaces the pi-tests in LTP?
No idea, maybe ask at appropriate ML (linux-rt-users@vger.kernel.org ?)

Kind regards,
Petr

> - Ankit