From: Benjamin Block <bblock@linux.ibm.com> To: James Smart <jsmart2021@gmail.com> Cc: Muneendra Kumar M <muneendra.kumar@broadcom.com>, Benjamin Block <lkml@mageta.org>, linux-block@vger.kernel.org, linux-scsi@vger.kernel.org, tj@kernel.org, linux-nvme@lists.infradead.org, hare@suse.de, emilne@redhat.com, mkumar@redhat.com, Steffen Maier <maier@linux.ibm.com> Subject: Re: [PATCH v9 03/13] nvme: Added a newsysfs attribute appid_store Date: Fri, 23 Apr 2021 12:14:53 +0200 [thread overview] Message-ID: <YIKeHaCpbWwJT6Lh@t480-pf1aa2c2.linux.ibm.com> (raw) In-Reply-To: <2eec720b-401a-32b4-80e6-900e136939b3@gmail.com> On Thu, Apr 22, 2021 at 04:29:10PM -0700, James Smart wrote: > On 4/20/2021 4:09 AM, Benjamin Block wrote: > > On Tue, Apr 20, 2021 at 12:24:41PM +0530, Muneendra Kumar M wrote: > > > Hi Benjamin, > > > > > > > > --- > > > > > drivers/nvme/host/fc.c | 73 > > > > > +++++++++++++++++++++++++++++++++++++++++- > > > > > 1 file changed, 72 insertions(+), 1 deletion(-) > > > > > > > Hmm, I wonder why only NVMe-FC? Or is this just for the moment? We also > > > > have the FC transport class for SCSI; I assume this could feed the same > > > > IDs into the LLDs. > > > > > > At present it supports only for SCSI-FC . > > > > It does? By adding it to the implementation under `drivers/nvme/host/`? > > I am confused. > > Yeah, this is a little odd. > > This history is: we know we need to merge the scsi fc transport and the nvme > fc transport as the two independent things are creating difficulties and > duplications (devloss is an example). But it's a bit of work to change this > as it will move where the objects are in the topology tree. > > As we tried to figure out how to do the interaction with cgroups, we wanted > to support SCSI and nvme. If you look at how this new attribute sets the > vmid, it's somewhat generic - it just sets the fc appid field on a cgrp id. > There's really nothing that says the cgrp is on a block device that is scsi > or is nvme. It should work on devices regardless of their underlying > protocol type. Which then left the question - where to place such an > attribute. > > Given this is an "fc service" and as we knew the transport will be merged > eventually we picked to put it under /sys/class/fc point which is where we > expect to root the common transport. Ah ok, I think I confused it with the already existing `/sys/class/fc_host`/`/sys/class/fc_transport/`/..., but thats something different. Yeah, having some common ancestor makes sense, if the HBA offers multiple ULPs. > This class point happens to be owned/created by the nvme fc host code > for requesting nve-fc rediscovery events. It is odd that it creates a > requirement to load the nvme-fc transport in order to set values for > scsi fc devices, but we deemed it acceptable. Well, I mean, right now I don't have a immediate need for zfcp in this regard, so I don't want to blow this out of proportions. But like I said, we (zfcp) don't have a NVMe personality, so we never hook into NVMe-FC. > Guess we need to get going on that merged transport... Feel free to reach out, if there is anything coming up. -- Best Regards, Benjamin Block / Linux on IBM Z Kernel Development / IBM Systems IBM Deutschland Research & Development GmbH / https://www.ibm.com/privacy Vorsitz. AufsR.: Gregor Pillen / Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen / Registergericht: AmtsG Stuttgart, HRB 243294
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Block <bblock@linux.ibm.com> To: James Smart <jsmart2021@gmail.com> Cc: Muneendra Kumar M <muneendra.kumar@broadcom.com>, Benjamin Block <lkml@mageta.org>, linux-block@vger.kernel.org, linux-scsi@vger.kernel.org, tj@kernel.org, linux-nvme@lists.infradead.org, hare@suse.de, emilne@redhat.com, mkumar@redhat.com, Steffen Maier <maier@linux.ibm.com> Subject: Re: [PATCH v9 03/13] nvme: Added a newsysfs attribute appid_store Date: Fri, 23 Apr 2021 12:14:53 +0200 [thread overview] Message-ID: <YIKeHaCpbWwJT6Lh@t480-pf1aa2c2.linux.ibm.com> (raw) In-Reply-To: <2eec720b-401a-32b4-80e6-900e136939b3@gmail.com> On Thu, Apr 22, 2021 at 04:29:10PM -0700, James Smart wrote: > On 4/20/2021 4:09 AM, Benjamin Block wrote: > > On Tue, Apr 20, 2021 at 12:24:41PM +0530, Muneendra Kumar M wrote: > > > Hi Benjamin, > > > > > > > > --- > > > > > drivers/nvme/host/fc.c | 73 > > > > > +++++++++++++++++++++++++++++++++++++++++- > > > > > 1 file changed, 72 insertions(+), 1 deletion(-) > > > > > > > Hmm, I wonder why only NVMe-FC? Or is this just for the moment? We also > > > > have the FC transport class for SCSI; I assume this could feed the same > > > > IDs into the LLDs. > > > > > > At present it supports only for SCSI-FC . > > > > It does? By adding it to the implementation under `drivers/nvme/host/`? > > I am confused. > > Yeah, this is a little odd. > > This history is: we know we need to merge the scsi fc transport and the nvme > fc transport as the two independent things are creating difficulties and > duplications (devloss is an example). But it's a bit of work to change this > as it will move where the objects are in the topology tree. > > As we tried to figure out how to do the interaction with cgroups, we wanted > to support SCSI and nvme. If you look at how this new attribute sets the > vmid, it's somewhat generic - it just sets the fc appid field on a cgrp id. > There's really nothing that says the cgrp is on a block device that is scsi > or is nvme. It should work on devices regardless of their underlying > protocol type. Which then left the question - where to place such an > attribute. > > Given this is an "fc service" and as we knew the transport will be merged > eventually we picked to put it under /sys/class/fc point which is where we > expect to root the common transport. Ah ok, I think I confused it with the already existing `/sys/class/fc_host`/`/sys/class/fc_transport/`/..., but thats something different. Yeah, having some common ancestor makes sense, if the HBA offers multiple ULPs. > This class point happens to be owned/created by the nvme fc host code > for requesting nve-fc rediscovery events. It is odd that it creates a > requirement to load the nvme-fc transport in order to set values for > scsi fc devices, but we deemed it acceptable. Well, I mean, right now I don't have a immediate need for zfcp in this regard, so I don't want to blow this out of proportions. But like I said, we (zfcp) don't have a NVMe personality, so we never hook into NVMe-FC. > Guess we need to get going on that merged transport... Feel free to reach out, if there is anything coming up. -- Best Regards, Benjamin Block / Linux on IBM Z Kernel Development / IBM Systems IBM Deutschland Research & Development GmbH / https://www.ibm.com/privacy Vorsitz. AufsR.: Gregor Pillen / Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen / Registergericht: AmtsG Stuttgart, HRB 243294 _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-04-23 10:15 UTC|newest] Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-06 23:06 [PATCH v9 00/13] blkcg:Support to track FC storage blk io traffic Muneendra 2021-04-06 23:06 ` Muneendra 2021-04-06 23:06 ` [PATCH v9 01/13] cgroup: Added cgroup_get_from_id Muneendra 2021-04-06 23:06 ` Muneendra 2021-04-08 8:26 ` Hannes Reinecke 2021-04-08 8:26 ` Hannes Reinecke 2021-04-06 23:06 ` [PATCH v9 02/13] blkcg: Added a app identifier support for blkcg Muneendra 2021-04-06 23:06 ` Muneendra 2021-04-08 8:26 ` Hannes Reinecke 2021-04-08 8:26 ` Hannes Reinecke 2021-04-06 23:06 ` [PATCH v9 03/13] nvme: Added a newsysfs attribute appid_store Muneendra 2021-04-06 23:06 ` Muneendra 2021-04-18 15:32 ` Benjamin Block 2021-04-18 15:32 ` Benjamin Block 2021-04-20 6:54 ` Muneendra Kumar M 2021-04-20 6:54 ` Muneendra Kumar M 2021-04-20 11:09 ` Benjamin Block 2021-04-20 11:09 ` Benjamin Block 2021-04-22 23:29 ` James Smart 2021-04-22 23:29 ` James Smart 2021-04-23 10:14 ` Benjamin Block [this message] 2021-04-23 10:14 ` Benjamin Block 2021-04-06 23:06 ` [PATCH v9 04/13] lpfc: vmid: Add the datastructure for supporting VMID in lpfc Muneendra 2021-04-06 23:06 ` Muneendra 2021-04-08 8:28 ` Hannes Reinecke 2021-04-08 8:28 ` Hannes Reinecke 2021-04-06 23:06 ` [PATCH v9 05/13] lpfc: vmid: VMID params initialization Muneendra 2021-04-06 23:06 ` Muneendra 2021-04-08 8:29 ` Hannes Reinecke 2021-04-08 8:29 ` Hannes Reinecke 2021-04-06 23:06 ` [PATCH v9 06/13] lpfc: vmid: Add support for vmid in mailbox command, does vmid resource allocation and vmid cleanup Muneendra 2021-04-06 23:06 ` Muneendra 2021-04-08 8:32 ` Hannes Reinecke 2021-04-08 8:32 ` Hannes Reinecke 2021-04-06 23:06 ` [PATCH v9 07/13] lpfc: vmid: Implements ELS commands for appid patch Muneendra 2021-04-06 23:06 ` Muneendra 2021-04-08 8:34 ` Hannes Reinecke 2021-04-08 8:34 ` Hannes Reinecke 2021-04-20 12:38 ` Benjamin Block 2021-04-20 12:38 ` Benjamin Block 2021-04-21 22:55 ` James Smart 2021-04-21 22:55 ` James Smart 2021-04-22 9:28 ` Benjamin Block 2021-04-22 9:28 ` Benjamin Block 2021-04-06 23:06 ` [PATCH v9 08/13] lpfc: vmid: Functions to manage vmids Muneendra 2021-04-06 23:06 ` Muneendra 2021-04-08 8:35 ` Hannes Reinecke 2021-04-08 8:35 ` Hannes Reinecke 2021-04-06 23:06 ` [PATCH v9 09/13] lpfc: vmid: Implements CT commands for appid Muneendra 2021-04-06 23:06 ` Muneendra 2021-04-08 8:37 ` Hannes Reinecke 2021-04-08 8:37 ` Hannes Reinecke 2021-04-06 23:06 ` [PATCH v9 10/13] lpfc: vmid: Appends the vmid in the wqe before sending Muneendra 2021-04-06 23:06 ` Muneendra 2021-04-06 23:06 ` [PATCH v9 11/13] lpfc: vmid: Timeout implementation for vmid Muneendra 2021-04-06 23:06 ` Muneendra 2021-04-08 8:38 ` Hannes Reinecke 2021-04-08 8:38 ` Hannes Reinecke 2021-04-06 23:06 ` [PATCH v9 12/13] lpfc: vmid: Adding qfpa and vmid timeout check in worker thread Muneendra 2021-04-06 23:06 ` Muneendra 2021-04-06 23:06 ` [PATCH v9 13/13] lpfc: vmid: Introducing vmid in io path Muneendra 2021-04-06 23:06 ` Muneendra 2021-04-08 8:46 ` Hannes Reinecke 2021-04-08 8:46 ` Hannes Reinecke 2021-04-10 15:00 ` James Smart 2021-04-10 15:00 ` James Smart 2021-04-12 5:27 ` Hannes Reinecke 2021-04-12 5:27 ` Hannes Reinecke
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YIKeHaCpbWwJT6Lh@t480-pf1aa2c2.linux.ibm.com \ --to=bblock@linux.ibm.com \ --cc=emilne@redhat.com \ --cc=hare@suse.de \ --cc=jsmart2021@gmail.com \ --cc=linux-block@vger.kernel.org \ --cc=linux-nvme@lists.infradead.org \ --cc=linux-scsi@vger.kernel.org \ --cc=lkml@mageta.org \ --cc=maier@linux.ibm.com \ --cc=mkumar@redhat.com \ --cc=muneendra.kumar@broadcom.com \ --cc=tj@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.