All of lore.kernel.org
 help / color / mirror / Atom feed
* RFC: don't allow disabling quota accounting on a mounted file system
@ 2021-04-20  7:22 Christoph Hellwig
  2021-04-20  7:22 ` [PATCH 1/2] xfs: remove support for " Christoph Hellwig
                   ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Christoph Hellwig @ 2021-04-20  7:22 UTC (permalink / raw)
  To: linux-xfs

Hi all,

disabling quota accounting (vs just enforcement) on a running file system
is a fundamentally race and hard to get right operation.  It also has
very little practical use.

This causes xfs/007 xfs/106 xfs/220 xfs/304 xfs/305 to fail, as they
specifically test this functionality.

Note that the quotaitem log recovery code is left for to make sure we
don't increase inconsistent recovery states.

Diffstat:
 libxfs/xfs_quota_defs.h |   30 ----
 libxfs/xfs_trans_resv.c |   30 ----
 libxfs/xfs_trans_resv.h |    2 
 scrub/quota.c           |    2 
 xfs_dquot.c             |    3 
 xfs_dquot_item.c        |  134 ---------------------
 xfs_dquot_item.h        |   17 --
 xfs_ioctl.c             |    2 
 xfs_iops.c              |    4 
 xfs_mount.c             |    4 
 xfs_qm.c                |   28 ++--
 xfs_qm.h                |    4 
 xfs_qm_syscalls.c       |  300 ------------------------------------------------
 xfs_quotaops.c          |   57 +++++----
 xfs_super.c             |   51 +++-----
 xfs_trans_dquot.c       |   49 -------
 16 files changed, 84 insertions(+), 633 deletions(-)

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2021-04-26 15:06 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-20  7:22 RFC: don't allow disabling quota accounting on a mounted file system Christoph Hellwig
2021-04-20  7:22 ` [PATCH 1/2] xfs: remove support for " Christoph Hellwig
2021-04-22 14:18   ` [xfs] 44349bf9f5: xfstests.xfs.305.fail kernel test robot
2021-04-22 14:18     ` kernel test robot
2021-04-26 15:06   ` [PATCH 1/2] xfs: remove support for disabling quota accounting on a mounted file system Brian Foster
2021-04-20  7:22 ` [PATCH 2/2] xfs: remove the active vs running quota differentiation Christoph Hellwig
2021-04-20 17:36 ` RFC: don't allow disabling quota accounting on a mounted file system Darrick J. Wong
2021-04-21  6:26   ` Christoph Hellwig

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.