All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc: David Airlie <airlied@linux.ie>,
	dri-devel@lists.freedesktop.org,
	outreachy-kernel@googlegroups.com, Huang Rui <ray.huang@amd.com>,
	Christian Koenig <christian.koenig@amd.com>
Subject: Re: [PATCH] drm/drm_file.c: Define drm_send_event_helper() as 'static'
Date: Mon, 26 Apr 2021 18:16:22 +0200	[thread overview]
Message-ID: <YIbnVgM8Cb2AA+kh@phenom.ffwll.local> (raw)
In-Reply-To: <20210422175146.29840-1-fmdefrancesco@gmail.com>

On Thu, Apr 22, 2021 at 07:51:46PM +0200, Fabio M. De Francesco wrote:
> drm_send_event_helper() has not prototype, it has internal linkage and
> therefore it should be defined with storage class 'static'.
> 
> Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> ---
>  drivers/gpu/drm/drm_file.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm/drm_file.c
> index 7efbccffc2ea..17f38d873972 100644
> --- a/drivers/gpu/drm/drm_file.c
> +++ b/drivers/gpu/drm/drm_file.c
> @@ -786,7 +786,7 @@ EXPORT_SYMBOL(drm_event_cancel_free);
>   * The timestamp variant of dma_fence_signal is used when the caller
>   * sends a valid timestamp.
>   */

Right above is the kerneldoc comment for documented the driver api that
teh subsystem exposes. Generally we remove those when there's nothing
interesting in there when making a function static, which is the case
here. Can you pls do that too in v2?

Thanks, Daniel

> -void drm_send_event_helper(struct drm_device *dev,
> +static void drm_send_event_helper(struct drm_device *dev,
>  			   struct drm_pending_event *e, ktime_t timestamp)
>  {
>  	assert_spin_locked(&dev->event_lock);
> -- 
> 2.31.1
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch>
To: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc: outreachy-kernel@googlegroups.com,
	dri-devel@lists.freedesktop.org,
	Christian Koenig <christian.koenig@amd.com>,
	Huang Rui <ray.huang@amd.com>, David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/drm_file.c: Define drm_send_event_helper() as 'static'
Date: Mon, 26 Apr 2021 18:16:22 +0200	[thread overview]
Message-ID: <YIbnVgM8Cb2AA+kh@phenom.ffwll.local> (raw)
In-Reply-To: <20210422175146.29840-1-fmdefrancesco@gmail.com>

On Thu, Apr 22, 2021 at 07:51:46PM +0200, Fabio M. De Francesco wrote:
> drm_send_event_helper() has not prototype, it has internal linkage and
> therefore it should be defined with storage class 'static'.
> 
> Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> ---
>  drivers/gpu/drm/drm_file.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm/drm_file.c
> index 7efbccffc2ea..17f38d873972 100644
> --- a/drivers/gpu/drm/drm_file.c
> +++ b/drivers/gpu/drm/drm_file.c
> @@ -786,7 +786,7 @@ EXPORT_SYMBOL(drm_event_cancel_free);
>   * The timestamp variant of dma_fence_signal is used when the caller
>   * sends a valid timestamp.
>   */

Right above is the kerneldoc comment for documented the driver api that
teh subsystem exposes. Generally we remove those when there's nothing
interesting in there when making a function static, which is the case
here. Can you pls do that too in v2?

Thanks, Daniel

> -void drm_send_event_helper(struct drm_device *dev,
> +static void drm_send_event_helper(struct drm_device *dev,
>  			   struct drm_pending_event *e, ktime_t timestamp)
>  {
>  	assert_spin_locked(&dev->event_lock);
> -- 
> 2.31.1
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch


  reply	other threads:[~2021-04-26 16:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-22 17:51 [PATCH] drm/drm_file.c: Define drm_send_event_helper() as 'static' Fabio M. De Francesco
2021-04-22 17:51 ` Fabio M. De Francesco
2021-04-26 16:16 ` Daniel Vetter [this message]
2021-04-26 16:16   ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YIbnVgM8Cb2AA+kh@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=airlied@linux.ie \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=fmdefrancesco@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    --cc=ray.huang@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.