[PATCH v2] Staging: greybus: Add () around gcam macro.

[PATCH v2] Staging: greybus: Add () around gcam macro.

[Tawah Peggy]

checkpatch.pl suggest addition of parenthesis around the gcam macro.

Signed-off-by: Tawah Peggy <tawahpeggy98@gmail.com>

---
 drivers/staging/greybus/camera.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/greybus/camera.c b/drivers/staging/greybus/camera.c
index 324a26430f71..ae49e37a87e9 100644
--- a/drivers/staging/greybus/camera.c
+++ b/drivers/staging/greybus/camera.c
@@ -180,9 +180,9 @@ static const struct gb_camera_fmt_info *gb_camera_get_format_info(u16 gb_fmt)
 
 #define GB_CAMERA_MAX_SETTINGS_SIZE	8192
 
-#define gcam_dbg(gcam, format...)	dev_dbg(&gcam->bundle->dev, format)
-#define gcam_info(gcam, format...)	dev_info(&gcam->bundle->dev, format)
-#define gcam_err((gcam), format...)	dev_err(&gcam->bundle->dev, format)
+#define gcam_dbg(gcam, format...)	dev_dbg(&(gcam)->bundle->dev, format)
+#define gcam_info(gcam, format...)	dev_info(&(gcam)->bundle->dev, format)
+#define gcam_err(gcam, format...)	dev_err(&(gcam)->bundle->dev, format)
 
 static int gb_camera_operation_sync_flags(struct gb_connection *connection,
 					  int type, unsigned int flags,
-- 
2.17.1

Re: [Outreachy kernel] [PATCH v2] Staging: greybus: Add () around gcam macro.

[Julia Lawall]

On Tue, 27 Apr 2021, Tawah Peggy wrote:

> checkpatch.pl suggest addition of parenthesis around the gcam macro.
>
> Signed-off-by: Tawah Peggy <tawahpeggy98@gmail.com>
>
> ---
>  drivers/staging/greybus/camera.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/greybus/camera.c b/drivers/staging/greybus/camera.c
> index 324a26430f71..ae49e37a87e9 100644
> --- a/drivers/staging/greybus/camera.c
> +++ b/drivers/staging/greybus/camera.c
> @@ -180,9 +180,9 @@ static const struct gb_camera_fmt_info *gb_camera_get_format_info(u16 gb_fmt)
>
>  #define GB_CAMERA_MAX_SETTINGS_SIZE	8192
>
> -#define gcam_dbg(gcam, format...)	dev_dbg(&gcam->bundle->dev, format)
> -#define gcam_info(gcam, format...)	dev_info(&gcam->bundle->dev, format)
> -#define gcam_err((gcam), format...)	dev_err(&gcam->bundle->dev, format)

This patch seems to be based on your original patch.  It should be based
on the code as Greg has it.

julia

> +#define gcam_dbg(gcam, format...)	dev_dbg(&(gcam)->bundle->dev, format)
> +#define gcam_info(gcam, format...)	dev_info(&(gcam)->bundle->dev, format)
> +#define gcam_err(gcam, format...)	dev_err(&(gcam)->bundle->dev, format)
>
>  static int gb_camera_operation_sync_flags(struct gb_connection *connection,
>  					  int type, unsigned int flags,
> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20210427175922.GA24978%40peggy-Lenovo-V130-15IKB.
>

Re: [PATCH v2] Staging: greybus: Add () around gcam macro.

[Greg Kroah-Hartman]

On Tue, Apr 27, 2021 at 01:59:27PM -0400, Tawah Peggy wrote:
> checkpatch.pl suggest addition of parenthesis around the gcam macro.
> 
> Signed-off-by: Tawah Peggy <tawahpeggy98@gmail.com>
> 
> ---
>  drivers/staging/greybus/camera.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/greybus/camera.c b/drivers/staging/greybus/camera.c
> index 324a26430f71..ae49e37a87e9 100644
> --- a/drivers/staging/greybus/camera.c
> +++ b/drivers/staging/greybus/camera.c
> @@ -180,9 +180,9 @@ static const struct gb_camera_fmt_info *gb_camera_get_format_info(u16 gb_fmt)
>  
>  #define GB_CAMERA_MAX_SETTINGS_SIZE	8192
>  
> -#define gcam_dbg(gcam, format...)	dev_dbg(&gcam->bundle->dev, format)
> -#define gcam_info(gcam, format...)	dev_info(&gcam->bundle->dev, format)
> -#define gcam_err((gcam), format...)	dev_err(&gcam->bundle->dev, format)
> +#define gcam_dbg(gcam, format...)	dev_dbg(&(gcam)->bundle->dev, format)
> +#define gcam_info(gcam, format...)	dev_info(&(gcam)->bundle->dev, format)
> +#define gcam_err(gcam, format...)	dev_err(&(gcam)->bundle->dev, format)

This change makes no sense at all.  Please look at what this is doing
and consider if it is actually a valid thing to do.

checkpatch is a perl script, and isn't always right...

thanks,

greg k-h

Re: [Outreachy kernel] Re: [PATCH v2] Staging: greybus: Add () around gcam macro.

[Matthew Wilcox]

On Tue, Apr 27, 2021 at 08:08:38PM +0200, Greg Kroah-Hartman wrote:
> On Tue, Apr 27, 2021 at 01:59:27PM -0400, Tawah Peggy wrote:
> > checkpatch.pl suggest addition of parenthesis around the gcam macro.
> > 
> > Signed-off-by: Tawah Peggy <tawahpeggy98@gmail.com>
> > 
> > ---
> >  drivers/staging/greybus/camera.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/staging/greybus/camera.c b/drivers/staging/greybus/camera.c
> > index 324a26430f71..ae49e37a87e9 100644
> > --- a/drivers/staging/greybus/camera.c
> > +++ b/drivers/staging/greybus/camera.c
> > @@ -180,9 +180,9 @@ static const struct gb_camera_fmt_info *gb_camera_get_format_info(u16 gb_fmt)
> >  
> >  #define GB_CAMERA_MAX_SETTINGS_SIZE	8192
> >  
> > -#define gcam_dbg(gcam, format...)	dev_dbg(&gcam->bundle->dev, format)
> > -#define gcam_info(gcam, format...)	dev_info(&gcam->bundle->dev, format)
> > -#define gcam_err((gcam), format...)	dev_err(&gcam->bundle->dev, format)
> > +#define gcam_dbg(gcam, format...)	dev_dbg(&(gcam)->bundle->dev, format)
> > +#define gcam_info(gcam, format...)	dev_info(&(gcam)->bundle->dev, format)
> > +#define gcam_err(gcam, format...)	dev_err(&(gcam)->bundle->dev, format)
> 
> This change makes no sense at all.  Please look at what this is doing
> and consider if it is actually a valid thing to do.

umm ... makes sense to me.  what if i call:

	gcam_err(p + 1, "hi");

looks to me like it'll expand into:

	dev_err(&p + 1->bundle->dev, "hi);

ok, the driver doesn't currently do that, but it's a nice bit of
resilience to add.

Re: [Outreachy kernel] Re: [PATCH v2] Staging: greybus: Add () around gcam macro.

[Greg Kroah-Hartman]

On Tue, Apr 27, 2021 at 07:32:41PM +0100, Matthew Wilcox wrote:
> On Tue, Apr 27, 2021 at 08:08:38PM +0200, Greg Kroah-Hartman wrote:
> > On Tue, Apr 27, 2021 at 01:59:27PM -0400, Tawah Peggy wrote:
> > > checkpatch.pl suggest addition of parenthesis around the gcam macro.
> > > 
> > > Signed-off-by: Tawah Peggy <tawahpeggy98@gmail.com>
> > > 
> > > ---
> > >  drivers/staging/greybus/camera.c | 6 +++---
> > >  1 file changed, 3 insertions(+), 3 deletions(-)
> > > 
> > > diff --git a/drivers/staging/greybus/camera.c b/drivers/staging/greybus/camera.c
> > > index 324a26430f71..ae49e37a87e9 100644
> > > --- a/drivers/staging/greybus/camera.c
> > > +++ b/drivers/staging/greybus/camera.c
> > > @@ -180,9 +180,9 @@ static const struct gb_camera_fmt_info *gb_camera_get_format_info(u16 gb_fmt)
> > >  
> > >  #define GB_CAMERA_MAX_SETTINGS_SIZE	8192
> > >  
> > > -#define gcam_dbg(gcam, format...)	dev_dbg(&gcam->bundle->dev, format)
> > > -#define gcam_info(gcam, format...)	dev_info(&gcam->bundle->dev, format)
> > > -#define gcam_err((gcam), format...)	dev_err(&gcam->bundle->dev, format)
> > > +#define gcam_dbg(gcam, format...)	dev_dbg(&(gcam)->bundle->dev, format)
> > > +#define gcam_info(gcam, format...)	dev_info(&(gcam)->bundle->dev, format)
> > > +#define gcam_err(gcam, format...)	dev_err(&(gcam)->bundle->dev, format)
> > 
> > This change makes no sense at all.  Please look at what this is doing
> > and consider if it is actually a valid thing to do.
> 
> umm ... makes sense to me.  what if i call:
> 
> 	gcam_err(p + 1, "hi");
> 
> looks to me like it'll expand into:
> 
> 	dev_err(&p + 1->bundle->dev, "hi);
> 
> ok, the driver doesn't currently do that, but it's a nice bit of
> resilience to add.

No it isn't, this is a tiny little wrapper around a logging message.  It
is fine as-is...

thanks,

greg k-h