All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: Liu Bo <bo.liu@linux.alibaba.com>
Cc: virtio-dev@lists.oasis-open.org, virtio-fs@redhat.com, vgoyal@redhat.com
Subject: [virtio-dev] Re: [Virtio-fs] [virtio-dev] [PATCH v2 0/2] virtio-fs: add notification queue
Date: Thu, 13 May 2021 14:44:42 +0100	[thread overview]
Message-ID: <YJ0tSmwRulBHGrIG@stefanha-x1.localdomain> (raw)
In-Reply-To: <20210512223637.GA6241@rsjd01523.et2sqa>

[-- Attachment #1: Type: text/plain, Size: 1782 bytes --]

On Thu, May 13, 2021 at 06:36:37AM +0800, Liu Bo wrote:
> Hi Stefan,
> 
> On Tue, May 11, 2021 at 09:22:24AM +0100, Stefan Hajnoczi wrote:
> > On Mon, Feb 15, 2021 at 09:54:08AM +0000, Stefan Hajnoczi wrote:
> > > v2:
> > >  * Document empty virtqueue behavior for FUSE_NOTIFY_LOCK messages
> > > 
> > > This patch series adds the notification queue to the VIRTIO specification.
> > > This new virtqueue carries device->driver FUSE notify messages.  They are
> > > currently unused but will be necessary for file locking, which can block for an
> > > unbounded amount of time and therefore needs a asynchronous completion event
> > > instead of a request/response buffer that consumes space in the request
> > > virtqueue until the operation completes.
> > > 
> > > Patch 1 corrects an oversight I noticed: the file system device was not added
> > > to the Conformance chapter.
> > > 
> > > Stefan Hajnoczi (2):
> > >   virtio-fs: add file system device to Conformance chapter
> > >   virtio-fs: add notification queue
> > > 
> > >  conformance.tex | 23 ++++++++++++++++
> > >  virtio-fs.tex   | 71 ++++++++++++++++++++++++++++++++++++++++++-------
> > >  2 files changed, 84 insertions(+), 10 deletions(-)
> > 
> > Reminder to anyone who needs the virtio-fs notification queue: please
> > review this series.
> >
> 
> Besides using notification queue to provide posix lock support, I've
> also managed to invalidate dentry/inode's cache with notification
> queue, it worked well.

Thank you!

Are you using dentry/inode cache invalidation to reduce the number of
file descriptors that virtiofsd needs to hold open, or are you using it
because the file system is shared by multiple systems and you want to
stronger cache coherency?

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Stefan Hajnoczi <stefanha@redhat.com>
To: Liu Bo <bo.liu@linux.alibaba.com>
Cc: virtio-fs@redhat.com, virtio-dev@lists.oasis-open.org, vgoyal@redhat.com
Subject: Re: [Virtio-fs] [virtio-dev] [PATCH v2 0/2] virtio-fs: add notification queue
Date: Thu, 13 May 2021 14:44:42 +0100	[thread overview]
Message-ID: <YJ0tSmwRulBHGrIG@stefanha-x1.localdomain> (raw)
In-Reply-To: <20210512223637.GA6241@rsjd01523.et2sqa>

[-- Attachment #1: Type: text/plain, Size: 1782 bytes --]

On Thu, May 13, 2021 at 06:36:37AM +0800, Liu Bo wrote:
> Hi Stefan,
> 
> On Tue, May 11, 2021 at 09:22:24AM +0100, Stefan Hajnoczi wrote:
> > On Mon, Feb 15, 2021 at 09:54:08AM +0000, Stefan Hajnoczi wrote:
> > > v2:
> > >  * Document empty virtqueue behavior for FUSE_NOTIFY_LOCK messages
> > > 
> > > This patch series adds the notification queue to the VIRTIO specification.
> > > This new virtqueue carries device->driver FUSE notify messages.  They are
> > > currently unused but will be necessary for file locking, which can block for an
> > > unbounded amount of time and therefore needs a asynchronous completion event
> > > instead of a request/response buffer that consumes space in the request
> > > virtqueue until the operation completes.
> > > 
> > > Patch 1 corrects an oversight I noticed: the file system device was not added
> > > to the Conformance chapter.
> > > 
> > > Stefan Hajnoczi (2):
> > >   virtio-fs: add file system device to Conformance chapter
> > >   virtio-fs: add notification queue
> > > 
> > >  conformance.tex | 23 ++++++++++++++++
> > >  virtio-fs.tex   | 71 ++++++++++++++++++++++++++++++++++++++++++-------
> > >  2 files changed, 84 insertions(+), 10 deletions(-)
> > 
> > Reminder to anyone who needs the virtio-fs notification queue: please
> > review this series.
> >
> 
> Besides using notification queue to provide posix lock support, I've
> also managed to invalidate dentry/inode's cache with notification
> queue, it worked well.

Thank you!

Are you using dentry/inode cache invalidation to reduce the number of
file descriptors that virtiofsd needs to hold open, or are you using it
because the file system is shared by multiple systems and you want to
stronger cache coherency?

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2021-05-13 13:44 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-15  9:54 [virtio-dev] [PATCH v2 0/2] virtio-fs: add notification queue Stefan Hajnoczi
2021-02-15  9:54 ` [virtio-dev] [PATCH v2 1/2] virtio-fs: add file system device to Conformance chapter Stefan Hajnoczi
2021-02-15  9:54 ` [virtio-dev] [PATCH v2 2/2] virtio-fs: add notification queue Stefan Hajnoczi
     [not found]   ` <20210514163320.GA486352@horse>
2021-05-17 10:14     ` [virtio-dev] " Stefan Hajnoczi
2021-03-15 15:52 ` [virtio-dev] Re: [PATCH v2 0/2] " Stefan Hajnoczi
2021-05-11  8:22 ` [virtio-dev] " Stefan Hajnoczi
2021-05-11  8:22   ` [Virtio-fs] " Stefan Hajnoczi
2021-05-12 22:36   ` Liu Bo
2021-05-13 13:44     ` Stefan Hajnoczi [this message]
2021-05-13 13:44       ` Stefan Hajnoczi
2021-05-13 17:50       ` Liu Bo
2021-05-17 10:06         ` [virtio-dev] " Stefan Hajnoczi
2021-05-17 10:06           ` Stefan Hajnoczi
2021-05-17 13:03         ` Vivek Goyal
2021-05-17 12:48       ` Vivek Goyal
2021-05-18 18:46         ` Liu Bo
2021-05-18 20:42           ` Vivek Goyal
2021-05-21  1:06             ` Liu Bo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YJ0tSmwRulBHGrIG@stefanha-x1.localdomain \
    --to=stefanha@redhat.com \
    --cc=bo.liu@linux.alibaba.com \
    --cc=vgoyal@redhat.com \
    --cc=virtio-dev@lists.oasis-open.org \
    --cc=virtio-fs@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.