All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v2 1/1] package/freescale-imx/imx-gpu-viv: select libdrm
@ 2021-04-29 18:51 Sébastien Szymanski
  2021-05-04 12:55 ` Gary Bisson
  0 siblings, 1 reply; 3+ messages in thread
From: Sébastien Szymanski @ 2021-04-29 18:51 UTC (permalink / raw)
  To: buildroot

Some libraries (libGL.so, vivante_dri.so, libEGL.so, libgbm_viv.so) are
linked against libdrm so select libdrm package.

Fixes: 8283e838f040 ("package/freescale-imx/imx-gpu-viv: bump to version 6.4.3.p1.2")
Signed-off-by: S?bastien Szymanski <sebastien.szymanski@armadeus.com>
---

Changes for v2:
 - libdrm is not needed on ARM with framebuffer output.

 package/freescale-imx/imx-gpu-viv/Config.in      | 5 +++--
 package/freescale-imx/imx-gpu-viv/imx-gpu-viv.mk | 7 ++++++-
 2 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/package/freescale-imx/imx-gpu-viv/Config.in b/package/freescale-imx/imx-gpu-viv/Config.in
index cca2689905..6668ee8bb5 100644
--- a/package/freescale-imx/imx-gpu-viv/Config.in
+++ b/package/freescale-imx/imx-gpu-viv/Config.in
@@ -12,6 +12,9 @@ config BR2_PACKAGE_IMX_GPU_VIV
 	depends on (BR2_arm && BR2_ARM_EABIHF) || BR2_aarch64
 	# Library binaries are linked against libc.so.6
 	depends on BR2_TOOLCHAIN_USES_GLIBC
+	# Library binaries are linked against libdrm.so.2, except framebuffer
+	# output on ARM
+	select BR2_PACKAGE_LIBDRM if !(BR2_arm && BR2_PACKAGE_IMX_GPU_VIV_OUTPUT_FB)
 	select BR2_PACKAGE_HAS_LIBEGL
 	select BR2_PACKAGE_HAS_LIBGLES
 	select BR2_PACKAGE_HAS_LIBOPENCL
@@ -56,8 +59,6 @@ config BR2_PACKAGE_IMX_GPU_VIV_OUTPUT_FB
 
 config BR2_PACKAGE_IMX_GPU_VIV_OUTPUT_WL
 	bool "Wayland"
-	# libdrm needed by gbm_viv.so
-	select BR2_PACKAGE_LIBDRM
 	select BR2_PACKAGE_WAYLAND
 	select BR2_PACKAGE_HAS_LIBEGL_WAYLAND
 
diff --git a/package/freescale-imx/imx-gpu-viv/imx-gpu-viv.mk b/package/freescale-imx/imx-gpu-viv/imx-gpu-viv.mk
index 802ac26c1c..103c0341e3 100644
--- a/package/freescale-imx/imx-gpu-viv/imx-gpu-viv.mk
+++ b/package/freescale-imx/imx-gpu-viv/imx-gpu-viv.mk
@@ -29,8 +29,13 @@ ifeq ($(IMX_GPU_VIV_LIB_TARGET),x11)
 IMX_GPU_VIV_DEPENDENCIES += xlib_libXdamage xlib_libXext xlib_libXfixes
 endif
 
+# Libraries are linked against libdrm, except framebuffer output on ARM
+ifneq ($(IMX_GPU_VIV_LIB_TARGET)$(BR2_arm),fby)
+IMX_GPU_VIV_DEPENDENCIES += libdrm
+endif
+
 ifeq ($(IMX_GPU_VIV_LIB_TARGET),wayland)
-IMX_GPU_VIV_DEPENDENCIES += libdrm wayland
+IMX_GPU_VIV_DEPENDENCIES += wayland
 endif
 
 define IMX_GPU_VIV_EXTRACT_CMDS
-- 
2.26.3

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* [Buildroot] [PATCH v2 1/1] package/freescale-imx/imx-gpu-viv: select libdrm
  2021-04-29 18:51 [Buildroot] [PATCH v2 1/1] package/freescale-imx/imx-gpu-viv: select libdrm Sébastien Szymanski
@ 2021-05-04 12:55 ` Gary Bisson
  2021-05-04 20:35   ` Arnout Vandecappelle
  0 siblings, 1 reply; 3+ messages in thread
From: Gary Bisson @ 2021-05-04 12:55 UTC (permalink / raw)
  To: buildroot

Hi S?bastien,

On Thu, Apr 29, 2021 at 08:51:38PM +0200, S?bastien Szymanski wrote:
> Some libraries (libGL.so, vivante_dri.so, libEGL.so, libgbm_viv.so) are
> linked against libdrm so select libdrm package.
> 
> Fixes: 8283e838f040 ("package/freescale-imx/imx-gpu-viv: bump to version 6.4.3.p1.2")
> Signed-off-by: S?bastien Szymanski <sebastien.szymanski@armadeus.com>

Reviewed-by: Gary Bisson <gary.bisson@boundarydevices.com>
Tested-by: Gary Bisson <gary.bisson@boundarydevices.com>

Tested on Nitrogen8MP + fb backend, confirm that Vivante examples run
fine! Thanks for pointing it out!

Regards,
Gary

^ permalink raw reply	[flat|nested] 3+ messages in thread
* [Buildroot] [PATCH v2 1/1] package/freescale-imx/imx-gpu-viv: select libdrm
  2021-05-04 12:55 ` Gary Bisson
@ 2021-05-04 20:35   ` Arnout Vandecappelle
  0 siblings, 0 replies; 3+ messages in thread
From: Arnout Vandecappelle @ 2021-05-04 20:35 UTC (permalink / raw)
  To: buildroot



On 04/05/2021 14:55, Gary Bisson wrote:
> Hi S?bastien,
> 
> On Thu, Apr 29, 2021 at 08:51:38PM +0200, S?bastien Szymanski wrote:
>> Some libraries (libGL.so, vivante_dri.so, libEGL.so, libgbm_viv.so) are
>> linked against libdrm so select libdrm package.
>>
>> Fixes: 8283e838f040 ("package/freescale-imx/imx-gpu-viv: bump to version 6.4.3.p1.2")
>> Signed-off-by: S?bastien Szymanski <sebastien.szymanski@armadeus.com>

 Applied to master, thanks.


> 
> Reviewed-by: Gary Bisson <gary.bisson@boundarydevices.com>
> Tested-by: Gary Bisson <gary.bisson@boundarydevices.com>
> 
> Tested on Nitrogen8MP + fb backend, confirm that Vivante examples run
> fine! Thanks for pointing it out!

 Thanks for testing!

 Regards,
 Arnout

> 
> Regards,
> Gary
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-04 20:35 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-29 18:51 [Buildroot] [PATCH v2 1/1] package/freescale-imx/imx-gpu-viv: select libdrm Sébastien Szymanski
2021-05-04 12:55 ` Gary Bisson
2021-05-04 20:35   ` Arnout Vandecappelle

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.