From: Ansuel Smith <ansuelsmth@gmail.com> To: Florian Fainelli <f.fainelli@gmail.com> Cc: Nicolas Ferre <nicolas.ferre@microchip.com>, Claudiu Beznea <claudiu.beznea@microchip.com>, "David S. Miller" <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org>, Giuseppe Cavallaro <peppe.cavallaro@st.com>, Alexandre Torgue <alexandre.torgue@foss.st.com>, Jose Abreu <joabreu@synopsys.com>, Maxime Coquelin <mcoquelin.stm32@gmail.com>, Russell King <linux@armlinux.org.uk>, Andrew Lunn <andrew@lunn.ch>, Heiner Kallweit <hkallweit1@gmail.com>, Vivien Didelot <vivien.didelot@gmail.com>, Vladimir Oltean <olteanv@gmail.com>, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [RFC PATCH net-next v3 17/20] net: phy: phylink: permit to pass dev_flags to phylink_connect_phy Date: Wed, 5 May 2021 02:35:25 +0200 [thread overview] Message-ID: <YJHoTYfa03Yq5NwZ@Ansuel-xps.localdomain> (raw) In-Reply-To: <79cd97fe-02e8-4373-75a5-78ad0179c42b@gmail.com> On Tue, May 04, 2021 at 03:33:36PM -0700, Florian Fainelli wrote: > On 5/4/21 3:29 PM, Ansuel Smith wrote: > > Add support for phylink_connect_phy to pass dev_flags to the PHY driver. > > Change any user of phylink_connect_phy to pass 0 as dev_flags by > > default. > > > > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com> > > I do not think that this patch and the next one are necessary at all, > because phylink_of_phy_connect() already supports passing a dev_flags. > > That means that you should be representing the switch's internal MDIO > bus in the Device Tree and then describe how each port of the switch > connects to the internal PHY on that same bus. Once you do that the > logic in net/dsa/slave.c will call phylink_of_phy_connect() and all you > will have to do is implement dsa_switch_ops::get_phy_flags. Can you try > that? I did some testing. Just to make sure I'm correctly implementing this I'm using the phy-handle binding and the phy-mode set to internal. It does work with a quick test but I think with this implementation we would be back to this problem [0]. (I'm declaring the phy_port to the top mdio driver like it was done before [0]) I was thinking if a good solution would be to register a internal mdio driver in the qca8k code so that it can use the MASTER reg. (it's late here so I could be very confused about this) I think that using this solution we would be able to better describe the phy by declaring them INSIDE the switch node instead of declaring them outside in the top mdio node. The internal mdio driver would register with this new mdio node inside the switch node and use the custom mdio read/write that use the MASTER reg. [0] http://patchwork.ozlabs.org/project/netdev/patch/20190319195419.12746-3-chunkeey@gmail.com/ > -- > Florian
WARNING: multiple messages have this Message-ID (diff)
From: Ansuel Smith <ansuelsmth@gmail.com> To: Florian Fainelli <f.fainelli@gmail.com> Cc: Andrew Lunn <andrew@lunn.ch>, Russell King <linux@armlinux.org.uk>, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Alexandre Torgue <alexandre.torgue@foss.st.com>, Vivien Didelot <vivien.didelot@gmail.com>, Jose Abreu <joabreu@synopsys.com>, linux-arm-kernel@lists.infradead.org, Maxime Coquelin <mcoquelin.stm32@gmail.com>, Giuseppe Cavallaro <peppe.cavallaro@st.com>, Jakub Kicinski <kuba@kernel.org>, Vladimir Oltean <olteanv@gmail.com>, Claudiu Beznea <claudiu.beznea@microchip.com>, "David S. Miller" <davem@davemloft.net>, linux-kernel@vger.kernel.org, Heiner Kallweit <hkallweit1@gmail.com> Subject: Re: [RFC PATCH net-next v3 17/20] net: phy: phylink: permit to pass dev_flags to phylink_connect_phy Date: Wed, 5 May 2021 02:35:25 +0200 [thread overview] Message-ID: <YJHoTYfa03Yq5NwZ@Ansuel-xps.localdomain> (raw) In-Reply-To: <79cd97fe-02e8-4373-75a5-78ad0179c42b@gmail.com> On Tue, May 04, 2021 at 03:33:36PM -0700, Florian Fainelli wrote: > On 5/4/21 3:29 PM, Ansuel Smith wrote: > > Add support for phylink_connect_phy to pass dev_flags to the PHY driver. > > Change any user of phylink_connect_phy to pass 0 as dev_flags by > > default. > > > > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com> > > I do not think that this patch and the next one are necessary at all, > because phylink_of_phy_connect() already supports passing a dev_flags. > > That means that you should be representing the switch's internal MDIO > bus in the Device Tree and then describe how each port of the switch > connects to the internal PHY on that same bus. Once you do that the > logic in net/dsa/slave.c will call phylink_of_phy_connect() and all you > will have to do is implement dsa_switch_ops::get_phy_flags. Can you try > that? I did some testing. Just to make sure I'm correctly implementing this I'm using the phy-handle binding and the phy-mode set to internal. It does work with a quick test but I think with this implementation we would be back to this problem [0]. (I'm declaring the phy_port to the top mdio driver like it was done before [0]) I was thinking if a good solution would be to register a internal mdio driver in the qca8k code so that it can use the MASTER reg. (it's late here so I could be very confused about this) I think that using this solution we would be able to better describe the phy by declaring them INSIDE the switch node instead of declaring them outside in the top mdio node. The internal mdio driver would register with this new mdio node inside the switch node and use the custom mdio read/write that use the MASTER reg. [0] http://patchwork.ozlabs.org/project/netdev/patch/20190319195419.12746-3-chunkeey@gmail.com/ > -- > Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-05 0:35 UTC|newest] Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-04 22:28 [RFC PATCH net-next v3 01/20] net: mdio: ipq8064: clean whitespaces in define Ansuel Smith 2021-05-04 22:28 ` [RFC PATCH net-next v3 02/20] net: mdio: ipq8064: add regmap config to disable REGCACHE Ansuel Smith 2021-05-04 22:28 ` [RFC PATCH net-next v3 03/20] net: mdio: ipq8064: enlarge sleep after read/write operation Ansuel Smith 2021-05-04 22:28 ` [RFC PATCH net-next v3 04/20] net: dsa: qca8k: handle qca8k_set_page errors Ansuel Smith 2021-05-05 0:25 ` Andrew Lunn 2021-05-05 0:26 ` Andrew Lunn 2021-05-04 22:28 ` [RFC PATCH net-next v3 05/20] net: dsa: qca8k: handle error with qca8k_read operation Ansuel Smith 2021-05-05 0:36 ` Andrew Lunn 2021-05-05 0:44 ` Ansuel Smith 2021-05-04 22:29 ` [RFC PATCH net-next v3 06/20] net: dsa: qca8k: handle error with qca8k_write operation Ansuel Smith 2021-05-05 0:41 ` Andrew Lunn 2021-05-05 0:47 ` Ansuel Smith 2021-05-06 11:19 ` Vladimir Oltean 2021-05-04 22:29 ` [RFC PATCH net-next v3 07/20] net: dsa: qca8k: handle error with qca8k_rmw operation Ansuel Smith 2021-05-05 0:46 ` Andrew Lunn 2021-05-05 0:51 ` Ansuel Smith 2021-05-04 22:29 ` [RFC PATCH net-next v3 08/20] net: dsa: qca8k: add support for qca8327 switch Ansuel Smith 2021-05-05 0:48 ` Andrew Lunn 2021-05-06 11:20 ` Vladimir Oltean 2021-05-04 22:29 ` [RFC PATCH net-next v3 09/20] devicetree: net: dsa: qca8k: Document new compatible qca8327 Ansuel Smith 2021-05-05 0:48 ` Andrew Lunn 2021-05-06 21:07 ` Rob Herring 2021-05-04 22:29 ` [RFC PATCH net-next v3 10/20] net: dsa: qca8k: add priority tweak to qca8337 switch Ansuel Smith 2021-05-05 0:53 ` Andrew Lunn 2021-05-06 11:16 ` Vladimir Oltean 2021-05-04 22:29 ` [RFC PATCH net-next v3 11/20] net: dsa: qca8k: add GLOBAL_FC settings needed for qca8327 Ansuel Smith 2021-05-05 0:54 ` Andrew Lunn 2021-05-04 22:29 ` [RFC PATCH net-next v3 12/20] net: dsa: qca8k: add support for switch rev Ansuel Smith 2021-05-04 22:29 ` [RFC PATCH net-next v3 13/20] net: dsa: qca8k: make rgmii delay configurable Ansuel Smith 2021-05-05 1:00 ` Andrew Lunn 2021-05-05 1:07 ` Ansuel Smith 2021-05-06 11:10 ` Vladimir Oltean 2021-05-06 21:53 ` Ansuel Smith 2021-05-07 8:51 ` Vladimir Oltean 2021-05-04 22:29 ` [RFC PATCH net-next v3 14/20] net: dsa: qca8k: clear MASTER_EN after phy read/write Ansuel Smith 2021-05-04 22:29 ` [RFC PATCH net-next v3 15/20] net: dsa: qca8k: dsa: qca8k: protect MASTER busy_wait with mdio mutex Ansuel Smith 2021-05-05 1:04 ` Andrew Lunn 2021-05-04 22:29 ` [RFC PATCH net-next v3 16/20] net: dsa: qca8k: enlarge mdio delay and timeout Ansuel Smith 2021-05-06 11:27 ` Vladimir Oltean 2021-05-04 22:29 ` [RFC PATCH net-next v3 17/20] net: phy: phylink: permit to pass dev_flags to phylink_connect_phy Ansuel Smith 2021-05-04 22:29 ` Ansuel Smith 2021-05-04 22:33 ` Florian Fainelli 2021-05-04 22:33 ` Florian Fainelli 2021-05-05 0:35 ` Ansuel Smith [this message] 2021-05-05 0:35 ` Ansuel Smith 2021-05-04 22:29 ` [RFC PATCH net-next v3 18/20] net: dsa: slave: pass dev_flags also to internal PHY Ansuel Smith 2021-05-04 22:29 ` [RFC PATCH net-next v3 19/20] net: dsa: qca8k: pass switch_revision info to phy dev_flags Ansuel Smith 2021-05-06 11:24 ` Vladimir Oltean 2021-05-07 23:26 ` Ansuel Smith 2021-05-07 23:33 ` Russell King - ARM Linux admin 2021-05-07 23:51 ` Ansuel Smith 2021-05-08 17:31 ` Andrew Lunn 2021-05-08 18:26 ` Vladimir Oltean 2021-05-08 19:39 ` Russell King - ARM Linux admin 2021-05-08 20:55 ` Andrew Lunn 2021-05-07 9:44 ` Russell King - ARM Linux admin 2021-05-04 22:29 ` [RFC PATCH net-next v3 20/20] net: phy: add qca8k driver for qca8k switch internal PHY Ansuel Smith 2021-05-05 1:11 ` Andrew Lunn 2021-05-05 1:17 ` Ansuel Smith 2021-05-05 12:06 ` Andrew Lunn 2021-05-04 22:29 ` [RFC PATCH next-next v3 00/20] Multiple improvement to qca8k stability Ansuel Smith 2021-05-05 0:17 ` [RFC PATCH net-next v3 01/20] net: mdio: ipq8064: clean whitespaces in define Andrew Lunn
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YJHoTYfa03Yq5NwZ@Ansuel-xps.localdomain \ --to=ansuelsmth@gmail.com \ --cc=alexandre.torgue@foss.st.com \ --cc=andrew@lunn.ch \ --cc=claudiu.beznea@microchip.com \ --cc=davem@davemloft.net \ --cc=f.fainelli@gmail.com \ --cc=hkallweit1@gmail.com \ --cc=joabreu@synopsys.com \ --cc=kuba@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-stm32@st-md-mailman.stormreply.com \ --cc=linux@armlinux.org.uk \ --cc=mcoquelin.stm32@gmail.com \ --cc=netdev@vger.kernel.org \ --cc=nicolas.ferre@microchip.com \ --cc=olteanv@gmail.com \ --cc=peppe.cavallaro@st.com \ --cc=vivien.didelot@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.