[LTP] [COMMITTED] [PATCH] syscalls: modify_ldt02: Fix failure

[LTP] [COMMITTED] [PATCH] syscalls: modify_ldt02: Fix failure

[zhaogongyi]

Hi Cyril, Petr,

I am sorry, It's my fault. It seems that restore to origin code is more better since it might create a core file.

Best Regards,
Gongyi


> 
> The test was wrong to begin with, if we want to get SEGFAULT from the
> waitpid() we cannot setup a handler that catches it and exits with 0.
> 
> Fixes: f5e8e6b11ce8 ("syscalls/modify_ldt: Replace TINFO with TPASS or
> TFAIL")
> Reported-by: Petr Vorel <pvorel@suse.cz>
> Signed-off-by: Cyril Hrubis <chrubis@suse.cz>
> ---
>  .../kernel/syscalls/modify_ldt/modify_ldt02.c     | 15 +--------------
>  1 file changed, 1 insertion(+), 14 deletions(-)
> 
> diff --git a/testcases/kernel/syscalls/modify_ldt/modify_ldt02.c
> b/testcases/kernel/syscalls/modify_ldt/modify_ldt02.c
> index e34d3d54d..f911aa5fd 100644
> --- a/testcases/kernel/syscalls/modify_ldt/modify_ldt02.c
> +++ b/testcases/kernel/syscalls/modify_ldt/modify_ldt02.c
> @@ -120,6 +120,7 @@ int main(int ac, char **av)
> 
>  		tst_old_flush();
>  		if ((pid = FORK_OR_VFORK()) == 0) {
> +			signal(SIGSEGV, SIG_DFL);
>  			val = read_segment(0);
>  			exit(1);
>  		}
> @@ -168,24 +169,10 @@ int read_segment(unsigned int index)
>  	return res;
>  }
> 
> -void sigsegv_handler(int sig)
> -{
> -	tst_resm(TINFO, "received signal: %d", sig);
> -	exit(0);
> -}
> -
>  void setup(void)
>  {
> -	struct sigaction act;
> -
> -	memset(&act, 0, sizeof(act));
> -	sigemptyset(&act.sa_mask);
> -
>  	tst_sig(FORK, DEF_HANDLER, cleanup);
> 
> -	act.sa_handler = sigsegv_handler;
> -	(void)sigaction(SIGSEGV, &act, NULL);
> -
>  	TEST_PAUSE;
>  }
> 
> --
> 2.26.3
> 
> 
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp

[LTP] [COMMITTED] [PATCH] syscalls: modify_ldt02: Fix failure

[Cyril Hrubis]

Hi!
> I am sorry, It's my fault. It seems that restore to origin code is
> more better since it might create a core file.

No this is not solution either, since the original code was broken to
begin with.

We do have tst_no_corefile() in the test library, which should be called
by tests that cause SEGFAULT on purpose in order to avoid dumping a
core, but it looks like it's available only for new library tests. We
would have to convert the test to new library first if we wanted to
that.

-- 
Cyril Hrubis
chrubis@suse.cz

[LTP] [COMMITTED] [PATCH] syscalls: modify_ldt02: Fix failure

[Petr Vorel]

> Hi!
> > I am sorry, It's my fault. It seems that restore to origin code is
> > more better since it might create a core file.

> No this is not solution either, since the original code was broken to
> begin with.

> We do have tst_no_corefile() in the test library, which should be called
> by tests that cause SEGFAULT on purpose in order to avoid dumping a
> core, but it looks like it's available only for new library tests. We
> would have to convert the test to new library first if we wanted to
> that.

Thanks for info, I was not aware of tst_no_corefile().

Kind regards,
Petr

[LTP] [COMMITTED] [PATCH] syscalls: modify_ldt02: Fix failure

[Petr Vorel]

Hi Cyril,

> The test was wrong to begin with, if we want to get SEGFAULT from the
> waitpid() we cannot setup a handler that catches it and exits with 0.

> Fixes: f5e8e6b11ce8 ("syscalls/modify_ldt: Replace TINFO with TPASS or TFAIL")

Thanks a lot!

Kind regards,
Petr

[LTP] [COMMITTED] [PATCH] syscalls: modify_ldt02: Fix failure

[Cyril Hrubis]

The test was wrong to begin with, if we want to get SEGFAULT from the
waitpid() we cannot setup a handler that catches it and exits with 0.

Fixes: f5e8e6b11ce8 ("syscalls/modify_ldt: Replace TINFO with TPASS or TFAIL")
Reported-by: Petr Vorel <pvorel@suse.cz>
Signed-off-by: Cyril Hrubis <chrubis@suse.cz>
---
 .../kernel/syscalls/modify_ldt/modify_ldt02.c     | 15 +--------------
 1 file changed, 1 insertion(+), 14 deletions(-)

diff --git a/testcases/kernel/syscalls/modify_ldt/modify_ldt02.c b/testcases/kernel/syscalls/modify_ldt/modify_ldt02.c
index e34d3d54d..f911aa5fd 100644
--- a/testcases/kernel/syscalls/modify_ldt/modify_ldt02.c
+++ b/testcases/kernel/syscalls/modify_ldt/modify_ldt02.c
@@ -120,6 +120,7 @@ int main(int ac, char **av)
 
 		tst_old_flush();
 		if ((pid = FORK_OR_VFORK()) == 0) {
+			signal(SIGSEGV, SIG_DFL);
 			val = read_segment(0);
 			exit(1);
 		}
@@ -168,24 +169,10 @@ int read_segment(unsigned int index)
 	return res;
 }
 
-void sigsegv_handler(int sig)
-{
-	tst_resm(TINFO, "received signal: %d", sig);
-	exit(0);
-}
-
 void setup(void)
 {
-	struct sigaction act;
-
-	memset(&act, 0, sizeof(act));
-	sigemptyset(&act.sa_mask);
-
 	tst_sig(FORK, DEF_HANDLER, cleanup);
 
-	act.sa_handler = sigsegv_handler;
-	(void)sigaction(SIGSEGV, &act, NULL);
-
 	TEST_PAUSE;
 }
 
-- 
2.26.3