From: Daniel Vetter <daniel@ffwll.ch> To: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com> Cc: Dave Airlie <airlied@redhat.com>, intel-gfx@lists.freedesktop.org, Jason Ekstrand <jason@jlekstrand.net>, dri-devel@lists.freedesktop.org, Daniel Vetter <daniel.vetter@intel.com> Subject: Re: [PATCH] drm/i915: Add relocation exceptions for two other platforms Date: Tue, 11 May 2021 19:04:56 +0200 [thread overview] Message-ID: <YJq5OHIO8ThIiKCz@phenom.ffwll.local> (raw) In-Reply-To: <20210511083139.54002-1-zbigniew.kempczynski@intel.com> On Tue, May 11, 2021 at 10:31:39AM +0200, Zbigniew Kempczyński wrote: > We have established previously we stop using relocations starting > from gen12 platforms with Tigerlake as an exception. Unfortunately > we need extend transition period and support relocations for two > other igfx platforms - Rocketlake and Alderlake. > > Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com> > Cc: Dave Airlie <airlied@redhat.com> > Cc: Daniel Vetter <daniel.vetter@intel.com> > Cc: Jason Ekstrand <jason@jlekstrand.net> So the annoying thing here is that now media-driver is fixed: https://github.com/intel/media-driver/commit/144020c37770083974bedf59902b70b8f444c799 Which means igt is really the only thing left. Dave, is this still ok for an acked exception, or is this now leaning towards "just fix igt"? -Daniel > --- > drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c > index 297143511f99..f80da1d6d9b2 100644 > --- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c > +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c > @@ -496,11 +496,15 @@ eb_validate_vma(struct i915_execbuffer *eb, > struct drm_i915_gem_exec_object2 *entry, > struct i915_vma *vma) > { > - /* Relocations are disallowed for all platforms after TGL-LP. This > - * also covers all platforms with local memory. > + /* > + * Relocations are disallowed starting from gen12 with some exceptions > + * - TGL/RKL/ADL. > */ > if (entry->relocation_count && > - INTEL_GEN(eb->i915) >= 12 && !IS_TIGERLAKE(eb->i915)) > + INTEL_GEN(eb->i915) >= 12 && !(IS_TIGERLAKE(eb->i915) || > + IS_ROCKETLAKE(eb->i915) || > + IS_ALDERLAKE_S(eb->i915) || > + IS_ALDERLAKE_P(eb->i915))) > return -EINVAL; > > if (unlikely(entry->flags & eb->invalid_flags)) > -- > 2.26.0 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch> To: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com> Cc: Dave Airlie <airlied@redhat.com>, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Daniel Vetter <daniel.vetter@intel.com> Subject: Re: [Intel-gfx] [PATCH] drm/i915: Add relocation exceptions for two other platforms Date: Tue, 11 May 2021 19:04:56 +0200 [thread overview] Message-ID: <YJq5OHIO8ThIiKCz@phenom.ffwll.local> (raw) In-Reply-To: <20210511083139.54002-1-zbigniew.kempczynski@intel.com> On Tue, May 11, 2021 at 10:31:39AM +0200, Zbigniew Kempczyński wrote: > We have established previously we stop using relocations starting > from gen12 platforms with Tigerlake as an exception. Unfortunately > we need extend transition period and support relocations for two > other igfx platforms - Rocketlake and Alderlake. > > Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com> > Cc: Dave Airlie <airlied@redhat.com> > Cc: Daniel Vetter <daniel.vetter@intel.com> > Cc: Jason Ekstrand <jason@jlekstrand.net> So the annoying thing here is that now media-driver is fixed: https://github.com/intel/media-driver/commit/144020c37770083974bedf59902b70b8f444c799 Which means igt is really the only thing left. Dave, is this still ok for an acked exception, or is this now leaning towards "just fix igt"? -Daniel > --- > drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c > index 297143511f99..f80da1d6d9b2 100644 > --- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c > +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c > @@ -496,11 +496,15 @@ eb_validate_vma(struct i915_execbuffer *eb, > struct drm_i915_gem_exec_object2 *entry, > struct i915_vma *vma) > { > - /* Relocations are disallowed for all platforms after TGL-LP. This > - * also covers all platforms with local memory. > + /* > + * Relocations are disallowed starting from gen12 with some exceptions > + * - TGL/RKL/ADL. > */ > if (entry->relocation_count && > - INTEL_GEN(eb->i915) >= 12 && !IS_TIGERLAKE(eb->i915)) > + INTEL_GEN(eb->i915) >= 12 && !(IS_TIGERLAKE(eb->i915) || > + IS_ROCKETLAKE(eb->i915) || > + IS_ALDERLAKE_S(eb->i915) || > + IS_ALDERLAKE_P(eb->i915))) > return -EINVAL; > > if (unlikely(entry->flags & eb->invalid_flags)) > -- > 2.26.0 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-05-11 17:05 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-11 8:31 [PATCH] drm/i915: Add relocation exceptions for two other platforms Zbigniew Kempczyński 2021-05-11 8:31 ` [Intel-gfx] " Zbigniew Kempczyński 2021-05-11 9:10 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add relocation exceptions for two other platforms (rev2) Patchwork 2021-05-11 10:27 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2021-05-11 17:04 ` Daniel Vetter [this message] 2021-05-11 17:04 ` [Intel-gfx] [PATCH] drm/i915: Add relocation exceptions for two other platforms Daniel Vetter 2021-05-26 0:35 ` Dave Airlie 2021-05-26 0:35 ` Dave Airlie 2021-05-27 10:04 ` Daniel Vetter 2021-05-27 10:04 ` Daniel Vetter 2021-06-01 7:19 ` Dave Airlie 2021-06-01 7:19 ` Dave Airlie 2021-06-01 7:28 ` Daniel Vetter 2021-06-01 7:28 ` Daniel Vetter -- strict thread matches above, loose matches on Subject: below -- 2021-06-11 6:23 Zbigniew Kempczyński 2021-06-10 10:39 Zbigniew Kempczyński 2021-06-01 14:24 Zbigniew Kempczyński 2021-06-03 19:45 ` David Airlie 2021-06-09 13:14 ` Daniel Vetter 2021-06-01 8:28 Zbigniew Kempczyński 2021-04-28 17:30 Zbigniew Kempczyński
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YJq5OHIO8ThIiKCz@phenom.ffwll.local \ --to=daniel@ffwll.ch \ --cc=airlied@redhat.com \ --cc=daniel.vetter@intel.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ --cc=jason@jlekstrand.net \ --cc=zbigniew.kempczynski@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.