All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: "Boeuf, Sebastien" <sebastien.boeuf@intel.com>
Cc: "virtio-fs@redhat.com" <virtio-fs@redhat.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: vhost-user reconnection and crash recovery
Date: Tue, 11 May 2021 16:37:13 +0100	[thread overview]
Message-ID: <YJqkqYvWAAw3hZBG@stefanha-x1.localdomain> (raw)
In-Reply-To: <BY5PR11MB44018CADDC7A5C04F3D32BC4EA539@BY5PR11MB4401.namprd11.prod.outlook.com>

[-- Attachment #1: Type: text/plain, Size: 616 bytes --]

On Tue, May 11, 2021 at 03:00:05PM +0000, Boeuf, Sebastien wrote:
> But what about the vhost-user backend initialization? Does
> QEMU go again through initializing memory table, vrings, etc...
> since it can't assume anything from the backend?

Yes, the initial protocol messages are the same after reconnection.

In QEMU's vhost-user-blk implementation there is a special code path
involving vhost_dev_get_inflight(). This fetches and restores inflight
virtqueue request state. The restore logic is called by
vhost_user_blk_connect(). Aside from that reconnect is the same as
establishing a new connection.

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Stefan Hajnoczi <stefanha@redhat.com>
To: "Boeuf, Sebastien" <sebastien.boeuf@intel.com>
Cc: "virtio-fs@redhat.com" <virtio-fs@redhat.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Virtio-fs] vhost-user reconnection and crash recovery
Date: Tue, 11 May 2021 16:37:13 +0100	[thread overview]
Message-ID: <YJqkqYvWAAw3hZBG@stefanha-x1.localdomain> (raw)
In-Reply-To: <BY5PR11MB44018CADDC7A5C04F3D32BC4EA539@BY5PR11MB4401.namprd11.prod.outlook.com>

[-- Attachment #1: Type: text/plain, Size: 616 bytes --]

On Tue, May 11, 2021 at 03:00:05PM +0000, Boeuf, Sebastien wrote:
> But what about the vhost-user backend initialization? Does
> QEMU go again through initializing memory table, vrings, etc...
> since it can't assume anything from the backend?

Yes, the initial protocol messages are the same after reconnection.

In QEMU's vhost-user-blk implementation there is a special code path
involving vhost_dev_get_inflight(). This fetches and restores inflight
virtqueue request state. The restore logic is called by
vhost_user_blk_connect(). Aside from that reconnect is the same as
establishing a new connection.

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2021-05-11 15:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-11 15:00 vhost-user reconnection and crash recovery Boeuf, Sebastien
2021-05-11 15:00 ` [Virtio-fs] " Boeuf, Sebastien
2021-05-11 15:37 ` Stefan Hajnoczi [this message]
2021-05-11 15:37   ` Stefan Hajnoczi
2021-05-13  8:20 ` [Phishing Risk] [External] " Jiachen Zhang
2021-05-13  8:20   ` [Virtio-fs] [Phishing Risk] [External] " Jiachen Zhang
2021-05-13  8:26   ` [Virtio-fs] host-user " Dr. David Alan Gilbert
2021-05-13  8:26     ` Dr. David Alan Gilbert
2021-05-13  8:51     ` [External] " Jiachen Zhang
2021-05-13  8:51       ` [Virtio-fs] [External] " Jiachen Zhang
  -- strict thread matches above, loose matches on Subject: below --
2021-05-11 12:45 vhost-user " Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YJqkqYvWAAw3hZBG@stefanha-x1.localdomain \
    --to=stefanha@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=sebastien.boeuf@intel.com \
    --cc=virtio-fs@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.