* [PATCH -next] staging: rtl8723bs: Remove set but not used variable 'reason_code'
@ 2021-05-27 12:02 Baokun Li
2021-05-27 12:12 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Baokun Li @ 2021-05-27 12:02 UTC (permalink / raw)
To: gregkh, ross.schm.dev, fabioaiuto83, marcocesati, fmdefrancesco,
linux-staging, linux-kernel
Cc: weiyongjun1, yuehaibing, yangjihong1, yukuai3, libaokun1
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c: In function 'OnAction_back':
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c:1729:30: warning:
variable ‘reason_code’ set but not used [-Wunused-but-set-variable]
It never used since introduction.
Signed-off-by: Baokun Li <libaokun1@huawei.com>
---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
index 9fc612fb736f..97b3c2965770 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
@@ -1721,7 +1721,7 @@ unsigned int OnAction_back(struct adapter *padapter, union recv_frame *precv_fra
struct recv_reorder_ctrl *preorder_ctrl;
unsigned char *frame_body;
unsigned char category, action;
- unsigned short tid, status, reason_code = 0;
+ unsigned short tid, status;
struct mlme_ext_priv *pmlmeext = &padapter->mlmeextpriv;
struct mlme_ext_info *pmlmeinfo = &(pmlmeext->mlmext_info);
u8 *pframe = precv_frame->u.hdr.rx_data;
@@ -1790,9 +1790,6 @@ unsigned int OnAction_back(struct adapter *padapter, union recv_frame *precv_fra
~BIT((frame_body[3] >> 4) & 0xf);
psta->htpriv.candidate_tid_bitmap &=
~BIT((frame_body[3] >> 4) & 0xf);
-
- /* reason_code = frame_body[4] | (frame_body[5] << 8); */
- reason_code = get_unaligned_le16(&frame_body[4]);
} else if ((frame_body[3] & BIT(3)) == BIT(3)) {
tid = (frame_body[3] >> 4) & 0x0F;
--
2.25.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] staging: rtl8723bs: Remove set but not used variable 'reason_code'
2021-05-27 12:02 [PATCH -next] staging: rtl8723bs: Remove set but not used variable 'reason_code' Baokun Li
@ 2021-05-27 12:12 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2021-05-27 12:12 UTC (permalink / raw)
To: Baokun Li
Cc: ross.schm.dev, fabioaiuto83, marcocesati, fmdefrancesco,
linux-staging, linux-kernel, weiyongjun1, yuehaibing,
yangjihong1, yukuai3
On Thu, May 27, 2021 at 08:02:10PM +0800, Baokun Li wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/staging/rtl8723bs/core/rtw_mlme_ext.c: In function 'OnAction_back':
> drivers/staging/rtl8723bs/core/rtw_mlme_ext.c:1729:30: warning:
> variable ‘reason_code’ set but not used [-Wunused-but-set-variable]
>
> It never used since introduction.
>
> Signed-off-by: Baokun Li <libaokun1@huawei.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> index 9fc612fb736f..97b3c2965770 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
> @@ -1721,7 +1721,7 @@ unsigned int OnAction_back(struct adapter *padapter, union recv_frame *precv_fra
> struct recv_reorder_ctrl *preorder_ctrl;
> unsigned char *frame_body;
> unsigned char category, action;
> - unsigned short tid, status, reason_code = 0;
> + unsigned short tid, status;
> struct mlme_ext_priv *pmlmeext = &padapter->mlmeextpriv;
> struct mlme_ext_info *pmlmeinfo = &(pmlmeext->mlmext_info);
> u8 *pframe = precv_frame->u.hdr.rx_data;
> @@ -1790,9 +1790,6 @@ unsigned int OnAction_back(struct adapter *padapter, union recv_frame *precv_fra
> ~BIT((frame_body[3] >> 4) & 0xf);
> psta->htpriv.candidate_tid_bitmap &=
> ~BIT((frame_body[3] >> 4) & 0xf);
> -
> - /* reason_code = frame_body[4] | (frame_body[5] << 8); */
> - reason_code = get_unaligned_le16(&frame_body[4]);
> } else if ((frame_body[3] & BIT(3)) == BIT(3)) {
> tid = (frame_body[3] >> 4) & 0x0F;
>
> --
> 2.25.4
>
Does not apply to my tree. Are you _sure_ you are using the latest
version of linux-next?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-27 12:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-27 12:02 [PATCH -next] staging: rtl8723bs: Remove set but not used variable 'reason_code' Baokun Li
2021-05-27 12:12 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.