All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Rob Herring <robh+dt@kernel.org>
Cc: Kyle Tso <kyletso@google.com>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Badhri Jagan Sridharan <badhri@google.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v2] dt-bindings: connector: Replace BIT macro with generic bit ops
Date: Thu, 27 May 2021 15:02:51 +0200	[thread overview]
Message-ID: <YK+Ye9fCq2Z02qjl@kroah.com> (raw)
In-Reply-To: <CAL_JsqKGS--ZPUrhVkve3hK2EzWYeN2AATEpqB9PfNEzipfZzA@mail.gmail.com>

On Thu, May 27, 2021 at 07:52:24AM -0500, Rob Herring wrote:
> On Thu, May 27, 2021 at 7:41 AM Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > On Thu, May 27, 2021 at 08:10:29PM +0800, Kyle Tso wrote:
> > > BIT macro is not defined. Replace it with generic bit operations.
> > >
> > > Fixes: 630dce2810b9 ("dt-bindings: connector: Add SVDM VDO properties")
> > > Signed-off-by: Kyle Tso <kyletso@google.com>
> > > ---
> > > Changes since v1:
> > > - re-word the commit message
> > >
> > >  include/dt-bindings/usb/pd.h | 20 ++++++++++----------
> > >  1 file changed, 10 insertions(+), 10 deletions(-)
> > >
> > > diff --git a/include/dt-bindings/usb/pd.h b/include/dt-bindings/usb/pd.h
> > > index fef3ef65967f..cb70b4ceedde 100644
> > > --- a/include/dt-bindings/usb/pd.h
> > > +++ b/include/dt-bindings/usb/pd.h
> > > @@ -163,10 +163,10 @@
> > >  #define UFP_VDO_VER1_2               2
> > >
> > >  /* Device Capability */
> > > -#define DEV_USB2_CAPABLE     BIT(0)
> > > -#define DEV_USB2_BILLBOARD   BIT(1)
> > > -#define DEV_USB3_CAPABLE     BIT(2)
> > > -#define DEV_USB4_CAPABLE     BIT(3)
> > > +#define DEV_USB2_CAPABLE     (1 << 0)
> > > +#define DEV_USB2_BILLBOARD   (1 << 1)
> > > +#define DEV_USB3_CAPABLE     (1 << 2)
> > > +#define DEV_USB4_CAPABLE     (1 << 3)
> >
> > Why not just include the proper .h file instead?
> 
> Because the DT headers can't depend on kernel headers as they get used
> separately.

Lame.  :)

  reply	other threads:[~2021-05-27 13:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-27 12:10 [PATCH v2] dt-bindings: connector: Replace BIT macro with generic bit ops Kyle Tso
2021-05-27 12:41 ` Greg KH
2021-05-27 12:52   ` Rob Herring
2021-05-27 13:02     ` Greg KH [this message]
2021-06-02 20:18 ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YK+Ye9fCq2Z02qjl@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=badhri@google.com \
    --cc=devicetree@vger.kernel.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=kyletso@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.