From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Chunfeng Yun <chunfeng.yun@mediatek.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Thierry Reding <treding@nvidia.com>,
Paul Cercueil <paul@crapouillou.net>,
Lee Jones <lee.jones@linaro.org>,
Guenter Roeck <linux@roeck-us.net>,
Hans de Goede <hdegoede@redhat.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 1/2] usb: roles: add helper usb_role_string()
Date: Wed, 26 May 2021 09:31:55 +0300 [thread overview]
Message-ID: <YK3rW6NjED+07IdC@kuha.fi.intel.com> (raw)
In-Reply-To: <1621932786-9335-1-git-send-email-chunfeng.yun@mediatek.com>
On Tue, May 25, 2021 at 04:53:05PM +0800, Chunfeng Yun wrote:
> Introduces usb_role_string() function, which returns a
> human-readable name of provided usb role, it's useful to
> make the log readable.
>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/roles/class.c | 9 +++++++++
> include/linux/usb/role.h | 6 ++++++
> 2 files changed, 15 insertions(+)
>
> diff --git a/drivers/usb/roles/class.c b/drivers/usb/roles/class.c
> index 33b637d0d8d9..dfaed7eee94f 100644
> --- a/drivers/usb/roles/class.c
> +++ b/drivers/usb/roles/class.c
> @@ -214,6 +214,15 @@ static const char * const usb_roles[] = {
> [USB_ROLE_DEVICE] = "device",
> };
>
> +const char *usb_role_string(enum usb_role role)
> +{
> + if (role < 0 || role >= ARRAY_SIZE(usb_roles))
> + return "unknown";
> +
> + return usb_roles[role];
> +}
> +EXPORT_SYMBOL_GPL(usb_role_string);
> +
> static ssize_t
> role_show(struct device *dev, struct device_attribute *attr, char *buf)
> {
> diff --git a/include/linux/usb/role.h b/include/linux/usb/role.h
> index 0164fed31b06..031f148ab373 100644
> --- a/include/linux/usb/role.h
> +++ b/include/linux/usb/role.h
> @@ -65,6 +65,7 @@ void usb_role_switch_unregister(struct usb_role_switch *sw);
>
> void usb_role_switch_set_drvdata(struct usb_role_switch *sw, void *data);
> void *usb_role_switch_get_drvdata(struct usb_role_switch *sw);
> +const char *usb_role_string(enum usb_role role);
> #else
> static inline int usb_role_switch_set_role(struct usb_role_switch *sw,
> enum usb_role role)
> @@ -109,6 +110,11 @@ static inline void *usb_role_switch_get_drvdata(struct usb_role_switch *sw)
> return NULL;
> }
>
> +static inline const char *usb_role_string(enum usb_role role)
> +{
> + return "unknown";
> +}
> +
> #endif
>
> #endif /* __LINUX_USB_ROLE_H */
> --
> 2.18.0
--
heikki
WARNING: multiple messages have this Message-ID (diff)
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Chunfeng Yun <chunfeng.yun@mediatek.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Thierry Reding <treding@nvidia.com>,
Paul Cercueil <paul@crapouillou.net>,
Lee Jones <lee.jones@linaro.org>,
Guenter Roeck <linux@roeck-us.net>,
Hans de Goede <hdegoede@redhat.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 1/2] usb: roles: add helper usb_role_string()
Date: Wed, 26 May 2021 09:31:55 +0300 [thread overview]
Message-ID: <YK3rW6NjED+07IdC@kuha.fi.intel.com> (raw)
In-Reply-To: <1621932786-9335-1-git-send-email-chunfeng.yun@mediatek.com>
On Tue, May 25, 2021 at 04:53:05PM +0800, Chunfeng Yun wrote:
> Introduces usb_role_string() function, which returns a
> human-readable name of provided usb role, it's useful to
> make the log readable.
>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/roles/class.c | 9 +++++++++
> include/linux/usb/role.h | 6 ++++++
> 2 files changed, 15 insertions(+)
>
> diff --git a/drivers/usb/roles/class.c b/drivers/usb/roles/class.c
> index 33b637d0d8d9..dfaed7eee94f 100644
> --- a/drivers/usb/roles/class.c
> +++ b/drivers/usb/roles/class.c
> @@ -214,6 +214,15 @@ static const char * const usb_roles[] = {
> [USB_ROLE_DEVICE] = "device",
> };
>
> +const char *usb_role_string(enum usb_role role)
> +{
> + if (role < 0 || role >= ARRAY_SIZE(usb_roles))
> + return "unknown";
> +
> + return usb_roles[role];
> +}
> +EXPORT_SYMBOL_GPL(usb_role_string);
> +
> static ssize_t
> role_show(struct device *dev, struct device_attribute *attr, char *buf)
> {
> diff --git a/include/linux/usb/role.h b/include/linux/usb/role.h
> index 0164fed31b06..031f148ab373 100644
> --- a/include/linux/usb/role.h
> +++ b/include/linux/usb/role.h
> @@ -65,6 +65,7 @@ void usb_role_switch_unregister(struct usb_role_switch *sw);
>
> void usb_role_switch_set_drvdata(struct usb_role_switch *sw, void *data);
> void *usb_role_switch_get_drvdata(struct usb_role_switch *sw);
> +const char *usb_role_string(enum usb_role role);
> #else
> static inline int usb_role_switch_set_role(struct usb_role_switch *sw,
> enum usb_role role)
> @@ -109,6 +110,11 @@ static inline void *usb_role_switch_get_drvdata(struct usb_role_switch *sw)
> return NULL;
> }
>
> +static inline const char *usb_role_string(enum usb_role role)
> +{
> + return "unknown";
> +}
> +
> #endif
>
> #endif /* __LINUX_USB_ROLE_H */
> --
> 2.18.0
--
heikki
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Chunfeng Yun <chunfeng.yun@mediatek.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Thierry Reding <treding@nvidia.com>,
Paul Cercueil <paul@crapouillou.net>,
Lee Jones <lee.jones@linaro.org>,
Guenter Roeck <linux@roeck-us.net>,
Hans de Goede <hdegoede@redhat.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 1/2] usb: roles: add helper usb_role_string()
Date: Wed, 26 May 2021 09:31:55 +0300 [thread overview]
Message-ID: <YK3rW6NjED+07IdC@kuha.fi.intel.com> (raw)
In-Reply-To: <1621932786-9335-1-git-send-email-chunfeng.yun@mediatek.com>
On Tue, May 25, 2021 at 04:53:05PM +0800, Chunfeng Yun wrote:
> Introduces usb_role_string() function, which returns a
> human-readable name of provided usb role, it's useful to
> make the log readable.
>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/roles/class.c | 9 +++++++++
> include/linux/usb/role.h | 6 ++++++
> 2 files changed, 15 insertions(+)
>
> diff --git a/drivers/usb/roles/class.c b/drivers/usb/roles/class.c
> index 33b637d0d8d9..dfaed7eee94f 100644
> --- a/drivers/usb/roles/class.c
> +++ b/drivers/usb/roles/class.c
> @@ -214,6 +214,15 @@ static const char * const usb_roles[] = {
> [USB_ROLE_DEVICE] = "device",
> };
>
> +const char *usb_role_string(enum usb_role role)
> +{
> + if (role < 0 || role >= ARRAY_SIZE(usb_roles))
> + return "unknown";
> +
> + return usb_roles[role];
> +}
> +EXPORT_SYMBOL_GPL(usb_role_string);
> +
> static ssize_t
> role_show(struct device *dev, struct device_attribute *attr, char *buf)
> {
> diff --git a/include/linux/usb/role.h b/include/linux/usb/role.h
> index 0164fed31b06..031f148ab373 100644
> --- a/include/linux/usb/role.h
> +++ b/include/linux/usb/role.h
> @@ -65,6 +65,7 @@ void usb_role_switch_unregister(struct usb_role_switch *sw);
>
> void usb_role_switch_set_drvdata(struct usb_role_switch *sw, void *data);
> void *usb_role_switch_get_drvdata(struct usb_role_switch *sw);
> +const char *usb_role_string(enum usb_role role);
> #else
> static inline int usb_role_switch_set_role(struct usb_role_switch *sw,
> enum usb_role role)
> @@ -109,6 +110,11 @@ static inline void *usb_role_switch_get_drvdata(struct usb_role_switch *sw)
> return NULL;
> }
>
> +static inline const char *usb_role_string(enum usb_role role)
> +{
> + return "unknown";
> +}
> +
> #endif
>
> #endif /* __LINUX_USB_ROLE_H */
> --
> 2.18.0
--
heikki
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-26 6:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-25 8:53 [PATCH 1/2] usb: roles: add helper usb_role_string() Chunfeng Yun
2021-05-25 8:53 ` Chunfeng Yun
2021-05-25 8:53 ` Chunfeng Yun
2021-05-25 8:53 ` [PATCH 2/2] usb: common: usb-conn-gpio: use usb_role_string() to print role status Chunfeng Yun
2021-05-25 8:53 ` Chunfeng Yun
2021-05-25 8:53 ` Chunfeng Yun
2021-05-26 6:31 ` Heikki Krogerus [this message]
2021-05-26 6:31 ` [PATCH 1/2] usb: roles: add helper usb_role_string() Heikki Krogerus
2021-05-26 6:31 ` Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YK3rW6NjED+07IdC@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=chunfeng.yun@mediatek.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=matthias.bgg@gmail.com \
--cc=paul@crapouillou.net \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.