* [PATCH 1/1] sched/topology: Fix a spelling mistake in error message
@ 2021-05-26 2:18 Zhen Lei
2021-05-26 2:32 ` Randy Dunlap
2021-05-26 6:51 ` Ingo Molnar
0 siblings, 2 replies; 8+ messages in thread
From: Zhen Lei @ 2021-05-26 2:18 UTC (permalink / raw)
To: Ingo Molnar, Peter Zijlstra, Juri Lelli, Vincent Guittot,
Dietmar Eggemann, Steven Rostedt, Ben Segall, Mel Gorman,
Daniel Bristot de Oliveira, linux-kernel
Cc: Zhen Lei
The misspelled word 'borken' should be 'broken'.
Fixes: 6ae72dff3759 ("sched: Robustify topology setup")
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
kernel/sched/topology.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
index 55a0a243e871..80295e224442 100644
--- a/kernel/sched/topology.c
+++ b/kernel/sched/topology.c
@@ -1937,7 +1937,7 @@ static struct sched_domain *build_sched_domain(struct sched_domain_topology_leve
if (!cpumask_subset(sched_domain_span(child),
sched_domain_span(sd))) {
- pr_err("BUG: arch topology borken\n");
+ pr_err("BUG: arch topology broken\n");
#ifdef CONFIG_SCHED_DEBUG
pr_err(" the %s domain not a subset of the %s domain\n",
child->name, sd->name);
--
2.25.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 1/1] sched/topology: Fix a spelling mistake in error message
2021-05-26 2:18 [PATCH 1/1] sched/topology: Fix a spelling mistake in error message Zhen Lei
@ 2021-05-26 2:32 ` Randy Dunlap
2021-05-26 2:42 ` Leizhen (ThunderTown)
2021-05-26 6:51 ` Ingo Molnar
1 sibling, 1 reply; 8+ messages in thread
From: Randy Dunlap @ 2021-05-26 2:32 UTC (permalink / raw)
To: Zhen Lei, Ingo Molnar, Peter Zijlstra, Juri Lelli,
Vincent Guittot, Dietmar Eggemann, Steven Rostedt, Ben Segall,
Mel Gorman, Daniel Bristot de Oliveira, linux-kernel
On 5/25/21 7:18 PM, Zhen Lei wrote:
> The misspelled word 'borken' should be 'broken'.
>
> Fixes: 6ae72dff3759 ("sched: Robustify topology setup")
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> ---
> kernel/sched/topology.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
> index 55a0a243e871..80295e224442 100644
> --- a/kernel/sched/topology.c
> +++ b/kernel/sched/topology.c
> @@ -1937,7 +1937,7 @@ static struct sched_domain *build_sched_domain(struct sched_domain_topology_leve
>
> if (!cpumask_subset(sched_domain_span(child),
> sched_domain_span(sd))) {
> - pr_err("BUG: arch topology borken\n");
> + pr_err("BUG: arch topology broken\n");
Would "borked" or "b0rken" be clearer?
> #ifdef CONFIG_SCHED_DEBUG
> pr_err(" the %s domain not a subset of the %s domain\n",
> child->name, sd->name);
>
I.e., this is misspelt on purpose.
Reply to a previous version of this patch:
https://lore.kernel.org/lkml/1493036801.6266.12.camel@gmx.de/
cheers.
--
~Randy
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 1/1] sched/topology: Fix a spelling mistake in error message
2021-05-26 2:32 ` Randy Dunlap
@ 2021-05-26 2:42 ` Leizhen (ThunderTown)
2021-05-26 6:52 ` Ingo Molnar
2021-05-26 6:57 ` Peter Zijlstra
0 siblings, 2 replies; 8+ messages in thread
From: Leizhen (ThunderTown) @ 2021-05-26 2:42 UTC (permalink / raw)
To: Randy Dunlap, Ingo Molnar, Peter Zijlstra, Juri Lelli,
Vincent Guittot, Dietmar Eggemann, Steven Rostedt, Ben Segall,
Mel Gorman, Daniel Bristot de Oliveira, linux-kernel
On 2021/5/26 10:32, Randy Dunlap wrote:
> On 5/25/21 7:18 PM, Zhen Lei wrote:
>> The misspelled word 'borken' should be 'broken'.
>>
>> Fixes: 6ae72dff3759 ("sched: Robustify topology setup")
>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
>> ---
>> kernel/sched/topology.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
>> index 55a0a243e871..80295e224442 100644
>> --- a/kernel/sched/topology.c
>> +++ b/kernel/sched/topology.c
>> @@ -1937,7 +1937,7 @@ static struct sched_domain *build_sched_domain(struct sched_domain_topology_leve
>>
>> if (!cpumask_subset(sched_domain_span(child),
>> sched_domain_span(sd))) {
>> - pr_err("BUG: arch topology borken\n");
>> + pr_err("BUG: arch topology broken\n");
>
> Would "borked" or "b0rken" be clearer?
These two words don't seem to exist at all. Linux is an open-source
code for the world, so it's better to use a more common word.
>
>> #ifdef CONFIG_SCHED_DEBUG
>> pr_err(" the %s domain not a subset of the %s domain\n",
>> child->name, sd->name);
>>
>
>
> I.e., this is misspelt on purpose.
>
> Reply to a previous version of this patch:
> https://lore.kernel.org/lkml/1493036801.6266.12.camel@gmx.de/
>
> cheers.
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 1/1] sched/topology: Fix a spelling mistake in error message
2021-05-26 2:42 ` Leizhen (ThunderTown)
@ 2021-05-26 6:52 ` Ingo Molnar
2021-05-27 1:57 ` Leizhen (ThunderTown)
2021-05-26 6:57 ` Peter Zijlstra
1 sibling, 1 reply; 8+ messages in thread
From: Ingo Molnar @ 2021-05-26 6:52 UTC (permalink / raw)
To: Leizhen (ThunderTown)
Cc: Randy Dunlap, Ingo Molnar, Peter Zijlstra, Juri Lelli,
Vincent Guittot, Dietmar Eggemann, Steven Rostedt, Ben Segall,
Mel Gorman, Daniel Bristot de Oliveira, linux-kernel
* Leizhen (ThunderTown) <thunder.leizhen@huawei.com> wrote:
>
>
> On 2021/5/26 10:32, Randy Dunlap wrote:
> > On 5/25/21 7:18 PM, Zhen Lei wrote:
> >> The misspelled word 'borken' should be 'broken'.
> >>
> >> Fixes: 6ae72dff3759 ("sched: Robustify topology setup")
> >> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> >> ---
> >> kernel/sched/topology.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
> >> index 55a0a243e871..80295e224442 100644
> >> --- a/kernel/sched/topology.c
> >> +++ b/kernel/sched/topology.c
> >> @@ -1937,7 +1937,7 @@ static struct sched_domain *build_sched_domain(struct sched_domain_topology_leve
> >>
> >> if (!cpumask_subset(sched_domain_span(child),
> >> sched_domain_span(sd))) {
> >> - pr_err("BUG: arch topology borken\n");
> >> + pr_err("BUG: arch topology broken\n");
> >
> > Would "borked" or "b0rken" be clearer?
>
> These two words don't seem to exist at all. Linux is an open-source
> code for the world, so it's better to use a more common word.
What?
Please google:
"borken" meaning
Please stop these pointless patches.
Thanks,
Ingo
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 1/1] sched/topology: Fix a spelling mistake in error message
2021-05-26 6:52 ` Ingo Molnar
@ 2021-05-27 1:57 ` Leizhen (ThunderTown)
0 siblings, 0 replies; 8+ messages in thread
From: Leizhen (ThunderTown) @ 2021-05-27 1:57 UTC (permalink / raw)
To: Ingo Molnar
Cc: Randy Dunlap, Ingo Molnar, Peter Zijlstra, Juri Lelli,
Vincent Guittot, Dietmar Eggemann, Steven Rostedt, Ben Segall,
Mel Gorman, Daniel Bristot de Oliveira, linux-kernel
On 2021/5/26 14:52, Ingo Molnar wrote:
>
> * Leizhen (ThunderTown) <thunder.leizhen@huawei.com> wrote:
>
>>
>>
>> On 2021/5/26 10:32, Randy Dunlap wrote:
>>> On 5/25/21 7:18 PM, Zhen Lei wrote:
>>>> The misspelled word 'borken' should be 'broken'.
>>>>
>>>> Fixes: 6ae72dff3759 ("sched: Robustify topology setup")
>>>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
>>>> ---
>>>> kernel/sched/topology.c | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
>>>> index 55a0a243e871..80295e224442 100644
>>>> --- a/kernel/sched/topology.c
>>>> +++ b/kernel/sched/topology.c
>>>> @@ -1937,7 +1937,7 @@ static struct sched_domain *build_sched_domain(struct sched_domain_topology_leve
>>>>
>>>> if (!cpumask_subset(sched_domain_span(child),
>>>> sched_domain_span(sd))) {
>>>> - pr_err("BUG: arch topology borken\n");
>>>> + pr_err("BUG: arch topology broken\n");
>>>
>>> Would "borked" or "b0rken" be clearer?
>>
>> These two words don't seem to exist at all. Linux is an open-source
>> code for the world, so it's better to use a more common word.
>
> What?
>
> Please google:
>
> "borken" meaning
Hi, Ingo and Randy:
I apologize to you both. In fact, I googled 'borken' before posting this patch.
But the result is: Borken is a German town. But I really didn't Google "borked"
and "b0rken", I just looked it up with an English dictionary software, but it
doesn't exist.
As Randy's advice, it would be better to use "borked". At least it doesn't feel
like the 'r' and 'o' in "broken" are written in reverse order. There is no semantic
error in using "broken" in this sentence.
>
> Please stop these pointless patches.
He who does not know is not guilty.
>
> Thanks,
>
> Ingo
>
> .
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] sched/topology: Fix a spelling mistake in error message
2021-05-26 2:42 ` Leizhen (ThunderTown)
2021-05-26 6:52 ` Ingo Molnar
@ 2021-05-26 6:57 ` Peter Zijlstra
2021-05-26 8:28 ` Leizhen (ThunderTown)
1 sibling, 1 reply; 8+ messages in thread
From: Peter Zijlstra @ 2021-05-26 6:57 UTC (permalink / raw)
To: Leizhen (ThunderTown)
Cc: Randy Dunlap, Ingo Molnar, Juri Lelli, Vincent Guittot,
Dietmar Eggemann, Steven Rostedt, Ben Segall, Mel Gorman,
Daniel Bristot de Oliveira, linux-kernel
On Wed, May 26, 2021 at 10:42:31AM +0800, Leizhen (ThunderTown) wrote:
>
>
> On 2021/5/26 10:32, Randy Dunlap wrote:
> > On 5/25/21 7:18 PM, Zhen Lei wrote:
> >> The misspelled word 'borken' should be 'broken'.
> >>
> >> Fixes: 6ae72dff3759 ("sched: Robustify topology setup")
> >> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> >> ---
> >> kernel/sched/topology.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
> >> index 55a0a243e871..80295e224442 100644
> >> --- a/kernel/sched/topology.c
> >> +++ b/kernel/sched/topology.c
> >> @@ -1937,7 +1937,7 @@ static struct sched_domain *build_sched_domain(struct sched_domain_topology_leve
> >>
> >> if (!cpumask_subset(sched_domain_span(child),
> >> sched_domain_span(sd))) {
> >> - pr_err("BUG: arch topology borken\n");
> >> + pr_err("BUG: arch topology broken\n");
> >
> > Would "borked" or "b0rken" be clearer?
>
> These two words don't seem to exist at all. Linux is an open-source
> code for the world, so it's better to use a more common word.
Language is a living thing; also:
https://www.urbandictionary.com/define.php?term=borked
I realize that as a non-native speaker idioms and colloquialisms are
difficult, but if we sanitize the language we'll end up with something
dreadfully dull and less expressive.
Also; this is a rather trivial play on words, to break the word broken,
it should apply to pretty much any (written) language. It should be an
evident pun to all except computer spell checkers (they so lack humour).
Also, I too am a non-native speaker, although I suspect I have it easier
for my native tongue is at least in the same language group as English.
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 1/1] sched/topology: Fix a spelling mistake in error message
2021-05-26 6:57 ` Peter Zijlstra
@ 2021-05-26 8:28 ` Leizhen (ThunderTown)
0 siblings, 0 replies; 8+ messages in thread
From: Leizhen (ThunderTown) @ 2021-05-26 8:28 UTC (permalink / raw)
To: Peter Zijlstra
Cc: Randy Dunlap, Ingo Molnar, Juri Lelli, Vincent Guittot,
Dietmar Eggemann, Steven Rostedt, Ben Segall, Mel Gorman,
Daniel Bristot de Oliveira, linux-kernel
On 2021/5/26 14:57, Peter Zijlstra wrote:
> On Wed, May 26, 2021 at 10:42:31AM +0800, Leizhen (ThunderTown) wrote:
>>
>>
>> On 2021/5/26 10:32, Randy Dunlap wrote:
>>> On 5/25/21 7:18 PM, Zhen Lei wrote:
>>>> The misspelled word 'borken' should be 'broken'.
>>>>
>>>> Fixes: 6ae72dff3759 ("sched: Robustify topology setup")
>>>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
>>>> ---
>>>> kernel/sched/topology.c | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
>>>> index 55a0a243e871..80295e224442 100644
>>>> --- a/kernel/sched/topology.c
>>>> +++ b/kernel/sched/topology.c
>>>> @@ -1937,7 +1937,7 @@ static struct sched_domain *build_sched_domain(struct sched_domain_topology_leve
>>>>
>>>> if (!cpumask_subset(sched_domain_span(child),
>>>> sched_domain_span(sd))) {
>>>> - pr_err("BUG: arch topology borken\n");
>>>> + pr_err("BUG: arch topology broken\n");
>>>
>>> Would "borked" or "b0rken" be clearer?
>>
>> These two words don't seem to exist at all. Linux is an open-source
>> code for the world, so it's better to use a more common word.
>
> Language is a living thing; also:
>
> https://www.urbandictionary.com/define.php?term=borked
OK, I got it. Thanks.
>
> I realize that as a non-native speaker idioms and colloquialisms are
> difficult, but if we sanitize the language we'll end up with something
> dreadfully dull and less expressive.
>
> Also; this is a rather trivial play on words, to break the word broken,
> it should apply to pretty much any (written) language. It should be an
> evident pun to all except computer spell checkers (they so lack humour).
>
> Also, I too am a non-native speaker, although I suspect I have it easier
> for my native tongue is at least in the same language group as English.
>
>
> .
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] sched/topology: Fix a spelling mistake in error message
2021-05-26 2:18 [PATCH 1/1] sched/topology: Fix a spelling mistake in error message Zhen Lei
2021-05-26 2:32 ` Randy Dunlap
@ 2021-05-26 6:51 ` Ingo Molnar
1 sibling, 0 replies; 8+ messages in thread
From: Ingo Molnar @ 2021-05-26 6:51 UTC (permalink / raw)
To: Zhen Lei
Cc: Ingo Molnar, Peter Zijlstra, Juri Lelli, Vincent Guittot,
Dietmar Eggemann, Steven Rostedt, Ben Segall, Mel Gorman,
Daniel Bristot de Oliveira, linux-kernel
* Zhen Lei <thunder.leizhen@huawei.com> wrote:
> The misspelled word 'borken' should be 'broken'.
>
> Fixes: 6ae72dff3759 ("sched: Robustify topology setup")
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
NAK. You are trying to 'fix' a joke.
Thanks,
Ingo
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-05-27 1:57 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-26 2:18 [PATCH 1/1] sched/topology: Fix a spelling mistake in error message Zhen Lei
2021-05-26 2:32 ` Randy Dunlap
2021-05-26 2:42 ` Leizhen (ThunderTown)
2021-05-26 6:52 ` Ingo Molnar
2021-05-27 1:57 ` Leizhen (ThunderTown)
2021-05-26 6:57 ` Peter Zijlstra
2021-05-26 8:28 ` Leizhen (ThunderTown)
2021-05-26 6:51 ` Ingo Molnar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.