Re: [PATCH v2] dt-bindings: net: Convert MDIO mux bindings to DT schema

From: Andrew Lunn <andrew@lunn.ch>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Ray Jui <rjui@broadcom.com>,
	Scott Branden <sbranden@broadcom.com>,
	bcm-kernel-feedback-list@broadcom.com,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] dt-bindings: net: Convert MDIO mux bindings to DT schema
Date: Wed, 26 May 2021 20:51:02 +0200	[thread overview]
Message-ID: <YK6YljEYXprM/8iD@lunn.ch> (raw)
In-Reply-To: <20210526181411.2888516-1-robh@kernel.org>

On Wed, May 26, 2021 at 01:14:11PM -0500, Rob Herring wrote:
> Convert the common MDIO mux bindings to DT schema.
> 
> Drop the example from mdio-mux.yaml as mdio-mux-gpio.yaml has the same one.
> 
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Ray Jui <rjui@broadcom.com>
> Cc: Scott Branden <sbranden@broadcom.com>
> Cc: bcm-kernel-feedback-list@broadcom.com
> Cc: Andrew Lunn <andrew@lunn.ch>
> Cc: Heiner Kallweit <hkallweit1@gmail.com>
> Cc: Russell King <linux@armlinux.org.uk>
> Cc: netdev@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Signed-off-by: Rob Herring <robh@kernel.org>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

> +        mdio@2 {  // Slot 2 XAUI (FM1)
> +            reg = <2>;
> +            #address-cells = <1>;
> +            #size-cells = <0>;
> +
> +            ethernet-phy@4 {
> +                compatible = "ethernet-phy-ieee802.3-c45";
> +                reg = <0>;

reg should really be 4 here. The same error existed in the .txt
version. I guess the examples are never actually verified using the
yaml?

	Andrew