From: Heikki Krogerus <heikki.krogerus@linux.intel.com> To: Li Jun <jun.li@nxp.com> Cc: robh+dt@kernel.org, shawnguo@kernel.org, gregkh@linuxfoundation.org, linux@roeck-us.net, linux-usb@vger.kernel.org, linux-imx@nxp.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/4] usb: typec: use typec cap fwnode's of_node for typec port Date: Thu, 20 May 2021 15:38:21 +0300 [thread overview] Message-ID: <YKZYPSsjSnp3tb/j@kuha.fi.intel.com> (raw) In-Reply-To: <1621408490-23811-3-git-send-email-jun.li@nxp.com> On Wed, May 19, 2021 at 03:14:48PM +0800, Li Jun wrote: > Asssign typec cap fwnode's of_node to typec port, then we can use > typec port device to get properties from its OF. > > Signed-off-by: Li Jun <jun.li@nxp.com> > --- > drivers/usb/typec/class.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c > index b9429c9f65f6..a29bf2c32233 100644 > --- a/drivers/usb/typec/class.c > +++ b/drivers/usb/typec/class.c > @@ -8,6 +8,7 @@ > > #include <linux/module.h> > #include <linux/mutex.h> > +#include <linux/of.h> > #include <linux/property.h> > #include <linux/slab.h> > #include <linux/usb/pd_vdo.h> > @@ -2049,6 +2050,7 @@ struct typec_port *typec_register_port(struct device *parent, > port->dev.class = &typec_class; > port->dev.parent = parent; > port->dev.fwnode = cap->fwnode; > + port->dev.of_node = to_of_node(cap->fwnode); > port->dev.type = &typec_port_dev_type; > dev_set_name(&port->dev, "port%d", id); > dev_set_drvdata(&port->dev, cap->driver_data); No. I think this is what you want to do: diff --git a/drivers/mux/core.c b/drivers/mux/core.c index 1fb22388e7e07..e30e8504c1d6d 100644 --- a/drivers/mux/core.c +++ b/drivers/mux/core.c @@ -424,7 +424,7 @@ static struct mux_chip *of_find_mux_chip_by_node(struct device_node *np) */ struct mux_control *mux_control_get(struct device *dev, const char *mux_name) { - struct device_node *np = dev->of_node; + struct device_node *np = to_of_node(dev_fwnode(dev)); struct of_phandle_args args; struct mux_chip *mux_chip; unsigned int controller; thanks, -- heikki
WARNING: multiple messages have this Message-ID (diff)
From: Heikki Krogerus <heikki.krogerus@linux.intel.com> To: Li Jun <jun.li@nxp.com> Cc: robh+dt@kernel.org, shawnguo@kernel.org, gregkh@linuxfoundation.org, linux@roeck-us.net, linux-usb@vger.kernel.org, linux-imx@nxp.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/4] usb: typec: use typec cap fwnode's of_node for typec port Date: Thu, 20 May 2021 15:38:21 +0300 [thread overview] Message-ID: <YKZYPSsjSnp3tb/j@kuha.fi.intel.com> (raw) In-Reply-To: <1621408490-23811-3-git-send-email-jun.li@nxp.com> On Wed, May 19, 2021 at 03:14:48PM +0800, Li Jun wrote: > Asssign typec cap fwnode's of_node to typec port, then we can use > typec port device to get properties from its OF. > > Signed-off-by: Li Jun <jun.li@nxp.com> > --- > drivers/usb/typec/class.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c > index b9429c9f65f6..a29bf2c32233 100644 > --- a/drivers/usb/typec/class.c > +++ b/drivers/usb/typec/class.c > @@ -8,6 +8,7 @@ > > #include <linux/module.h> > #include <linux/mutex.h> > +#include <linux/of.h> > #include <linux/property.h> > #include <linux/slab.h> > #include <linux/usb/pd_vdo.h> > @@ -2049,6 +2050,7 @@ struct typec_port *typec_register_port(struct device *parent, > port->dev.class = &typec_class; > port->dev.parent = parent; > port->dev.fwnode = cap->fwnode; > + port->dev.of_node = to_of_node(cap->fwnode); > port->dev.type = &typec_port_dev_type; > dev_set_name(&port->dev, "port%d", id); > dev_set_drvdata(&port->dev, cap->driver_data); No. I think this is what you want to do: diff --git a/drivers/mux/core.c b/drivers/mux/core.c index 1fb22388e7e07..e30e8504c1d6d 100644 --- a/drivers/mux/core.c +++ b/drivers/mux/core.c @@ -424,7 +424,7 @@ static struct mux_chip *of_find_mux_chip_by_node(struct device_node *np) */ struct mux_control *mux_control_get(struct device *dev, const char *mux_name) { - struct device_node *np = dev->of_node; + struct device_node *np = to_of_node(dev_fwnode(dev)); struct of_phandle_args args; struct mux_chip *mux_chip; unsigned int controller; thanks, -- heikki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-20 12:38 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-19 7:14 [PATCH 0/4] typec switch via mux controller Li Jun 2021-05-19 7:14 ` Li Jun 2021-05-19 7:14 ` [PATCH 1/4] dt-bindings: connector: Add typec orientation switch properties Li Jun 2021-05-19 7:14 ` Li Jun 2021-05-21 1:30 ` Rob Herring 2021-05-21 1:30 ` Rob Herring 2021-05-25 11:48 ` Jun Li 2021-05-25 11:48 ` Jun Li 2021-05-19 7:14 ` [PATCH 2/4] usb: typec: use typec cap fwnode's of_node for typec port Li Jun 2021-05-19 7:14 ` Li Jun 2021-05-20 12:38 ` Heikki Krogerus [this message] 2021-05-20 12:38 ` Heikki Krogerus 2021-05-19 7:14 ` [PATCH 3/4] usb: typec: add typec orientation switch support via mux controller Li Jun 2021-05-19 7:14 ` Li Jun 2021-05-20 12:33 ` Heikki Krogerus 2021-05-20 12:33 ` Heikki Krogerus 2021-05-21 8:37 ` Heikki Krogerus 2021-05-21 8:37 ` Heikki Krogerus 2021-05-25 11:46 ` Jun Li 2021-05-25 11:46 ` Jun Li 2021-05-26 9:16 ` Heikki Krogerus 2021-05-26 9:16 ` Heikki Krogerus 2021-05-31 11:58 ` Jun Li 2021-05-31 11:58 ` Jun Li 2021-05-21 13:02 ` Jun Li 2021-05-21 13:02 ` Jun Li 2021-05-19 7:14 ` [PATCH 4/4] arm64: dts: imx8mp-evk: enable usb0 with typec connector Li Jun 2021-05-19 7:14 ` Li Jun
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YKZYPSsjSnp3tb/j@kuha.fi.intel.com \ --to=heikki.krogerus@linux.intel.com \ --cc=devicetree@vger.kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=jun.li@nxp.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-usb@vger.kernel.org \ --cc=linux@roeck-us.net \ --cc=robh+dt@kernel.org \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.