* [PATCH] video: hgafb: correctly handle card detect failure during probe
@ 2021-05-16 19:27 ` Anirudh Rayabharam
0 siblings, 0 replies; 12+ messages in thread
From: Anirudh Rayabharam @ 2021-05-16 19:27 UTC (permalink / raw)
To: Ferenc Bakonyi, Igor Matheus Andrade Torrente, Greg Kroah-Hartman
Cc: linux-kernel-mentees, Anirudh Rayabharam, kernel test robot,
stable, linux-nvidia, dri-devel, linux-fbdev, linux-kernel
The return value of hga_card_detect() is not properly handled causing
the probe to succeed even though hga_card_detect() failed. Since probe
succeeds, hgafb_open() can be called which will end up operating on an
unmapped hga_vram. This results in an out-of-bounds access as reported
by kernel test robot [1].
To fix this, correctly detect failure of hga_card_detect() by checking
for a non-zero error code.
[1]: https://lore.kernel.org/lkml/20210516150019.GB25903@xsang-OptiPlex-9020/
Reported-by: kernel test robot <oliver.sang@intel.com>
Fixes: dc13cac4862c ("video: hgafb: fix potential NULL pointer dereference")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Anirudh Rayabharam <mail@anirudhrb.com>
---
drivers/video/fbdev/hgafb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/hgafb.c b/drivers/video/fbdev/hgafb.c
index cc8e62ae93f6..bd3d07aa4f0e 100644
--- a/drivers/video/fbdev/hgafb.c
+++ b/drivers/video/fbdev/hgafb.c
@@ -558,7 +558,7 @@ static int hgafb_probe(struct platform_device *pdev)
int ret;
ret = hga_card_detect();
- if (!ret)
+ if (ret)
return ret;
printk(KERN_INFO "hgafb: %s with %ldK of memory detected.\n",
--
2.26.2
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH] video: hgafb: correctly handle card detect failure during probe
@ 2021-05-16 19:27 ` Anirudh Rayabharam
0 siblings, 0 replies; 12+ messages in thread
From: Anirudh Rayabharam @ 2021-05-16 19:27 UTC (permalink / raw)
To: Ferenc Bakonyi, Igor Matheus Andrade Torrente, Greg Kroah-Hartman
Cc: linux-fbdev, linux-kernel, dri-devel, kernel test robot, stable,
linux-nvidia, linux-kernel-mentees
The return value of hga_card_detect() is not properly handled causing
the probe to succeed even though hga_card_detect() failed. Since probe
succeeds, hgafb_open() can be called which will end up operating on an
unmapped hga_vram. This results in an out-of-bounds access as reported
by kernel test robot [1].
To fix this, correctly detect failure of hga_card_detect() by checking
for a non-zero error code.
[1]: https://lore.kernel.org/lkml/20210516150019.GB25903@xsang-OptiPlex-9020/
Reported-by: kernel test robot <oliver.sang@intel.com>
Fixes: dc13cac4862c ("video: hgafb: fix potential NULL pointer dereference")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Anirudh Rayabharam <mail@anirudhrb.com>
---
drivers/video/fbdev/hgafb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/hgafb.c b/drivers/video/fbdev/hgafb.c
index cc8e62ae93f6..bd3d07aa4f0e 100644
--- a/drivers/video/fbdev/hgafb.c
+++ b/drivers/video/fbdev/hgafb.c
@@ -558,7 +558,7 @@ static int hgafb_probe(struct platform_device *pdev)
int ret;
ret = hga_card_detect();
- if (!ret)
+ if (ret)
return ret;
printk(KERN_INFO "hgafb: %s with %ldK of memory detected.\n",
--
2.26.2
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH] video: hgafb: correctly handle card detect failure during probe
@ 2021-05-16 19:27 ` Anirudh Rayabharam
0 siblings, 0 replies; 12+ messages in thread
From: Anirudh Rayabharam @ 2021-05-16 19:27 UTC (permalink / raw)
To: Ferenc Bakonyi, Igor Matheus Andrade Torrente, Greg Kroah-Hartman
Cc: linux-fbdev, linux-kernel, dri-devel, Anirudh Rayabharam,
kernel test robot, stable, linux-nvidia, linux-kernel-mentees
The return value of hga_card_detect() is not properly handled causing
the probe to succeed even though hga_card_detect() failed. Since probe
succeeds, hgafb_open() can be called which will end up operating on an
unmapped hga_vram. This results in an out-of-bounds access as reported
by kernel test robot [1].
To fix this, correctly detect failure of hga_card_detect() by checking
for a non-zero error code.
[1]: https://lore.kernel.org/lkml/20210516150019.GB25903@xsang-OptiPlex-9020/
Reported-by: kernel test robot <oliver.sang@intel.com>
Fixes: dc13cac4862c ("video: hgafb: fix potential NULL pointer dereference")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Anirudh Rayabharam <mail@anirudhrb.com>
---
drivers/video/fbdev/hgafb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/hgafb.c b/drivers/video/fbdev/hgafb.c
index cc8e62ae93f6..bd3d07aa4f0e 100644
--- a/drivers/video/fbdev/hgafb.c
+++ b/drivers/video/fbdev/hgafb.c
@@ -558,7 +558,7 @@ static int hgafb_probe(struct platform_device *pdev)
int ret;
ret = hga_card_detect();
- if (!ret)
+ if (ret)
return ret;
printk(KERN_INFO "hgafb: %s with %ldK of memory detected.\n",
--
2.26.2
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH] video: hgafb: correctly handle card detect failure during probe
2021-05-16 19:27 ` Anirudh Rayabharam
(?)
@ 2021-05-17 12:27 ` Igor Torrente
-1 siblings, 0 replies; 12+ messages in thread
From: Igor Torrente @ 2021-05-17 12:27 UTC (permalink / raw)
To: Anirudh Rayabharam, Ferenc Bakonyi, Greg Kroah-Hartman
Cc: linux-kernel-mentees, kernel test robot, stable, linux-nvidia,
dri-devel, linux-fbdev, linux-kernel
Hi,
On 5/16/21 4:27 PM, Anirudh Rayabharam wrote:
> The return value of hga_card_detect() is not properly handled causing
> the probe to succeed even though hga_card_detect() failed. Since probe
> succeeds, hgafb_open() can be called which will end up operating on an
> unmapped hga_vram. This results in an out-of-bounds access as reported
> by kernel test robot [1].
>
> To fix this, correctly detect failure of hga_card_detect() by checking
> for a non-zero error code.
>
> [1]: https://lore.kernel.org/lkml/20210516150019.GB25903@xsang-OptiPlex-9020/
>
> Reported-by: kernel test robot <oliver.sang@intel.com>
> Fixes: dc13cac4862c ("video: hgafb: fix potential NULL pointer dereference")
> Cc: stable <stable@vger.kernel.org>
> Signed-off-by: Anirudh Rayabharam <mail@anirudhrb.com>
> ---
> drivers/video/fbdev/hgafb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/hgafb.c b/drivers/video/fbdev/hgafb.c
> index cc8e62ae93f6..bd3d07aa4f0e 100644
> --- a/drivers/video/fbdev/hgafb.c
> +++ b/drivers/video/fbdev/hgafb.c
> @@ -558,7 +558,7 @@ static int hgafb_probe(struct platform_device *pdev)
> int ret;
>
> ret = hga_card_detect();
> - if (!ret)
> + if (ret)
> return ret;
>
> printk(KERN_INFO "hgafb: %s with %ldK of memory detected.\n",
>
In fact, this return isn't being properly handled. Thanks for fix it!
Reviewed-by: Igor Matheus Andrade Torrente <igormtorrente@gmail.com>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] video: hgafb: correctly handle card detect failure during probe
@ 2021-05-17 12:27 ` Igor Torrente
0 siblings, 0 replies; 12+ messages in thread
From: Igor Torrente @ 2021-05-17 12:27 UTC (permalink / raw)
To: Anirudh Rayabharam, Ferenc Bakonyi, Greg Kroah-Hartman
Cc: linux-fbdev, linux-kernel, dri-devel, kernel test robot, stable,
linux-nvidia, linux-kernel-mentees
Hi,
On 5/16/21 4:27 PM, Anirudh Rayabharam wrote:
> The return value of hga_card_detect() is not properly handled causing
> the probe to succeed even though hga_card_detect() failed. Since probe
> succeeds, hgafb_open() can be called which will end up operating on an
> unmapped hga_vram. This results in an out-of-bounds access as reported
> by kernel test robot [1].
>
> To fix this, correctly detect failure of hga_card_detect() by checking
> for a non-zero error code.
>
> [1]: https://lore.kernel.org/lkml/20210516150019.GB25903@xsang-OptiPlex-9020/
>
> Reported-by: kernel test robot <oliver.sang@intel.com>
> Fixes: dc13cac4862c ("video: hgafb: fix potential NULL pointer dereference")
> Cc: stable <stable@vger.kernel.org>
> Signed-off-by: Anirudh Rayabharam <mail@anirudhrb.com>
> ---
> drivers/video/fbdev/hgafb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/hgafb.c b/drivers/video/fbdev/hgafb.c
> index cc8e62ae93f6..bd3d07aa4f0e 100644
> --- a/drivers/video/fbdev/hgafb.c
> +++ b/drivers/video/fbdev/hgafb.c
> @@ -558,7 +558,7 @@ static int hgafb_probe(struct platform_device *pdev)
> int ret;
>
> ret = hga_card_detect();
> - if (!ret)
> + if (ret)
> return ret;
>
> printk(KERN_INFO "hgafb: %s with %ldK of memory detected.\n",
>
In fact, this return isn't being properly handled. Thanks for fix it!
Reviewed-by: Igor Matheus Andrade Torrente <igormtorrente@gmail.com>
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] video: hgafb: correctly handle card detect failure during probe
@ 2021-05-17 12:27 ` Igor Torrente
0 siblings, 0 replies; 12+ messages in thread
From: Igor Torrente @ 2021-05-17 12:27 UTC (permalink / raw)
To: Anirudh Rayabharam, Ferenc Bakonyi, Greg Kroah-Hartman
Cc: linux-fbdev, linux-kernel, dri-devel, kernel test robot, stable,
linux-nvidia, linux-kernel-mentees
Hi,
On 5/16/21 4:27 PM, Anirudh Rayabharam wrote:
> The return value of hga_card_detect() is not properly handled causing
> the probe to succeed even though hga_card_detect() failed. Since probe
> succeeds, hgafb_open() can be called which will end up operating on an
> unmapped hga_vram. This results in an out-of-bounds access as reported
> by kernel test robot [1].
>
> To fix this, correctly detect failure of hga_card_detect() by checking
> for a non-zero error code.
>
> [1]: https://lore.kernel.org/lkml/20210516150019.GB25903@xsang-OptiPlex-9020/
>
> Reported-by: kernel test robot <oliver.sang@intel.com>
> Fixes: dc13cac4862c ("video: hgafb: fix potential NULL pointer dereference")
> Cc: stable <stable@vger.kernel.org>
> Signed-off-by: Anirudh Rayabharam <mail@anirudhrb.com>
> ---
> drivers/video/fbdev/hgafb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/hgafb.c b/drivers/video/fbdev/hgafb.c
> index cc8e62ae93f6..bd3d07aa4f0e 100644
> --- a/drivers/video/fbdev/hgafb.c
> +++ b/drivers/video/fbdev/hgafb.c
> @@ -558,7 +558,7 @@ static int hgafb_probe(struct platform_device *pdev)
> int ret;
>
> ret = hga_card_detect();
> - if (!ret)
> + if (ret)
> return ret;
>
> printk(KERN_INFO "hgafb: %s with %ldK of memory detected.\n",
>
In fact, this return isn't being properly handled. Thanks for fix it!
Reviewed-by: Igor Matheus Andrade Torrente <igormtorrente@gmail.com>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] video: hgafb: correctly handle card detect failure during probe
2021-05-16 19:27 ` Anirudh Rayabharam
(?)
@ 2021-05-20 13:40 ` Anirudh Rayabharam
-1 siblings, 0 replies; 12+ messages in thread
From: Anirudh Rayabharam @ 2021-05-20 13:40 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: linux-kernel-mentees, kernel test robot, stable, linux-nvidia,
dri-devel, linux-fbdev, linux-kernel, mail, igormtorrente, fero
On Mon, May 17, 2021 at 12:57:14AM +0530, Anirudh Rayabharam wrote:
> The return value of hga_card_detect() is not properly handled causing
> the probe to succeed even though hga_card_detect() failed. Since probe
> succeeds, hgafb_open() can be called which will end up operating on an
> unmapped hga_vram. This results in an out-of-bounds access as reported
> by kernel test robot [1].
>
> To fix this, correctly detect failure of hga_card_detect() by checking
> for a non-zero error code.
>
> [1]: https://lore.kernel.org/lkml/20210516150019.GB25903@xsang-OptiPlex-9020/
>
> Reported-by: kernel test robot <oliver.sang@intel.com>
> Fixes: dc13cac4862c ("video: hgafb: fix potential NULL pointer dereference")
Greg, this is one of the UMN fixes we did. So, do you want to take this
patch into your tree?
thanks!
- Anirudh.
> Cc: stable <stable@vger.kernel.org>
> Signed-off-by: Anirudh Rayabharam <mail@anirudhrb.com>
> ---
> drivers/video/fbdev/hgafb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/hgafb.c b/drivers/video/fbdev/hgafb.c
> index cc8e62ae93f6..bd3d07aa4f0e 100644
> --- a/drivers/video/fbdev/hgafb.c
> +++ b/drivers/video/fbdev/hgafb.c
> @@ -558,7 +558,7 @@ static int hgafb_probe(struct platform_device *pdev)
> int ret;
>
> ret = hga_card_detect();
> - if (!ret)
> + if (ret)
> return ret;
>
> printk(KERN_INFO "hgafb: %s with %ldK of memory detected.\n",
> --
> 2.26.2
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] video: hgafb: correctly handle card detect failure during probe
@ 2021-05-20 13:40 ` Anirudh Rayabharam
0 siblings, 0 replies; 12+ messages in thread
From: Anirudh Rayabharam @ 2021-05-20 13:40 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: linux-fbdev, linux-kernel, dri-devel, fero, kernel test robot,
stable, linux-nvidia, linux-kernel-mentees, igormtorrente
On Mon, May 17, 2021 at 12:57:14AM +0530, Anirudh Rayabharam wrote:
> The return value of hga_card_detect() is not properly handled causing
> the probe to succeed even though hga_card_detect() failed. Since probe
> succeeds, hgafb_open() can be called which will end up operating on an
> unmapped hga_vram. This results in an out-of-bounds access as reported
> by kernel test robot [1].
>
> To fix this, correctly detect failure of hga_card_detect() by checking
> for a non-zero error code.
>
> [1]: https://lore.kernel.org/lkml/20210516150019.GB25903@xsang-OptiPlex-9020/
>
> Reported-by: kernel test robot <oliver.sang@intel.com>
> Fixes: dc13cac4862c ("video: hgafb: fix potential NULL pointer dereference")
Greg, this is one of the UMN fixes we did. So, do you want to take this
patch into your tree?
thanks!
- Anirudh.
> Cc: stable <stable@vger.kernel.org>
> Signed-off-by: Anirudh Rayabharam <mail@anirudhrb.com>
> ---
> drivers/video/fbdev/hgafb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/hgafb.c b/drivers/video/fbdev/hgafb.c
> index cc8e62ae93f6..bd3d07aa4f0e 100644
> --- a/drivers/video/fbdev/hgafb.c
> +++ b/drivers/video/fbdev/hgafb.c
> @@ -558,7 +558,7 @@ static int hgafb_probe(struct platform_device *pdev)
> int ret;
>
> ret = hga_card_detect();
> - if (!ret)
> + if (ret)
> return ret;
>
> printk(KERN_INFO "hgafb: %s with %ldK of memory detected.\n",
> --
> 2.26.2
>
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] video: hgafb: correctly handle card detect failure during probe
@ 2021-05-20 13:40 ` Anirudh Rayabharam
0 siblings, 0 replies; 12+ messages in thread
From: Anirudh Rayabharam @ 2021-05-20 13:40 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: linux-fbdev, linux-kernel, dri-devel, fero, mail,
kernel test robot, stable, linux-nvidia, linux-kernel-mentees,
igormtorrente
On Mon, May 17, 2021 at 12:57:14AM +0530, Anirudh Rayabharam wrote:
> The return value of hga_card_detect() is not properly handled causing
> the probe to succeed even though hga_card_detect() failed. Since probe
> succeeds, hgafb_open() can be called which will end up operating on an
> unmapped hga_vram. This results in an out-of-bounds access as reported
> by kernel test robot [1].
>
> To fix this, correctly detect failure of hga_card_detect() by checking
> for a non-zero error code.
>
> [1]: https://lore.kernel.org/lkml/20210516150019.GB25903@xsang-OptiPlex-9020/
>
> Reported-by: kernel test robot <oliver.sang@intel.com>
> Fixes: dc13cac4862c ("video: hgafb: fix potential NULL pointer dereference")
Greg, this is one of the UMN fixes we did. So, do you want to take this
patch into your tree?
thanks!
- Anirudh.
> Cc: stable <stable@vger.kernel.org>
> Signed-off-by: Anirudh Rayabharam <mail@anirudhrb.com>
> ---
> drivers/video/fbdev/hgafb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/hgafb.c b/drivers/video/fbdev/hgafb.c
> index cc8e62ae93f6..bd3d07aa4f0e 100644
> --- a/drivers/video/fbdev/hgafb.c
> +++ b/drivers/video/fbdev/hgafb.c
> @@ -558,7 +558,7 @@ static int hgafb_probe(struct platform_device *pdev)
> int ret;
>
> ret = hga_card_detect();
> - if (!ret)
> + if (ret)
> return ret;
>
> printk(KERN_INFO "hgafb: %s with %ldK of memory detected.\n",
> --
> 2.26.2
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] video: hgafb: correctly handle card detect failure during probe
2021-05-20 13:40 ` Anirudh Rayabharam
(?)
@ 2021-05-20 13:58 ` Greg Kroah-Hartman
-1 siblings, 0 replies; 12+ messages in thread
From: Greg Kroah-Hartman @ 2021-05-20 13:58 UTC (permalink / raw)
To: Anirudh Rayabharam
Cc: linux-kernel-mentees, kernel test robot, stable, linux-nvidia,
dri-devel, linux-fbdev, linux-kernel, igormtorrente, fero
On Thu, May 20, 2021 at 07:10:39PM +0530, Anirudh Rayabharam wrote:
> On Mon, May 17, 2021 at 12:57:14AM +0530, Anirudh Rayabharam wrote:
> > The return value of hga_card_detect() is not properly handled causing
> > the probe to succeed even though hga_card_detect() failed. Since probe
> > succeeds, hgafb_open() can be called which will end up operating on an
> > unmapped hga_vram. This results in an out-of-bounds access as reported
> > by kernel test robot [1].
> >
> > To fix this, correctly detect failure of hga_card_detect() by checking
> > for a non-zero error code.
> >
> > [1]: https://lore.kernel.org/lkml/20210516150019.GB25903@xsang-OptiPlex-9020/
> >
> > Reported-by: kernel test robot <oliver.sang@intel.com>
> > Fixes: dc13cac4862c ("video: hgafb: fix potential NULL pointer dereference")
>
> Greg, this is one of the UMN fixes we did. So, do you want to take this
> patch into your tree?
Yes, will queue it up in a few days after Linus takes the current pull
request I sent him for this.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] video: hgafb: correctly handle card detect failure during probe
@ 2021-05-20 13:58 ` Greg Kroah-Hartman
0 siblings, 0 replies; 12+ messages in thread
From: Greg Kroah-Hartman @ 2021-05-20 13:58 UTC (permalink / raw)
To: Anirudh Rayabharam
Cc: linux-fbdev, linux-kernel, dri-devel, fero, kernel test robot,
stable, linux-nvidia, linux-kernel-mentees, igormtorrente
On Thu, May 20, 2021 at 07:10:39PM +0530, Anirudh Rayabharam wrote:
> On Mon, May 17, 2021 at 12:57:14AM +0530, Anirudh Rayabharam wrote:
> > The return value of hga_card_detect() is not properly handled causing
> > the probe to succeed even though hga_card_detect() failed. Since probe
> > succeeds, hgafb_open() can be called which will end up operating on an
> > unmapped hga_vram. This results in an out-of-bounds access as reported
> > by kernel test robot [1].
> >
> > To fix this, correctly detect failure of hga_card_detect() by checking
> > for a non-zero error code.
> >
> > [1]: https://lore.kernel.org/lkml/20210516150019.GB25903@xsang-OptiPlex-9020/
> >
> > Reported-by: kernel test robot <oliver.sang@intel.com>
> > Fixes: dc13cac4862c ("video: hgafb: fix potential NULL pointer dereference")
>
> Greg, this is one of the UMN fixes we did. So, do you want to take this
> patch into your tree?
Yes, will queue it up in a few days after Linus takes the current pull
request I sent him for this.
thanks,
greg k-h
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] video: hgafb: correctly handle card detect failure during probe
@ 2021-05-20 13:58 ` Greg Kroah-Hartman
0 siblings, 0 replies; 12+ messages in thread
From: Greg Kroah-Hartman @ 2021-05-20 13:58 UTC (permalink / raw)
To: Anirudh Rayabharam
Cc: linux-fbdev, linux-kernel, dri-devel, fero, kernel test robot,
stable, linux-nvidia, linux-kernel-mentees, igormtorrente
On Thu, May 20, 2021 at 07:10:39PM +0530, Anirudh Rayabharam wrote:
> On Mon, May 17, 2021 at 12:57:14AM +0530, Anirudh Rayabharam wrote:
> > The return value of hga_card_detect() is not properly handled causing
> > the probe to succeed even though hga_card_detect() failed. Since probe
> > succeeds, hgafb_open() can be called which will end up operating on an
> > unmapped hga_vram. This results in an out-of-bounds access as reported
> > by kernel test robot [1].
> >
> > To fix this, correctly detect failure of hga_card_detect() by checking
> > for a non-zero error code.
> >
> > [1]: https://lore.kernel.org/lkml/20210516150019.GB25903@xsang-OptiPlex-9020/
> >
> > Reported-by: kernel test robot <oliver.sang@intel.com>
> > Fixes: dc13cac4862c ("video: hgafb: fix potential NULL pointer dereference")
>
> Greg, this is one of the UMN fixes we did. So, do you want to take this
> patch into your tree?
Yes, will queue it up in a few days after Linus takes the current pull
request I sent him for this.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2021-05-21 6:56 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-16 19:27 [PATCH] video: hgafb: correctly handle card detect failure during probe Anirudh Rayabharam
2021-05-16 19:27 ` Anirudh Rayabharam
2021-05-16 19:27 ` Anirudh Rayabharam
2021-05-17 12:27 ` Igor Torrente
2021-05-17 12:27 ` Igor Torrente
2021-05-17 12:27 ` Igor Torrente
2021-05-20 13:40 ` Anirudh Rayabharam
2021-05-20 13:40 ` Anirudh Rayabharam
2021-05-20 13:40 ` Anirudh Rayabharam
2021-05-20 13:58 ` Greg Kroah-Hartman
2021-05-20 13:58 ` Greg Kroah-Hartman
2021-05-20 13:58 ` Greg Kroah-Hartman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.