From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: "Rob Herring" <robh+dt@kernel.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <bgolaszewski@baylibre.com>,
"Benoît Cousson" <bcousson@baylibre.com>,
"Tony Lindgren" <tony@atomide.com>,
"Jan Tuerk" <jan.tuerk@emtrion.com>,
"Shawn Guo" <shawnguo@kernel.org>,
devicetree@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] ARM: dts: imx: emcon-avari: Fix nxp,pca8574 #gpio-cells
Date: Sun, 23 May 2021 04:55:10 +0300 [thread overview]
Message-ID: <YKm1/hFtNmS6rPiu@pendragon.ideasonboard.com> (raw)
In-Reply-To: <6cd916fc8c0a133cd216eee06cac86716b66eff4.1621583562.git.geert+renesas@glider.be>
Hi Geert,
Thank you for the patch.
On Fri, May 21, 2021 at 09:54:07AM +0200, Geert Uytterhoeven wrote:
> According to the DT bindings, #gpio-cells must be two.
>
> Fixes: 63e71fedc07c4ece ("ARM: dts: Add support for emtrion emCON-MX6 series")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> arch/arm/boot/dts/imx6qdl-emcon-avari.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-emcon-avari.dtsi b/arch/arm/boot/dts/imx6qdl-emcon-avari.dtsi
> index 828cf3e39784afd6..c4e146f3341bb85d 100644
> --- a/arch/arm/boot/dts/imx6qdl-emcon-avari.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-emcon-avari.dtsi
> @@ -126,7 +126,7 @@ boardid: gpio@3a {
> compatible = "nxp,pca8574";
> reg = <0x3a>;
> gpio-controller;
> - #gpio-cells = <1>;
> + #gpio-cells = <2>;
> };
> };
>
--
Regards,
Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: "Rob Herring" <robh+dt@kernel.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <bgolaszewski@baylibre.com>,
"Benoît Cousson" <bcousson@baylibre.com>,
"Tony Lindgren" <tony@atomide.com>,
"Jan Tuerk" <jan.tuerk@emtrion.com>,
"Shawn Guo" <shawnguo@kernel.org>,
devicetree@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] ARM: dts: imx: emcon-avari: Fix nxp,pca8574 #gpio-cells
Date: Sun, 23 May 2021 04:55:10 +0300 [thread overview]
Message-ID: <YKm1/hFtNmS6rPiu@pendragon.ideasonboard.com> (raw)
In-Reply-To: <6cd916fc8c0a133cd216eee06cac86716b66eff4.1621583562.git.geert+renesas@glider.be>
Hi Geert,
Thank you for the patch.
On Fri, May 21, 2021 at 09:54:07AM +0200, Geert Uytterhoeven wrote:
> According to the DT bindings, #gpio-cells must be two.
>
> Fixes: 63e71fedc07c4ece ("ARM: dts: Add support for emtrion emCON-MX6 series")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> arch/arm/boot/dts/imx6qdl-emcon-avari.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-emcon-avari.dtsi b/arch/arm/boot/dts/imx6qdl-emcon-avari.dtsi
> index 828cf3e39784afd6..c4e146f3341bb85d 100644
> --- a/arch/arm/boot/dts/imx6qdl-emcon-avari.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-emcon-avari.dtsi
> @@ -126,7 +126,7 @@ boardid: gpio@3a {
> compatible = "nxp,pca8574";
> reg = <0x3a>;
> gpio-controller;
> - #gpio-cells = <1>;
> + #gpio-cells = <2>;
> };
> };
>
--
Regards,
Laurent Pinchart
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-23 1:55 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-21 7:54 [PATCH 0/3] pcf857x: DTS fixes and DT binding to json-schema conversion Geert Uytterhoeven
2021-05-21 7:54 ` Geert Uytterhoeven
2021-05-21 7:54 ` [PATCH 1/3] ARM: dts: dra7x-evm: Align GPIO hog names with dt-schema Geert Uytterhoeven
2021-05-21 7:54 ` Geert Uytterhoeven
2021-05-23 1:54 ` Laurent Pinchart
2021-05-23 1:54 ` Laurent Pinchart
2021-05-27 12:02 ` Tony Lindgren
2021-05-27 12:02 ` Tony Lindgren
2021-05-21 7:54 ` [PATCH 2/3] ARM: dts: imx: emcon-avari: Fix nxp,pca8574 #gpio-cells Geert Uytterhoeven
2021-05-21 7:54 ` Geert Uytterhoeven
2021-05-23 1:55 ` Laurent Pinchart [this message]
2021-05-23 1:55 ` Laurent Pinchart
2021-05-23 5:42 ` Shawn Guo
2021-05-23 5:42 ` Shawn Guo
2021-05-21 7:54 ` [PATCH 3/3] dt-bindings: gpio: pcf857x: Convert to json-schema Geert Uytterhoeven
2021-05-21 7:54 ` Geert Uytterhoeven
2021-05-21 10:04 ` Linus Walleij
2021-05-21 10:04 ` Linus Walleij
2021-05-21 10:23 ` Geert Uytterhoeven
2021-05-21 10:23 ` Geert Uytterhoeven
2021-05-21 18:24 ` Rob Herring
2021-05-21 18:24 ` Rob Herring
2021-05-27 15:04 ` Geert Uytterhoeven
2021-05-27 15:04 ` Geert Uytterhoeven
2021-05-23 1:52 ` Laurent Pinchart
2021-05-23 1:52 ` Laurent Pinchart
2021-05-27 14:43 ` Geert Uytterhoeven
2021-05-27 14:43 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKm1/hFtNmS6rPiu@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=bcousson@baylibre.com \
--cc=bgolaszewski@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=jan.tuerk@emtrion.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.