All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Damien Le Moal <damien.lemoal@wdc.com>
Cc: dm-devel@redhat.com, Mike Snitzer <snitzer@redhat.com>,
	linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH v4 02/11] block: introduce bio zone helpers
Date: Tue, 25 May 2021 09:08:40 +0100	[thread overview]
Message-ID: <YKywiKQX1nFFF4/8@infradead.org> (raw)
In-Reply-To: <20210525022539.119661-3-damien.lemoal@wdc.com>

On Tue, May 25, 2021 at 11:25:30AM +0900, Damien Le Moal wrote:
> Introduce the helper functions bio_zone_no() and bio_zone_is_seq().
> Both are the BIO counterparts of the request helpers blk_rq_zone_no()
> and blk_rq_zone_is_seq(), respectively returning the number of the
> target zone of a bio and true if the BIO target zone is sequential.

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Damien Le Moal <damien.lemoal@wdc.com>
Cc: linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
	dm-devel@redhat.com, Mike Snitzer <snitzer@redhat.com>
Subject: Re: [dm-devel] [PATCH v4 02/11] block: introduce bio zone helpers
Date: Tue, 25 May 2021 09:08:40 +0100	[thread overview]
Message-ID: <YKywiKQX1nFFF4/8@infradead.org> (raw)
In-Reply-To: <20210525022539.119661-3-damien.lemoal@wdc.com>

On Tue, May 25, 2021 at 11:25:30AM +0900, Damien Le Moal wrote:
> Introduce the helper functions bio_zone_no() and bio_zone_is_seq().
> Both are the BIO counterparts of the request helpers blk_rq_zone_no()
> and blk_rq_zone_is_seq(), respectively returning the number of the
> target zone of a bio and true if the BIO target zone is sequential.

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel


  reply	other threads:[~2021-05-25  8:12 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-25  2:25 [PATCH v4 00/11] dm: Improve zoned block device support Damien Le Moal
2021-05-25  2:25 ` [dm-devel] " Damien Le Moal
2021-05-25  2:25 ` [PATCH v4 01/11] block: improve handling of all zones reset operation Damien Le Moal
2021-05-25  2:25   ` [dm-devel] " Damien Le Moal
2021-05-25  6:15   ` Chaitanya Kulkarni
2021-05-25  6:15     ` [dm-devel] " Chaitanya Kulkarni
2021-05-25  6:15   ` Chaitanya Kulkarni
2021-05-25  6:15     ` [dm-devel] " Chaitanya Kulkarni
2021-05-25  6:35     ` Damien Le Moal
2021-05-25  6:35       ` [dm-devel] " Damien Le Moal
2021-05-25 19:09   ` Himanshu Madhani
2021-05-25 19:09     ` [dm-devel] " Himanshu Madhani
2021-05-25  2:25 ` [PATCH v4 02/11] block: introduce bio zone helpers Damien Le Moal
2021-05-25  2:25   ` [dm-devel] " Damien Le Moal
2021-05-25  8:08   ` Christoph Hellwig [this message]
2021-05-25  8:08     ` Christoph Hellwig
2021-05-25 19:09   ` Himanshu Madhani
2021-05-25 19:09     ` [dm-devel] " Himanshu Madhani
2021-05-25  2:25 ` [PATCH v4 03/11] block: introduce BIO_ZONE_WRITE_LOCKED bio flag Damien Le Moal
2021-05-25  2:25   ` [dm-devel] " Damien Le Moal
2021-05-25 19:09   ` Himanshu Madhani
2021-05-25 19:09     ` [dm-devel] " Himanshu Madhani
2021-05-25  2:25 ` [PATCH v4 04/11] dm: Fix dm_accept_partial_bio() Damien Le Moal
2021-05-25  2:25   ` [dm-devel] " Damien Le Moal
2021-05-25  8:12   ` Christoph Hellwig
2021-05-25  8:12     ` [dm-devel] " Christoph Hellwig
2021-05-25 19:10   ` Himanshu Madhani
2021-05-25 19:10     ` [dm-devel] " Himanshu Madhani
2021-05-25  2:25 ` [PATCH v4 05/11] dm: cleanup device_area_is_invalid() Damien Le Moal
2021-05-25  2:25   ` [dm-devel] " Damien Le Moal
2021-05-25  8:13   ` Christoph Hellwig
2021-05-25  8:13     ` [dm-devel] " Christoph Hellwig
2021-05-25 19:10   ` Himanshu Madhani
2021-05-25 19:10     ` [dm-devel] " Himanshu Madhani
2021-05-25  2:25 ` [PATCH v4 06/11] dm: move zone related code to dm-zone.c Damien Le Moal
2021-05-25  2:25   ` [dm-devel] " Damien Le Moal
2021-05-25 19:10   ` Himanshu Madhani
2021-05-25 19:10     ` [dm-devel] " Himanshu Madhani
2021-05-25  2:25 ` [PATCH v4 07/11] dm: Introduce dm_report_zones() Damien Le Moal
2021-05-25  2:25   ` [dm-devel] " Damien Le Moal
2021-05-25 19:11   ` Himanshu Madhani
2021-05-25 19:11     ` [dm-devel] " Himanshu Madhani
2021-05-25  2:25 ` [PATCH v4 08/11] dm: Forbid requeue of writes to zones Damien Le Moal
2021-05-25  2:25   ` [dm-devel] " Damien Le Moal
2021-05-25 19:13   ` Himanshu Madhani
2021-05-25 19:13     ` [dm-devel] " Himanshu Madhani
2021-05-25  2:25 ` [PATCH v4 09/11] dm: rearrange core declarations Damien Le Moal
2021-05-25  2:25   ` [dm-devel] " Damien Le Moal
2021-05-25 19:17   ` Himanshu Madhani
2021-05-25 19:17     ` [dm-devel] " Himanshu Madhani
2021-05-25  2:25 ` [PATCH v4 10/11] dm: introduce zone append emulation Damien Le Moal
2021-05-25  2:25   ` [dm-devel] " Damien Le Moal
2021-05-25 19:40   ` Himanshu Madhani
2021-05-25 19:40     ` [dm-devel] " Himanshu Madhani
2021-05-25  2:25 ` [PATCH v4 11/11] dm crypt: Fix zoned block device support Damien Le Moal
2021-05-25  2:25   ` [dm-devel] " Damien Le Moal
2021-05-25 19:44   ` Himanshu Madhani
2021-05-25 19:44     ` [dm-devel] " Himanshu Madhani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YKywiKQX1nFFF4/8@infradead.org \
    --to=hch@infradead.org \
    --cc=axboe@kernel.dk \
    --cc=damien.lemoal@wdc.com \
    --cc=dm-devel@redhat.com \
    --cc=linux-block@vger.kernel.org \
    --cc=snitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.