* [PATCH] events: core: make perf_pmu_snapshot_aux static
@ 2021-06-08 16:22 Pavel Skripkin
2021-06-08 17:20 ` Peter Zijlstra
0 siblings, 1 reply; 3+ messages in thread
From: Pavel Skripkin @ 2021-06-08 16:22 UTC (permalink / raw)
To: peterz, mingo, acme; +Cc: linux-perf-users, linux-kernel, Pavel Skripkin
Sparse says:
warning: symbol 'perf_pmu_snapshot_aux' was not declared. Should it be static?
Since perf_pmu_snapshot_aux() is not used outside this file,
it can be made static
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
---
kernel/events/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/events/core.c b/kernel/events/core.c
index 6fee4a7e88d7..0d98d6a6f949 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -6667,7 +6667,7 @@ static unsigned long perf_prepare_sample_aux(struct perf_event *event,
return data->aux_size;
}
-long perf_pmu_snapshot_aux(struct perf_buffer *rb,
+static long perf_pmu_snapshot_aux(struct perf_buffer *rb,
struct perf_event *event,
struct perf_output_handle *handle,
unsigned long size)
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] events: core: make perf_pmu_snapshot_aux static
2021-06-08 16:22 [PATCH] events: core: make perf_pmu_snapshot_aux static Pavel Skripkin
@ 2021-06-08 17:20 ` Peter Zijlstra
2021-06-09 9:37 ` [PATCH v2] perf: events: " Pavel Skripkin
0 siblings, 1 reply; 3+ messages in thread
From: Peter Zijlstra @ 2021-06-08 17:20 UTC (permalink / raw)
To: Pavel Skripkin; +Cc: mingo, acme, linux-perf-users, linux-kernel
On Tue, Jun 08, 2021 at 07:22:53PM +0300, Pavel Skripkin wrote:
> Sparse says:
> warning: symbol 'perf_pmu_snapshot_aux' was not declared. Should it be static?
>
> Since perf_pmu_snapshot_aux() is not used outside this file,
> it can be made static
>
> Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
> ---
> kernel/events/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/events/core.c b/kernel/events/core.c
> index 6fee4a7e88d7..0d98d6a6f949 100644
> --- a/kernel/events/core.c
> +++ b/kernel/events/core.c
> @@ -6667,7 +6667,7 @@ static unsigned long perf_prepare_sample_aux(struct perf_event *event,
> return data->aux_size;
> }
>
> -long perf_pmu_snapshot_aux(struct perf_buffer *rb,
> +static long perf_pmu_snapshot_aux(struct perf_buffer *rb,
> struct perf_event *event,
> struct perf_output_handle *handle,
> unsigned long size)
You've just ruined the alignment of the arguments, also you subject has
the wrong prefix, see to git log for suggestions.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2] perf: events: make perf_pmu_snapshot_aux static
2021-06-08 17:20 ` Peter Zijlstra
@ 2021-06-09 9:37 ` Pavel Skripkin
0 siblings, 0 replies; 3+ messages in thread
From: Pavel Skripkin @ 2021-06-09 9:37 UTC (permalink / raw)
To: peterz, mingo, acme; +Cc: linux-perf-users, linux-kernel, Pavel Skripkin
Sparse says:
warning: symbol 'perf_pmu_snapshot_aux' was not declared. Should it be static?
Since perf_pmu_snapshot_aux() is not used outside this file,
it can be made static
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
---
Changes in v2:
Changed subject line
Fixed alignment of the arguments
---
kernel/events/core.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/kernel/events/core.c b/kernel/events/core.c
index 6fee4a7e88d7..9ad01ff5692b 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -6667,10 +6667,10 @@ static unsigned long perf_prepare_sample_aux(struct perf_event *event,
return data->aux_size;
}
-long perf_pmu_snapshot_aux(struct perf_buffer *rb,
- struct perf_event *event,
- struct perf_output_handle *handle,
- unsigned long size)
+static long perf_pmu_snapshot_aux(struct perf_buffer *rb,
+ struct perf_event *event,
+ struct perf_output_handle *handle,
+ unsigned long size)
{
unsigned long flags;
long ret;
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-09 9:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-08 16:22 [PATCH] events: core: make perf_pmu_snapshot_aux static Pavel Skripkin
2021-06-08 17:20 ` Peter Zijlstra
2021-06-09 9:37 ` [PATCH v2] perf: events: " Pavel Skripkin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.