From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Dave Young <dyoung@redhat.com>
Cc: "Jean Delvare" <jdelvare@suse.com>,
linux-kernel@vger.kernel.org,
"Mika Westerberg" <mika.westerberg@linux.intel.com>,
"Javier Tiá" <javier.tia@gmail.com>,
kexec@lists.infradead.org,
"Eric Biederman" <ebiederm@xmission.com>,
linux-efi <linux-efi@vger.kernel.org>,
"Matt Fleming" <matt@codeblueprint.co.uk>,
"Ard Biesheuvel" <ardb@kernel.org>
Subject: Re: [PATCH v1 0/2] firmware: dmi_scan: Make it work in kexec'ed kernel
Date: Mon, 7 Jun 2021 20:18:55 +0300 [thread overview]
Message-ID: <YL5U/zSb50SnbLgW@smile.fi.intel.com> (raw)
In-Reply-To: <YL5HvUqtsDXx5CzM@smile.fi.intel.com>
On Mon, Jun 07, 2021 at 07:22:21PM +0300, Andy Shevchenko wrote:
> On Sat, Jun 05, 2021 at 03:51:05PM +0800, Dave Young wrote:
> > On 06/02/21 at 11:53am, Andy Shevchenko wrote:
> > > On Wed, Jun 02, 2021 at 11:42:14AM +0300, Andy Shevchenko wrote:
> > > > On Fri, Dec 02, 2016 at 09:54:14PM +0200, Andy Shevchenko wrote:
> > > > > Until now DMI information is lost when kexec'ing. Fix this in the same way as
> > > > > it has been done for ACPI RSDP.
> > > > >
> > > > > Series has been tested on Galileo Gen2 where DMI is used by drivers, in
> > > > > particular the default I2C host speed is choosen based on DMI system
> > > > > information and now gets it correct.
> > > >
> > > > Still nothing happens for a while and problem still exists.
> > > > Can we do something about it, please?
> >
> > Seems I totally missed this thread. Old emails lost.
>
> You can always access to it via lore :-)
> https://lore.kernel.org/linux-efi/20161217105721.GB6922@dhcp-128-65.nay.redhat.com/T/#u
>
> (Okay, it's not full, but contains main parts anyway)
>
>
> > The question Ard asked is to confirm if the firmware converted the
> > SMBIOS3 addr to a virtual address after exit boot service. I do not
> > remember some easy way to check it due to lost the context of the code.
> > But you can try to check it via dmesg|grep SMBIOS both in normal boot
> > and kexeced boot log. And then compare if those addresses are
> > identical.
> >
> > If the SMBIOS3 addr in kexec kernel is different then it should have
> > been modified by firmware. Then we need patch kernel and kexec-tools to
> > support it.
> >
> > You can try below patch to see if it works:
>
> So, AFAIU I have to apply patch to kexec tools for the fist kernel + userspace
> and apply kernel patch for the second kernel? Or it's all for the first one?
>
> > apply a kexec-tools patch to kexec-tools if you do not use kexec -s
> > (kexec_file_load):
>
> Here is how we are using it:
> https://github.com/andy-shev/buildroot/blob/intel/board/intel/common/netboot/udhcpc-script.sh#L54
Okay, thanks for the patches. I have applied them to both kernels, so the first
one and second one are the same and kexec tools have a patch provided in the
user space of the both kernels (only first one in use though).
Before applying your patch, I have reverted my hacks (as per this series).
Result is:
# uname -a
Linux buildroot 5.13.0-rc5+ #1 SMP Mon Jun 7 19:49:40 EEST 2021 i586 GNU/Linux
# dmidecode
# dmidecode 3.3
Scanning /dev/mem for entry point.
# No SMBIOS nor DMI entry point found, sorry.
I.o.w. it does NOT fix the issue. My patches do (with a hint from user space).
--
With Best Regards,
Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Dave Young <dyoung@redhat.com>
Cc: "Jean Delvare" <jdelvare@suse.com>,
linux-kernel@vger.kernel.org,
"Mika Westerberg" <mika.westerberg@linux.intel.com>,
"Javier Tiá" <javier.tia@gmail.com>,
kexec@lists.infradead.org,
"Eric Biederman" <ebiederm@xmission.com>,
linux-efi <linux-efi@vger.kernel.org>,
"Matt Fleming" <matt@codeblueprint.co.uk>,
"Ard Biesheuvel" <ardb@kernel.org>
Subject: Re: [PATCH v1 0/2] firmware: dmi_scan: Make it work in kexec'ed kernel
Date: Mon, 7 Jun 2021 20:18:55 +0300 [thread overview]
Message-ID: <YL5U/zSb50SnbLgW@smile.fi.intel.com> (raw)
In-Reply-To: <YL5HvUqtsDXx5CzM@smile.fi.intel.com>
On Mon, Jun 07, 2021 at 07:22:21PM +0300, Andy Shevchenko wrote:
> On Sat, Jun 05, 2021 at 03:51:05PM +0800, Dave Young wrote:
> > On 06/02/21 at 11:53am, Andy Shevchenko wrote:
> > > On Wed, Jun 02, 2021 at 11:42:14AM +0300, Andy Shevchenko wrote:
> > > > On Fri, Dec 02, 2016 at 09:54:14PM +0200, Andy Shevchenko wrote:
> > > > > Until now DMI information is lost when kexec'ing. Fix this in the same way as
> > > > > it has been done for ACPI RSDP.
> > > > >
> > > > > Series has been tested on Galileo Gen2 where DMI is used by drivers, in
> > > > > particular the default I2C host speed is choosen based on DMI system
> > > > > information and now gets it correct.
> > > >
> > > > Still nothing happens for a while and problem still exists.
> > > > Can we do something about it, please?
> >
> > Seems I totally missed this thread. Old emails lost.
>
> You can always access to it via lore :-)
> https://lore.kernel.org/linux-efi/20161217105721.GB6922@dhcp-128-65.nay.redhat.com/T/#u
>
> (Okay, it's not full, but contains main parts anyway)
>
>
> > The question Ard asked is to confirm if the firmware converted the
> > SMBIOS3 addr to a virtual address after exit boot service. I do not
> > remember some easy way to check it due to lost the context of the code.
> > But you can try to check it via dmesg|grep SMBIOS both in normal boot
> > and kexeced boot log. And then compare if those addresses are
> > identical.
> >
> > If the SMBIOS3 addr in kexec kernel is different then it should have
> > been modified by firmware. Then we need patch kernel and kexec-tools to
> > support it.
> >
> > You can try below patch to see if it works:
>
> So, AFAIU I have to apply patch to kexec tools for the fist kernel + userspace
> and apply kernel patch for the second kernel? Or it's all for the first one?
>
> > apply a kexec-tools patch to kexec-tools if you do not use kexec -s
> > (kexec_file_load):
>
> Here is how we are using it:
> https://github.com/andy-shev/buildroot/blob/intel/board/intel/common/netboot/udhcpc-script.sh#L54
Okay, thanks for the patches. I have applied them to both kernels, so the first
one and second one are the same and kexec tools have a patch provided in the
user space of the both kernels (only first one in use though).
Before applying your patch, I have reverted my hacks (as per this series).
Result is:
# uname -a
Linux buildroot 5.13.0-rc5+ #1 SMP Mon Jun 7 19:49:40 EEST 2021 i586 GNU/Linux
# dmidecode
# dmidecode 3.3
Scanning /dev/mem for entry point.
# No SMBIOS nor DMI entry point found, sorry.
I.o.w. it does NOT fix the issue. My patches do (with a hint from user space).
--
With Best Regards,
Andy Shevchenko
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2021-06-07 17:19 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-02 19:54 [PATCH v1 0/2] firmware: dmi_scan: Make it work in kexec'ed kernel Andy Shevchenko
2016-12-02 19:54 ` [PATCH v1 1/2] firmware: dmi_scan: Split out dmi_get_entry_point() helper Andy Shevchenko
2016-12-15 11:13 ` Jean Delvare
2016-12-02 19:54 ` [PATCH v1 2/2] firmware: dmi_scan: Pass dmi_entry_point to kexec'ed kernel Andy Shevchenko
2016-12-15 11:28 ` Jean Delvare
2016-12-15 11:28 ` Jean Delvare
2016-12-16 2:32 ` Dave Young
2016-12-16 2:32 ` Dave Young
2016-12-16 12:18 ` Andy Shevchenko
2016-12-16 12:18 ` Andy Shevchenko
2016-12-16 13:33 ` Jean Delvare
2016-12-16 13:33 ` Jean Delvare
2016-12-17 10:57 ` Dave Young
2016-12-17 10:57 ` Dave Young
2019-09-06 19:00 ` Andy Shevchenko
2019-09-06 19:00 ` Andy Shevchenko
2020-01-20 12:19 ` Andy Shevchenko
2020-01-20 16:04 ` Eric W. Biederman
2020-01-20 21:42 ` Jean Delvare
2020-01-20 21:55 ` Andy Shevchenko
2020-01-21 9:03 ` Jean Delvare
2020-01-21 16:29 ` Eric W. Biederman
2020-01-21 17:24 ` Andy Shevchenko
2020-01-20 22:31 ` Andy Shevchenko
2020-01-20 23:18 ` Ard Biesheuvel
2020-01-21 15:37 ` Andy Shevchenko
2020-01-21 17:17 ` Eric W. Biederman
2020-05-21 17:39 ` Andy Shevchenko
2020-05-21 17:39 ` Andy Shevchenko
2021-06-02 8:37 ` Andy Shevchenko
2021-06-02 8:37 ` Andy Shevchenko
2021-06-02 8:53 ` Andy Shevchenko
2021-06-02 8:53 ` Andy Shevchenko
2016-12-17 10:50 ` Dave Young
2016-12-17 10:50 ` Dave Young
2020-01-20 12:16 ` [PATCH v1 0/2] firmware: dmi_scan: Make it work in " Andy Shevchenko
2020-05-21 15:53 ` Andy Shevchenko
2020-05-21 15:59 ` Andy Shevchenko
2021-06-02 8:42 ` Andy Shevchenko
2021-06-02 8:42 ` Andy Shevchenko
2021-06-02 8:53 ` Andy Shevchenko
2021-06-02 8:53 ` Andy Shevchenko
2021-06-05 7:51 ` Dave Young
2021-06-05 7:51 ` Dave Young
2021-06-07 16:22 ` Andy Shevchenko
2021-06-07 16:22 ` Andy Shevchenko
2021-06-07 17:18 ` Andy Shevchenko [this message]
2021-06-07 17:18 ` Andy Shevchenko
2021-06-08 12:25 ` Dave Young
2021-06-08 12:25 ` Dave Young
2021-06-08 12:38 ` Andy Shevchenko
2021-06-08 12:38 ` Andy Shevchenko
2021-06-09 11:55 ` Dave Young
2021-06-09 11:55 ` Dave Young
2021-06-12 4:40 ` Dave Young
2021-06-12 4:40 ` Dave Young
2021-06-14 15:38 ` Andy Shevchenko
2021-06-14 15:38 ` Andy Shevchenko
2021-06-14 17:07 ` Andy Shevchenko
2021-06-14 17:07 ` Andy Shevchenko
2021-06-14 17:27 ` Andy Shevchenko
2021-06-14 17:27 ` Andy Shevchenko
2021-07-19 7:53 ` Ard Biesheuvel
2021-07-19 7:53 ` Ard Biesheuvel
2021-07-19 8:25 ` Andy Shevchenko
2021-07-19 8:25 ` Andy Shevchenko
2021-10-06 16:28 ` Andy Shevchenko
2021-10-06 16:28 ` Andy Shevchenko
2021-10-07 7:20 ` Ard Biesheuvel
2021-10-07 7:20 ` Ard Biesheuvel
2021-10-07 7:23 ` Andy Shevchenko
2021-10-07 7:23 ` Andy Shevchenko
2021-10-17 13:31 ` Ard Biesheuvel
2021-10-17 13:31 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YL5U/zSb50SnbLgW@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=ardb@kernel.org \
--cc=dyoung@redhat.com \
--cc=ebiederm@xmission.com \
--cc=javier.tia@gmail.com \
--cc=jdelvare@suse.com \
--cc=kexec@lists.infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeblueprint.co.uk \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.