From: Bhaskar Chowdhury <unixbhaskar@gmail.com>
To: gkis <gabrielkis65@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Greg KH <gregkh@linuxfoundation.org>,
Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [PATCH] My First Patch - Gabriel e Felipe
Date: Mon, 31 May 2021 02:07:30 +0530 [thread overview]
Message-ID: <YLP3itEafpN5EacM@Gentoo> (raw)
In-Reply-To: <20210530174739.17066-1-gabrielkis65@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1336 bytes --]
On 14:47 Sun 30 May 2021, gkis wrote:
>Signed-off-by: gkis <gabrielkis65@gmail.com>
>---
> init/main.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/init/main.c b/init/main.c
>index 598e278b4..bc366b166 100644
>--- a/init/main.c
>+++ b/init/main.c
>@@ -1082,6 +1082,7 @@ static int __ref kernel_init(void *unused)
> numa_default_policy();
>
> rcu_end_inkernel_boot();
>+ printk(KERN_ERR "###################################\nI can hack the Linux kernel!\n###################################\n");
>
> if (ramdisk_execute_command) {
> ret = run_init_process(ramdisk_execute_command);
>--
>2.17.1
>
Hi Gabriel,
Thanks for your effort to and time to contribute to the project we love and
work with.
Two nit picking ...as you mentioned it is your "first patch" ...early heads
up..
1) Please write a "to the point" Changelog while submitting a patch. It is
greatly help the maintainer to understand "motive" and "problem solving"
stuff from it. Also Please mention "Why" the change is needed than "what" is
changed.
2) Kindly use your Full and Actual name in the sign off line. I believe
"gkis" is not the legal name you will go. If it is , then pardon my
understanding.
I am CCing this to people , who are long attach to this project and know exactly
what needs to be done.
Thanks,
Bhaskar
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2021-05-30 20:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-30 17:47 [PATCH] My First Patch - Gabriel e Felipe gkis
2021-05-30 20:37 ` Bhaskar Chowdhury [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLP3itEafpN5EacM@Gentoo \
--to=unixbhaskar@gmail.com \
--cc=gabrielkis65@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.