* [PATCH] My First Patch - Gabriel e Felipe
@ 2021-05-30 17:47 gkis
2021-05-30 20:37 ` Bhaskar Chowdhury
0 siblings, 1 reply; 2+ messages in thread
From: gkis @ 2021-05-30 17:47 UTC (permalink / raw)
To: linux-kernel
Signed-off-by: gkis <gabrielkis65@gmail.com>
---
init/main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/init/main.c b/init/main.c
index 598e278b4..bc366b166 100644
--- a/init/main.c
+++ b/init/main.c
@@ -1082,6 +1082,7 @@ static int __ref kernel_init(void *unused)
numa_default_policy();
rcu_end_inkernel_boot();
+ printk(KERN_ERR "###################################\nI can hack the Linux kernel!\n###################################\n");
if (ramdisk_execute_command) {
ret = run_init_process(ramdisk_execute_command);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] My First Patch - Gabriel e Felipe
2021-05-30 17:47 [PATCH] My First Patch - Gabriel e Felipe gkis
@ 2021-05-30 20:37 ` Bhaskar Chowdhury
0 siblings, 0 replies; 2+ messages in thread
From: Bhaskar Chowdhury @ 2021-05-30 20:37 UTC (permalink / raw)
To: gkis; +Cc: linux-kernel, Greg KH, Randy Dunlap
[-- Attachment #1: Type: text/plain, Size: 1336 bytes --]
On 14:47 Sun 30 May 2021, gkis wrote:
>Signed-off-by: gkis <gabrielkis65@gmail.com>
>---
> init/main.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/init/main.c b/init/main.c
>index 598e278b4..bc366b166 100644
>--- a/init/main.c
>+++ b/init/main.c
>@@ -1082,6 +1082,7 @@ static int __ref kernel_init(void *unused)
> numa_default_policy();
>
> rcu_end_inkernel_boot();
>+ printk(KERN_ERR "###################################\nI can hack the Linux kernel!\n###################################\n");
>
> if (ramdisk_execute_command) {
> ret = run_init_process(ramdisk_execute_command);
>--
>2.17.1
>
Hi Gabriel,
Thanks for your effort to and time to contribute to the project we love and
work with.
Two nit picking ...as you mentioned it is your "first patch" ...early heads
up..
1) Please write a "to the point" Changelog while submitting a patch. It is
greatly help the maintainer to understand "motive" and "problem solving"
stuff from it. Also Please mention "Why" the change is needed than "what" is
changed.
2) Kindly use your Full and Actual name in the sign off line. I believe
"gkis" is not the legal name you will go. If it is , then pardon my
understanding.
I am CCing this to people , who are long attach to this project and know exactly
what needs to be done.
Thanks,
Bhaskar
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-30 20:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-30 17:47 [PATCH] My First Patch - Gabriel e Felipe gkis
2021-05-30 20:37 ` Bhaskar Chowdhury
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.