From: "david@gibson.dropbear.id.au" <david@gibson.dropbear.id.au>
To: Luis Fernando Fujita Pires <luis.pires@eldorado.org.br>
Cc: "farosas@linux.ibm.com" <farosas@linux.ibm.com>,
"richard.henderson@linaro.org" <richard.henderson@linaro.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Greg Kurz <groug@kaod.org>,
Lucas Mateus Martins Araujo e Castro
<lucas.araujo@eldorado.org.br>,
Fernando Eckhardt Valle <fernando.valle@eldorado.org.br>,
"qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>,
Matheus Kowalczuk Ferst <matheus.ferst@eldorado.org.br>
Subject: Re: [PATCH v3 4/4] target/ppc: removed all mentions to PPC_DUMP_CPU
Date: Tue, 1 Jun 2021 12:47:37 +1000 [thread overview]
Message-ID: <YLWfybO+un4b+PQK@yekko> (raw)
In-Reply-To: <CP2PR80MB3668B881BB8849805BB576A7DA3F9@CP2PR80MB3668.lamprd80.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 1222 bytes --]
On Mon, May 31, 2021 at 05:46:07PM +0000, Luis Fernando Fujita Pires wrote:
> From: Bruno Larsen (billionai) <bruno.larsen@eldorado.org.br>
> > This feature will no longer be useful as ppc moves to using decotree for TCG.
> > And building with it enabled is no longer possible, due to changes in
> > opc_handler_t. Since the last commit that mentions it happened in 2014, I think
> > it is safe to remove it.
> >
> > Signed-off-by: Bruno Larsen (billionai) <bruno.larsen@eldorado.org.br>
> > ---
> > target/ppc/cpu_init.c | 205 -----------------------------------------
> > target/ppc/internal.h | 2 -
> > target/ppc/translate.c | 105 ---------------------
> > 3 files changed, 312 deletions(-)
>
> I believe you lost Richard's review for this one. In addition to approving it, he also noted the a typo in the commit message ("decotree" -> "decodetree").
I folded in the typo fix and Richard's R-b for this patch and the
previous one.
> Reviewed-by: Luis Pires <luis.pires@eldorado.org.br>
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-06-01 3:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-31 14:56 [PATCH v3 0/4] target/ppc: Remove DO_PPC_STATISTICS and PPC_DUMP_CPU Bruno Larsen (billionai)
2021-05-31 14:56 ` [PATCH v3 1/4] hw/core/cpu: removed cpu_dump_statistics function Bruno Larsen (billionai)
2021-05-31 14:56 ` [PATCH v3 2/4] HMP: added info cpustats to removed_features.rst Bruno Larsen (billionai)
2021-05-31 17:52 ` Bruno Piazera Larsen
2021-05-31 14:56 ` [PATCH v3 3/4] target/ppc: removed GEN_OPCODE decision tree Bruno Larsen (billionai)
2021-05-31 17:42 ` Luis Fernando Fujita Pires
2021-05-31 14:56 ` [PATCH v3 4/4] target/ppc: removed all mentions to PPC_DUMP_CPU Bruno Larsen (billionai)
2021-05-31 17:46 ` Luis Fernando Fujita Pires
2021-06-01 2:47 ` david [this message]
2021-06-01 2:47 ` [PATCH v3 0/4] target/ppc: Remove DO_PPC_STATISTICS and PPC_DUMP_CPU David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLWfybO+un4b+PQK@yekko \
--to=david@gibson.dropbear.id.au \
--cc=farosas@linux.ibm.com \
--cc=fernando.valle@eldorado.org.br \
--cc=groug@kaod.org \
--cc=lucas.araujo@eldorado.org.br \
--cc=luis.pires@eldorado.org.br \
--cc=matheus.ferst@eldorado.org.br \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.