From: Eric Biggers <ebiggers@kernel.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: guaneryu@gmail.com, linux-xfs@vger.kernel.org,
fstests@vger.kernel.org, guan@eryu.me
Subject: Re: [PATCH 04/10] fstests: move test group info to test files
Date: Wed, 2 Jun 2021 21:58:03 -0700 [thread overview]
Message-ID: <YLhhW17x/Kq0Bnq3@sol.localdomain> (raw)
In-Reply-To: <162199362461.3744214.7536635976092405399.stgit@locust>
On Tue, May 25, 2021 at 06:47:04PM -0700, Darrick J. Wong wrote:
> diff --git a/tests/btrfs/001 b/tests/btrfs/001
> index fb051e8a..2248b6f6 100755
> --- a/tests/btrfs/001
> +++ b/tests/btrfs/001
> @@ -6,13 +6,9 @@
> #
> # Test btrfs's subvolume and snapshot support
> #
> -seq=`basename $0`
> -seqres=$RESULT_DIR/$seq
> -echo "QA output created by $seq"
> +. ./common/test_names
> +_set_seq_and_groups auto quick subvol snapshot
The naming is a little weird here. This feels more like a common preamble,
especially given that it also sets $here, $tmp, and $status -- not just the test
groups. Maybe it should look like:
. ./common/preamble
_begin_fstest quick subvol snapshot
next prev parent reply other threads:[~2021-06-03 4:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 1:46 [PATCHSET RFC 00/10] fstests: move test group lists into test files Darrick J. Wong
2021-05-26 1:46 ` [PATCH 01/10] fstests: fix group check in new script Darrick J. Wong
2021-05-26 1:46 ` [PATCH 02/10] fstests: refactor setting test sequence number variables Darrick J. Wong
2021-05-26 1:46 ` [PATCH 03/10] fstests: add tool migrate group membership data to test files Darrick J. Wong
2021-05-26 1:47 ` [PATCH 04/10] fstests: move test group info " Darrick J. Wong
2021-06-03 4:58 ` Eric Biggers [this message]
2021-06-03 15:23 ` Darrick J. Wong
2021-05-26 1:47 ` [PATCH 05/10] fstests: clean up open-coded golden output Darrick J. Wong
2021-05-26 1:47 ` [PATCH 06/10] fstests: automatically generate group files Darrick J. Wong
2021-05-26 1:47 ` [PATCH 07/10] fstests: convert nextid to use automatic group generation Darrick J. Wong
2021-05-26 1:47 ` [PATCH 08/10] fstests: adapt the new test script to our new group tagging scheme Darrick J. Wong
2021-05-26 1:47 ` [PATCH 09/10] fstests: remove group files Darrick J. Wong
2021-05-26 1:47 ` [PATCH 10/10] fstests: remove test group management code Darrick J. Wong
2021-06-03 6:32 ` [PATCHSET RFC 00/10] fstests: move test group lists into test files Amir Goldstein
2021-06-03 15:34 ` Darrick J. Wong
2021-06-03 16:56 ` Amir Goldstein
2021-06-03 22:21 ` Darrick J. Wong
2021-06-06 14:44 ` Eryu Guan
2021-06-06 18:05 ` Darrick J. Wong
2021-06-07 17:06 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLhhW17x/Kq0Bnq3@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=guan@eryu.me \
--cc=guaneryu@gmail.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.