All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jiabing Wan <wanjiabing@vivo.com>
Cc: Fabio Aiuto <fabioaiuto83@gmail.com>,
	Ross Schmidt <ross.schm.dev@gmail.com>,
	Qiang Ma <maqianga@uniontech.com>,
	Marco Cesati <marcocesati@gmail.com>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: core: fix some incorrect type warnings
Date: Thu, 3 Jun 2021 11:17:00 +0200	[thread overview]
Message-ID: <YLieDLLcsTctEwXD@kroah.com> (raw)
In-Reply-To: <AO6AtgBODjnoS0IYaAQ1bKoy.3.1622709415201.Hmail.wanjiabing@vivo.com>

On Thu, Jun 03, 2021 at 04:36:55PM +0800, Jiabing Wan wrote:
>  
>  
> Hi,all
> 
> I fix these warnings by refering other patches.
> 
> Actually, I don't understand clearly what I did.  
> 
> But there are no warnings after this fix.
> 
> So if this fix were totally wrong, please told me and 
> gave me some suggestions.
> 
> It is important for me to fix a sparse bug.

Do not fix sparse bugs just for the sake of fixing sparse bugs.  Fix
things you know are needed to be fixed.

Please look closer at this to ensure that you really are fixing this
correctly and understand what you are doing before sending it out.

thanks,

greg k-h

  reply	other threads:[~2021-06-03  9:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-03  8:24 [PATCH] staging: rtl8723bs: core: fix some incorrect type warnings Wan Jiabing
2021-06-03  8:36 ` Jiabing Wan
2021-06-03  8:36   ` Jiabing Wan
2021-06-03  9:17   ` Greg Kroah-Hartman [this message]
2021-06-03  9:18 ` [PATCH] " Greg Kroah-Hartman
2021-06-04  2:19   ` Jiabing Wan
2021-06-04  2:19     ` Jiabing Wan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YLieDLLcsTctEwXD@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=fabioaiuto83@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=maqianga@uniontech.com \
    --cc=marcocesati@gmail.com \
    --cc=ross.schm.dev@gmail.com \
    --cc=wanjiabing@vivo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.