From: Stefan Hajnoczi <stefanha@redhat.com>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
Jason Wang <jasowang@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
slp@redhat.com, sgarzare@redhat.com,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH 0/3] virtio_blk: blk-mq io_poll support
Date: Thu, 3 Jun 2021 16:30:25 +0100 [thread overview]
Message-ID: <YLj1kUiTTlLm5HwU@stefanha-x1.localdomain> (raw)
In-Reply-To: <20210520141305.355961-1-stefanha@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1808 bytes --]
On Thu, May 20, 2021 at 03:13:02PM +0100, Stefan Hajnoczi wrote:
> This patch series implements blk_mq_ops->poll() so REQ_HIPRI requests can be
> polled. IOPS for 4k and 16k block sizes increases by 5-18% on a virtio-blk
> device with 4 virtqueues backed by an NVMe drive.
>
> - Benchmark: fio ioengine=pvsync2 numjobs=4 direct=1
> - Guest: 4 vCPUs with one virtio-blk device (4 virtqueues)
> - Disk: Intel Corporation NVMe Datacenter SSD [Optane] [8086:2701]
> - CPU: Intel(R) Xeon(R) Silver 4214 CPU @ 2.20GHz
>
> rw bs hipri=0 hipri=1
> ------------------------------
> randread 4k 149,426 170,763 +14%
> randread 16k 118,939 134,269 +12%
> randread 64k 34,886 34,906 0%
> randread 128k 17,655 17,667 0%
> randwrite 4k 138,578 163,600 +18%
> randwrite 16k 102,089 120,950 +18%
> randwrite 64k 32,364 32,561 0%
> randwrite 128k 16,154 16,237 0%
> read 4k 146,032 170,620 +16%
> read 16k 117,097 130,437 +11%
> read 64k 34,834 35,037 0%
> read 128k 17,680 17,658 0%
> write 4k 134,562 151,422 +12%
> write 16k 101,796 107,606 +5%
> write 64k 32,364 32,594 0%
> write 128k 16,259 16,265 0%
>
> Larger block sizes do not benefit from polling as much but the
> improvement is worthwhile for smaller block sizes.
>
> Stefan Hajnoczi (3):
> virtio: add virtioqueue_more_used()
> virtio_blk: avoid repeating vblk->vqs[qid]
> virtio_blk: implement blk_mq_ops->poll()
>
> include/linux/virtio.h | 2 +
> drivers/block/virtio_blk.c | 126 +++++++++++++++++++++++++++++------
> drivers/virtio/virtio_ring.c | 17 +++++
> 3 files changed, 123 insertions(+), 22 deletions(-)
Christoph and Jens: Any more thoughts on this irq toggling approach?
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Stefan Hajnoczi <stefanha@redhat.com>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
linux-block@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 0/3] virtio_blk: blk-mq io_poll support
Date: Thu, 3 Jun 2021 16:30:25 +0100 [thread overview]
Message-ID: <YLj1kUiTTlLm5HwU@stefanha-x1.localdomain> (raw)
In-Reply-To: <20210520141305.355961-1-stefanha@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 1808 bytes --]
On Thu, May 20, 2021 at 03:13:02PM +0100, Stefan Hajnoczi wrote:
> This patch series implements blk_mq_ops->poll() so REQ_HIPRI requests can be
> polled. IOPS for 4k and 16k block sizes increases by 5-18% on a virtio-blk
> device with 4 virtqueues backed by an NVMe drive.
>
> - Benchmark: fio ioengine=pvsync2 numjobs=4 direct=1
> - Guest: 4 vCPUs with one virtio-blk device (4 virtqueues)
> - Disk: Intel Corporation NVMe Datacenter SSD [Optane] [8086:2701]
> - CPU: Intel(R) Xeon(R) Silver 4214 CPU @ 2.20GHz
>
> rw bs hipri=0 hipri=1
> ------------------------------
> randread 4k 149,426 170,763 +14%
> randread 16k 118,939 134,269 +12%
> randread 64k 34,886 34,906 0%
> randread 128k 17,655 17,667 0%
> randwrite 4k 138,578 163,600 +18%
> randwrite 16k 102,089 120,950 +18%
> randwrite 64k 32,364 32,561 0%
> randwrite 128k 16,154 16,237 0%
> read 4k 146,032 170,620 +16%
> read 16k 117,097 130,437 +11%
> read 64k 34,834 35,037 0%
> read 128k 17,680 17,658 0%
> write 4k 134,562 151,422 +12%
> write 16k 101,796 107,606 +5%
> write 64k 32,364 32,594 0%
> write 128k 16,259 16,265 0%
>
> Larger block sizes do not benefit from polling as much but the
> improvement is worthwhile for smaller block sizes.
>
> Stefan Hajnoczi (3):
> virtio: add virtioqueue_more_used()
> virtio_blk: avoid repeating vblk->vqs[qid]
> virtio_blk: implement blk_mq_ops->poll()
>
> include/linux/virtio.h | 2 +
> drivers/block/virtio_blk.c | 126 +++++++++++++++++++++++++++++------
> drivers/virtio/virtio_ring.c | 17 +++++
> 3 files changed, 123 insertions(+), 22 deletions(-)
Christoph and Jens: Any more thoughts on this irq toggling approach?
Stefan
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 183 bytes --]
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2021-06-03 15:30 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-20 14:13 [PATCH 0/3] virtio_blk: blk-mq io_poll support Stefan Hajnoczi
2021-05-20 14:13 ` Stefan Hajnoczi
2021-05-20 14:13 ` [PATCH 1/3] virtio: add virtioqueue_more_used() Stefan Hajnoczi
2021-05-20 14:13 ` Stefan Hajnoczi
2021-05-25 2:23 ` Jason Wang
2021-05-25 2:23 ` Jason Wang
2021-05-25 8:48 ` Stefan Hajnoczi
2021-05-25 8:48 ` Stefan Hajnoczi
2021-05-20 14:13 ` [PATCH 2/3] virtio_blk: avoid repeating vblk->vqs[qid] Stefan Hajnoczi
2021-05-20 14:13 ` Stefan Hajnoczi
2021-05-25 2:25 ` Jason Wang
2021-05-25 2:25 ` Jason Wang
2021-05-20 14:13 ` [PATCH 3/3] virtio_blk: implement blk_mq_ops->poll() Stefan Hajnoczi
2021-05-20 14:13 ` Stefan Hajnoczi
2021-05-24 14:59 ` Christoph Hellwig
2021-05-24 14:59 ` Christoph Hellwig
2021-05-25 7:22 ` Paolo Bonzini
2021-05-25 7:22 ` Paolo Bonzini
2021-05-25 7:38 ` Ming Lei
2021-05-25 7:38 ` Ming Lei
2021-05-25 8:06 ` Paolo Bonzini
2021-05-25 8:06 ` Paolo Bonzini
2021-05-25 13:20 ` Stefan Hajnoczi
2021-05-25 13:20 ` Stefan Hajnoczi
2021-05-25 13:19 ` Stefan Hajnoczi
2021-05-25 13:19 ` Stefan Hajnoczi
2021-05-25 3:21 ` Jason Wang
2021-05-25 3:21 ` Jason Wang
2021-05-25 8:59 ` Stefan Hajnoczi
2021-05-25 8:59 ` Stefan Hajnoczi
2021-05-27 5:48 ` Jason Wang
2021-05-27 5:48 ` Jason Wang
2021-06-03 15:24 ` Stefan Hajnoczi
2021-06-03 15:24 ` Stefan Hajnoczi
2021-05-27 2:44 ` Ming Lei
2021-05-27 2:44 ` Ming Lei
2021-06-03 15:12 ` Stefan Hajnoczi
2021-06-03 15:12 ` Stefan Hajnoczi
2021-06-03 15:30 ` Stefan Hajnoczi [this message]
2021-06-03 15:30 ` [PATCH 0/3] virtio_blk: blk-mq io_poll support Stefan Hajnoczi
2021-06-16 7:43 ` Christoph Hellwig
2021-06-16 7:43 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLj1kUiTTlLm5HwU@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=jasowang@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=sgarzare@redhat.com \
--cc=slp@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.