From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: kernel test robot <lkp@intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, kbuild-all@lists.01.org,
"Rafael J. Wysocki" <rafael@kernel.org>,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH v1 1/1] device property: Unify access to of_node
Date: Fri, 4 Jun 2021 18:55:54 +0300 [thread overview]
Message-ID: <YLpNCqho0b3vS7K1@smile.fi.intel.com> (raw)
In-Reply-To: <202106042250.BjbSOQc0-lkp@intel.com>
On Fri, Jun 04, 2021 at 10:55:05PM +0800, kernel test robot wrote:
> Hi Andy,
>
> I love your patch! Perhaps something to improve:
Definitely. Thanks for report!
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All warnings (new ones prefixed by >>):
>
> drivers/base/property.c: In function 'device_dma_supported':
> >> drivers/base/property.c:875:48: warning: passing argument 1 of 'to_acpi_device_node' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
> 875 | return acpi_dma_supported(to_acpi_device_node(fwnode));
> | ^~~~~~
> In file included from drivers/base/property.c:10:
> include/linux/acpi.h:768:77: note: expected 'struct fwnode_handle *' but argument is of type 'const struct fwnode_handle *'
> 768 | static inline struct acpi_device *to_acpi_device_node(struct fwnode_handle *fwnode)
> | ~~~~~~~~~~~~~~~~~~~~~~^~~~~~
> drivers/base/property.c: In function 'device_get_dma_attr':
> drivers/base/property.c:890:48: warning: passing argument 1 of 'to_acpi_device_node' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
> 890 | attr = acpi_get_dma_attr(to_acpi_device_node(fwnode));
> | ^~~~~~
> In file included from drivers/base/property.c:10:
> include/linux/acpi.h:768:77: note: expected 'struct fwnode_handle *' but argument is of type 'const struct fwnode_handle *'
> 768 | static inline struct acpi_device *to_acpi_device_node(struct fwnode_handle *fwnode)
> | ~~~~~~~~~~~~~~~~~~~~~~^~~~~~
--
With Best Regards,
Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v1 1/1] device property: Unify access to of_node
Date: Fri, 04 Jun 2021 18:55:54 +0300 [thread overview]
Message-ID: <YLpNCqho0b3vS7K1@smile.fi.intel.com> (raw)
In-Reply-To: <202106042250.BjbSOQc0-lkp@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1897 bytes --]
On Fri, Jun 04, 2021 at 10:55:05PM +0800, kernel test robot wrote:
> Hi Andy,
>
> I love your patch! Perhaps something to improve:
Definitely. Thanks for report!
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All warnings (new ones prefixed by >>):
>
> drivers/base/property.c: In function 'device_dma_supported':
> >> drivers/base/property.c:875:48: warning: passing argument 1 of 'to_acpi_device_node' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
> 875 | return acpi_dma_supported(to_acpi_device_node(fwnode));
> | ^~~~~~
> In file included from drivers/base/property.c:10:
> include/linux/acpi.h:768:77: note: expected 'struct fwnode_handle *' but argument is of type 'const struct fwnode_handle *'
> 768 | static inline struct acpi_device *to_acpi_device_node(struct fwnode_handle *fwnode)
> | ~~~~~~~~~~~~~~~~~~~~~~^~~~~~
> drivers/base/property.c: In function 'device_get_dma_attr':
> drivers/base/property.c:890:48: warning: passing argument 1 of 'to_acpi_device_node' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
> 890 | attr = acpi_get_dma_attr(to_acpi_device_node(fwnode));
> | ^~~~~~
> In file included from drivers/base/property.c:10:
> include/linux/acpi.h:768:77: note: expected 'struct fwnode_handle *' but argument is of type 'const struct fwnode_handle *'
> 768 | static inline struct acpi_device *to_acpi_device_node(struct fwnode_handle *fwnode)
> | ~~~~~~~~~~~~~~~~~~~~~~^~~~~~
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-06-04 15:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-04 13:13 [PATCH v1 1/1] device property: Unify access to of_node Andy Shevchenko
2021-06-04 13:25 ` Greg Kroah-Hartman
2021-06-04 14:55 ` kernel test robot
2021-06-04 14:55 ` kernel test robot
2021-06-04 15:55 ` Andy Shevchenko [this message]
2021-06-04 15:55 ` Andy Shevchenko
2021-06-04 16:14 ` kernel test robot
2021-06-04 16:14 ` kernel test robot
2021-06-04 16:36 ` Andy Shevchenko
2021-06-04 16:36 ` Andy Shevchenko
2021-06-04 17:29 ` kernel test robot
2021-06-04 17:29 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLpNCqho0b3vS7K1@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.