All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] fs: Allow open with O_CREAT to succeed if existing dir is specified
@ 2021-06-19 11:01 Arthur Williams
  2021-06-19 12:42 ` Al Viro
  2021-07-01  2:19   ` kernel test robot
  0 siblings, 2 replies; 8+ messages in thread
From: Arthur Williams @ 2021-06-19 11:01 UTC (permalink / raw)
  To: linux-fsdevel; +Cc: viro, Arthur Williams

Make opening a file with the O_CREAT flag a no-op if the specified file
exists even if it exists as a directory. Allows userspace commands, like
flock, to open a file and create it if it doesn't exist instead of
having to parse errno.

Signed-off-by: Arthur Williams <taaparthur@gmail.com>
---
 fs/namei.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/fs/namei.c b/fs/namei.c
index 79b0ff9b151e..58d06709541c 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -3334,8 +3334,6 @@ static int do_open(struct nameidata *nd,
 	if (open_flag & O_CREAT) {
 		if ((open_flag & O_EXCL) && !(file->f_mode & FMODE_CREATED))
 			return -EEXIST;
-		if (d_is_dir(nd->path.dentry))
-			return -EISDIR;
 		error = may_create_in_sticky(mnt_userns, nd,
 					     d_backing_inode(nd->path.dentry));
 		if (unlikely(error))
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-07-01  9:50 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-19 11:01 [PATCH] fs: Allow open with O_CREAT to succeed if existing dir is specified Arthur Williams
2021-06-19 12:42 ` Al Viro
2021-06-19 14:27   ` Matthew Wilcox
     [not found]   ` <CAJ6D+Z96OWwZMzickLP3PtUnsJhSfZqTnLrmk4-t5iNUid=N=Q@mail.gmail.com>
2021-06-19 15:09     ` Al Viro
2021-07-01  2:19 ` [fs] 87f196bed3: xfstests.generic.157.fail kernel test robot
2021-07-01  2:19   ` kernel test robot
2021-07-01  9:48   ` David Sterba
2021-07-01  9:48     ` David Sterba

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.