b4 crash when trying to apply patches with latest version from git

b4 crash when trying to apply patches with latest version from git

[Greg KH]

On the latest version of b4 from git, a06304fcd63f ("Perform an encoding
bug avoidance dance"), I get the following traceback:

Looking up https://lore.kernel.org/r/20210607170054.220975-1-rui.silva%40linaro.org
Analyzing 3 messages in the thread
Checking attestation on all messages, may take a moment...
---
  ✓ [PATCH v3] MAINTAINERS: usb: add entry for isp1760
    + Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> (✓ DKIM/ideasonboard.com)
  ---
  ✓ Signed: DKIM/linaro.org
Traceback (most recent call last):
  File "/mnt/fast_disk/linux/tools/b4/b4/command.py", line 259, in <module>
    cmd()
  File "/mnt/fast_disk/linux/tools/b4/b4/command.py", line 242, in cmd
    cmdargs.func(cmdargs)
  File "/mnt/fast_disk/linux/tools/b4/b4/command.py", line 51, in cmd_am
    b4.mbox.main(cmdargs)
  File "/mnt/fast_disk/linux/tools/b4/b4/mbox.py", line 598, in main
    make_am(msgs, cmdargs, msgid)
  File "/mnt/fast_disk/linux/tools/b4/b4/mbox.py", line 133, in make_am
    b4.save_git_am_mbox([x[1] for x in am_msgs], sys.stdout.buffer)
  File "/mnt/fast_disk/linux/tools/b4/b4/mbox.py", line 133, in <listcomp>
    b4.save_git_am_mbox([x[1] for x in am_msgs], sys.stdout.buffer)
  File "/usr/lib/python3.9/email/message.py", line 391, in __getitem__
    return self.get(name)
  File "/usr/lib/python3.9/email/message.py", line 468, in get
    name = name.lower()
AttributeError: 'int' object has no attribute 'lower'


Any thoughts?

Let me roll back to the last "release" to see if that fixes this.  Yes,
v0.7.1 doesn't have this problem.

thanks,

greg k-h

Re: b4 crash when trying to apply patches with latest version from git

[Greg KH]

On Wed, Jun 09, 2021 at 10:10:04AM +0200, Greg KH wrote:
> On the latest version of b4 from git, a06304fcd63f ("Perform an encoding
> bug avoidance dance"), I get the following traceback:
> 
> Looking up https://lore.kernel.org/r/20210607170054.220975-1-rui.silva%40linaro.org
> Analyzing 3 messages in the thread
> Checking attestation on all messages, may take a moment...
> ---
>   ✓ [PATCH v3] MAINTAINERS: usb: add entry for isp1760
>     + Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> (✓ DKIM/ideasonboard.com)
>   ---
>   ✓ Signed: DKIM/linaro.org
> Traceback (most recent call last):
>   File "/mnt/fast_disk/linux/tools/b4/b4/command.py", line 259, in <module>
>     cmd()
>   File "/mnt/fast_disk/linux/tools/b4/b4/command.py", line 242, in cmd
>     cmdargs.func(cmdargs)
>   File "/mnt/fast_disk/linux/tools/b4/b4/command.py", line 51, in cmd_am
>     b4.mbox.main(cmdargs)
>   File "/mnt/fast_disk/linux/tools/b4/b4/mbox.py", line 598, in main
>     make_am(msgs, cmdargs, msgid)
>   File "/mnt/fast_disk/linux/tools/b4/b4/mbox.py", line 133, in make_am
>     b4.save_git_am_mbox([x[1] for x in am_msgs], sys.stdout.buffer)
>   File "/mnt/fast_disk/linux/tools/b4/b4/mbox.py", line 133, in <listcomp>
>     b4.save_git_am_mbox([x[1] for x in am_msgs], sys.stdout.buffer)
>   File "/usr/lib/python3.9/email/message.py", line 391, in __getitem__
>     return self.get(name)
>   File "/usr/lib/python3.9/email/message.py", line 468, in get
>     name = name.lower()
> AttributeError: 'int' object has no attribute 'lower'
> 
> 
> Any thoughts?
> 
> Let me roll back to the last "release" to see if that fixes this.  Yes,
> v0.7.1 doesn't have this problem.

Hm, 0.7.1 is crashing for me now if I tell it to "try harder":

$ b4 am -t https://lore.kernel.org/r/20210607101634.4948-1-ricky_wu@realtek.com
Looking up https://lore.kernel.org/r/20210607101634.4948-1-ricky_wu%40realtek.com
Analyzing 6 messages in the thread
Checking attestation on all messages, may take a moment...
---
  [PATCH v2] misc: rtsx: separate aspm mode into MODE_REG and MODE_CFG
    + Fixes: 121e9c6b5c4c ("misc: rtsx: modify and fix init_hw function")
    + Reported-by: Chris Chiu <chris.chiu@canonical.com>
---
Total patches: 1
---
NOTE: some trailers ignored due to from/email mismatches:
    ! Trailer: Tested-by: Gordon Lack <gordon.lack@dsl.pipex.com>
     Msg From: Chris Chiu <chris.chiu@canonical.com>
NOTE: Rerun with -S to apply them anyway
---
 Link: https://lore.kernel.org/r/20210607101634.4948-1-ricky_wu@realtek.com
 Base: not found (applies clean to current tree)
       git am ./v2_20210607_ricky_wu_misc_rtsx_separate_aspm_mode_into_mode_reg_and_mode_cfg.mbx


So I add -S to the line and try again:

$ b4 am -t -S https://lore.kernel.org/r/20210607101634.4948-1-ricky_wu@realtek.com
Looking up https://lore.kernel.org/r/20210607101634.4948-1-ricky_wu%40realtek.com
Analyzing 6 messages in the thread
Checking attestation on all messages, may take a moment...
---
  [PATCH v2] misc: rtsx: separate aspm mode into MODE_REG and MODE_CFG
Traceback (most recent call last):
  File "/mnt/fast_disk/linux/tools/b4/b4/command.py", line 254, in <module>
    cmd()
  File "/mnt/fast_disk/linux/tools/b4/b4/command.py", line 237, in cmd
    cmdargs.func(cmdargs)
  File "/mnt/fast_disk/linux/tools/b4/b4/command.py", line 51, in cmd_am
    b4.mbox.main(cmdargs)
  File "/mnt/fast_disk/linux/tools/b4/b4/mbox.py", line 622, in main
    make_am(msgs, cmdargs, msgid)
  File "/mnt/fast_disk/linux/tools/b4/b4/mbox.py", line 92, in make_am
    am_msgs = lser.get_am_ready(noaddtrailers=cmdargs.noaddtrailers,
  File "/mnt/fast_disk/linux/tools/b4/b4/__init__.py", line 600, in get_am_ready
    msg = lmsg.get_am_message(add_trailers=add_trailers, trailer_order=trailer_order, copyccs=copyccs)
  File "/mnt/fast_disk/linux/tools/b4/b4/__init__.py", line 1476, in get_am_message
    self.fix_trailers(trailer_order=trailer_order, copyccs=copyccs)
  File "/mnt/fast_disk/linux/tools/b4/b4/__init__.py", line 1412, in fix_trailers
    if trailer[3] is not None:
IndexError: list index out of range


I guess it's a different error, but I hate reading python tracebacks so
I can't really tell...

thanks,

greg k-h

Re: b4 crash when trying to apply patches with latest version from git

[Konstantin Ryabitsev]

On Wed, Jun 09, 2021 at 10:10:04AM +0200, Greg KH wrote:
> On the latest version of b4 from git, a06304fcd63f ("Perform an encoding
> bug avoidance dance"), I get the following traceback:
> 
> Looking up https://lore.kernel.org/r/20210607170054.220975-1-rui.silva%40linaro.org
> Analyzing 3 messages in the thread
> Checking attestation on all messages, may take a moment...
> ---
>   ✓ [PATCH v3] MAINTAINERS: usb: add entry for isp1760
>     + Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> (✓ DKIM/ideasonboard.com)
>   ---
>   ✓ Signed: DKIM/linaro.org
> Traceback (most recent call last):
>   File "/mnt/fast_disk/linux/tools/b4/b4/command.py", line 259, in <module>
>     cmd()
>   File "/mnt/fast_disk/linux/tools/b4/b4/command.py", line 242, in cmd
>     cmdargs.func(cmdargs)
>   File "/mnt/fast_disk/linux/tools/b4/b4/command.py", line 51, in cmd_am
>     b4.mbox.main(cmdargs)
>   File "/mnt/fast_disk/linux/tools/b4/b4/mbox.py", line 598, in main
>     make_am(msgs, cmdargs, msgid)
>   File "/mnt/fast_disk/linux/tools/b4/b4/mbox.py", line 133, in make_am
>     b4.save_git_am_mbox([x[1] for x in am_msgs], sys.stdout.buffer)
>   File "/mnt/fast_disk/linux/tools/b4/b4/mbox.py", line 133, in <listcomp>
>     b4.save_git_am_mbox([x[1] for x in am_msgs], sys.stdout.buffer)
>   File "/usr/lib/python3.9/email/message.py", line 391, in __getitem__
>     return self.get(name)
>   File "/usr/lib/python3.9/email/message.py", line 468, in get
>     name = name.lower()
> AttributeError: 'int' object has no attribute 'lower'
> 
> 
> Any thoughts?

Thank you, this is fixed in master now.

-K

Re: b4 crash when trying to apply patches with latest version from git

[Konstantin Ryabitsev]

On Wed, Jun 09, 2021 at 02:49:13PM +0200, Greg KH wrote:
> $ b4 am -t -S https://lore.kernel.org/r/20210607101634.4948-1-ricky_wu@realtek.com
> Looking up https://lore.kernel.org/r/20210607101634.4948-1-ricky_wu%40realtek.com
> Analyzing 6 messages in the thread
> Checking attestation on all messages, may take a moment...
> ---
>   [PATCH v2] misc: rtsx: separate aspm mode into MODE_REG and MODE_CFG
> Traceback (most recent call last):
>   File "/mnt/fast_disk/linux/tools/b4/b4/command.py", line 254, in <module>
>     cmd()
>   File "/mnt/fast_disk/linux/tools/b4/b4/command.py", line 237, in cmd
>     cmdargs.func(cmdargs)
>   File "/mnt/fast_disk/linux/tools/b4/b4/command.py", line 51, in cmd_am
>     b4.mbox.main(cmdargs)
>   File "/mnt/fast_disk/linux/tools/b4/b4/mbox.py", line 622, in main
>     make_am(msgs, cmdargs, msgid)
>   File "/mnt/fast_disk/linux/tools/b4/b4/mbox.py", line 92, in make_am
>     am_msgs = lser.get_am_ready(noaddtrailers=cmdargs.noaddtrailers,
>   File "/mnt/fast_disk/linux/tools/b4/b4/__init__.py", line 600, in get_am_ready
>     msg = lmsg.get_am_message(add_trailers=add_trailers, trailer_order=trailer_order, copyccs=copyccs)
>   File "/mnt/fast_disk/linux/tools/b4/b4/__init__.py", line 1476, in get_am_message
>     self.fix_trailers(trailer_order=trailer_order, copyccs=copyccs)
>   File "/mnt/fast_disk/linux/tools/b4/b4/__init__.py", line 1412, in fix_trailers
>     if trailer[3] is not None:
> IndexError: list index out of range
> 
> 
> I guess it's a different error, but I hate reading python tracebacks so
> I can't really tell...

Different bug -- fixed now as well and backported to stable-0.7.y.

Thanks!

(I swear, I'm going to add a test suite soon -- it's just not very exciting
work. :))

Re: b4 crash when trying to apply patches with latest version from git

[Greg KH]

On Wed, Jun 09, 2021 at 11:43:51AM -0400, Konstantin Ryabitsev wrote:
> On Wed, Jun 09, 2021 at 10:10:04AM +0200, Greg KH wrote:
> > On the latest version of b4 from git, a06304fcd63f ("Perform an encoding
> > bug avoidance dance"), I get the following traceback:
> > 
> > Looking up https://lore.kernel.org/r/20210607170054.220975-1-rui.silva%40linaro.org
> > Analyzing 3 messages in the thread
> > Checking attestation on all messages, may take a moment...
> > ---
> >   ✓ [PATCH v3] MAINTAINERS: usb: add entry for isp1760
> >     + Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> (✓ DKIM/ideasonboard.com)
> >   ---
> >   ✓ Signed: DKIM/linaro.org
> > Traceback (most recent call last):
> >   File "/mnt/fast_disk/linux/tools/b4/b4/command.py", line 259, in <module>
> >     cmd()
> >   File "/mnt/fast_disk/linux/tools/b4/b4/command.py", line 242, in cmd
> >     cmdargs.func(cmdargs)
> >   File "/mnt/fast_disk/linux/tools/b4/b4/command.py", line 51, in cmd_am
> >     b4.mbox.main(cmdargs)
> >   File "/mnt/fast_disk/linux/tools/b4/b4/mbox.py", line 598, in main
> >     make_am(msgs, cmdargs, msgid)
> >   File "/mnt/fast_disk/linux/tools/b4/b4/mbox.py", line 133, in make_am
> >     b4.save_git_am_mbox([x[1] for x in am_msgs], sys.stdout.buffer)
> >   File "/mnt/fast_disk/linux/tools/b4/b4/mbox.py", line 133, in <listcomp>
> >     b4.save_git_am_mbox([x[1] for x in am_msgs], sys.stdout.buffer)
> >   File "/usr/lib/python3.9/email/message.py", line 391, in __getitem__
> >     return self.get(name)
> >   File "/usr/lib/python3.9/email/message.py", line 468, in get
> >     name = name.lower()
> > AttributeError: 'int' object has no attribute 'lower'
> > 
> > 
> > Any thoughts?
> 
> Thank you, this is fixed in master now.

Thanks for this, and the other, quick fix.  I've verified they work now
properly.

greg k-h