* [PATCH] pinctrl: mcp23s08: missing unlock in mcp23s08_irq()
@ 2021-06-10 10:04 Dan Carpenter
2021-06-11 23:56 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2021-06-10 10:04 UTC (permalink / raw)
To: Linus Walleij, Radim Pavlik; +Cc: linux-gpio, kernel-janitors
This code needs to drop the lock before returning.
Fixes: 897120d41e7a ("pinctrl: mcp23s08: fix race condition in irq handler")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/pinctrl/pinctrl-mcp23s08.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-mcp23s08.c b/drivers/pinctrl/pinctrl-mcp23s08.c
index 799d596a1a4b..d0259577934e 100644
--- a/drivers/pinctrl/pinctrl-mcp23s08.c
+++ b/drivers/pinctrl/pinctrl-mcp23s08.c
@@ -353,7 +353,7 @@ static irqreturn_t mcp23s08_irq(int irq, void *data)
if (intf == 0) {
/* There is no interrupt pending */
- return IRQ_HANDLED;
+ goto unlock;
}
if (mcp_read(mcp, MCP_INTCAP, &intcap))
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pinctrl: mcp23s08: missing unlock in mcp23s08_irq()
2021-06-10 10:04 [PATCH] pinctrl: mcp23s08: missing unlock in mcp23s08_irq() Dan Carpenter
@ 2021-06-11 23:56 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2021-06-11 23:56 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Radim Pavlik, open list:GPIO SUBSYSTEM, kernel-janitors
On Thu, Jun 10, 2021 at 12:04 PM Dan Carpenter <dan.carpenter@oracle.com> wrote:
> This code needs to drop the lock before returning.
>
> Fixes: 897120d41e7a ("pinctrl: mcp23s08: fix race condition in irq handler")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Zhou Wei already sent an identical patch but thanks anyway!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-11 23:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-10 10:04 [PATCH] pinctrl: mcp23s08: missing unlock in mcp23s08_irq() Dan Carpenter
2021-06-11 23:56 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.