From: Mike Snitzer <snitzer@redhat.com> To: mwilck@suse.com Cc: Alasdair G Kergon <agk@redhat.com>, Bart Van Assche <Bart.VanAssche@sandisk.com>, dm-devel@redhat.com, Hannes Reinecke <hare@suse.de>, Daniel Wagner <dwagner@suse.de>, linux-block@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>, Christoph Hellwig <hch@lst.de>, Benjamin Marzinski <bmarzins@redhat.com>, linux-scsi@vger.kernel.org Subject: Re: [PATCH v3 0/2] dm: dm_blk_ioctl(): implement failover for SG_IO on dm-multipath Date: Mon, 14 Jun 2021 11:15:19 -0400 [thread overview] Message-ID: <YMdyh62mR/lEifMR@redhat.com> (raw) In-Reply-To: <20210611202509.5426-1-mwilck@suse.com> On Fri, Jun 11 2021 at 4:25P -0400, mwilck@suse.com <mwilck@suse.com> wrote: > From: Martin Wilck <mwilck@suse.com> > > Hello Mike, > > here is v3 of my attempt to add retry logic to SG_IO on dm-multipath devices. > Sorry that it took such a long time. > > Regards > Martin > > Changes v2->v3: > > - un-inlined scsi_result_to_blk_status again, and move the helper > __scsi_result_to_blk_status to block/scsi_ioctl.c instead > (Bart v. Assche) > - open-coded the status/msg/host/driver-byte -> result conversion > where the standard SCSI helpers aren't usable (Bart v. Assche) This work offers a proof-of-concept but it needs further refinement for sure. The proposed open-coded SCSI code (in patch 2's drivers/md/dm-scsi_ioctl.c) is well beyond what I'm willing to take in DM. If this type of functionality is still needed (for kvm's SCSI passthru snafu) then more work is needed to negotiate proper interfaces with the SCSI subsystem (added linux-scsi to cc, odd they weren't engaged on this). Does it make sense to extend the SCSI device handler interface to add the required enablement? (I think it'd have to if this line of work is to ultimately get upstream). Mike > Changes v1->v2: > > - applied modifications from Mike Snitzer > - moved SG_IO dependent code to a separate file, no scsi includes in > dm.c any more > - made the new code depend on a configuration option > - separated out scsi changes, made scsi_result_to_blk_status() > inline to avoid dependency of dm_mod from scsi_mod (Paolo Bonzini) > > Martin Wilck (2): > scsi: export __scsi_result_to_blk_status() in scsi_ioctl.c > dm: add CONFIG_DM_MULTIPATH_SG_IO - failover for SG_IO on dm-multipath > > block/scsi_ioctl.c | 52 ++++++++++++++- > drivers/md/Kconfig | 11 ++++ > drivers/md/Makefile | 4 ++ > drivers/md/dm-core.h | 5 ++ > drivers/md/dm-rq.h | 11 ++++ > drivers/md/dm-scsi_ioctl.c | 127 +++++++++++++++++++++++++++++++++++++ > drivers/md/dm.c | 20 +++++- > drivers/scsi/scsi_lib.c | 29 +-------- > include/linux/blkdev.h | 3 + > 9 files changed, 229 insertions(+), 33 deletions(-) > create mode 100644 drivers/md/dm-scsi_ioctl.c > > -- > 2.31.1 >
WARNING: multiple messages have this Message-ID (diff)
From: Mike Snitzer <snitzer@redhat.com> To: mwilck@suse.com Cc: linux-scsi@vger.kernel.org, Daniel Wagner <dwagner@suse.de>, linux-block@vger.kernel.org, dm-devel@redhat.com, Paolo Bonzini <pbonzini@redhat.com>, Bart Van Assche <Bart.VanAssche@sandisk.com>, Christoph Hellwig <hch@lst.de>, Alasdair G Kergon <agk@redhat.com> Subject: Re: [dm-devel] [PATCH v3 0/2] dm: dm_blk_ioctl(): implement failover for SG_IO on dm-multipath Date: Mon, 14 Jun 2021 11:15:19 -0400 [thread overview] Message-ID: <YMdyh62mR/lEifMR@redhat.com> (raw) In-Reply-To: <20210611202509.5426-1-mwilck@suse.com> On Fri, Jun 11 2021 at 4:25P -0400, mwilck@suse.com <mwilck@suse.com> wrote: > From: Martin Wilck <mwilck@suse.com> > > Hello Mike, > > here is v3 of my attempt to add retry logic to SG_IO on dm-multipath devices. > Sorry that it took such a long time. > > Regards > Martin > > Changes v2->v3: > > - un-inlined scsi_result_to_blk_status again, and move the helper > __scsi_result_to_blk_status to block/scsi_ioctl.c instead > (Bart v. Assche) > - open-coded the status/msg/host/driver-byte -> result conversion > where the standard SCSI helpers aren't usable (Bart v. Assche) This work offers a proof-of-concept but it needs further refinement for sure. The proposed open-coded SCSI code (in patch 2's drivers/md/dm-scsi_ioctl.c) is well beyond what I'm willing to take in DM. If this type of functionality is still needed (for kvm's SCSI passthru snafu) then more work is needed to negotiate proper interfaces with the SCSI subsystem (added linux-scsi to cc, odd they weren't engaged on this). Does it make sense to extend the SCSI device handler interface to add the required enablement? (I think it'd have to if this line of work is to ultimately get upstream). Mike > Changes v1->v2: > > - applied modifications from Mike Snitzer > - moved SG_IO dependent code to a separate file, no scsi includes in > dm.c any more > - made the new code depend on a configuration option > - separated out scsi changes, made scsi_result_to_blk_status() > inline to avoid dependency of dm_mod from scsi_mod (Paolo Bonzini) > > Martin Wilck (2): > scsi: export __scsi_result_to_blk_status() in scsi_ioctl.c > dm: add CONFIG_DM_MULTIPATH_SG_IO - failover for SG_IO on dm-multipath > > block/scsi_ioctl.c | 52 ++++++++++++++- > drivers/md/Kconfig | 11 ++++ > drivers/md/Makefile | 4 ++ > drivers/md/dm-core.h | 5 ++ > drivers/md/dm-rq.h | 11 ++++ > drivers/md/dm-scsi_ioctl.c | 127 +++++++++++++++++++++++++++++++++++++ > drivers/md/dm.c | 20 +++++- > drivers/scsi/scsi_lib.c | 29 +-------- > include/linux/blkdev.h | 3 + > 9 files changed, 229 insertions(+), 33 deletions(-) > create mode 100644 drivers/md/dm-scsi_ioctl.c > > -- > 2.31.1 > -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2021-06-14 15:16 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-11 20:25 [PATCH v3 0/2] dm: dm_blk_ioctl(): implement failover for SG_IO on dm-multipath mwilck 2021-06-11 20:25 ` [dm-devel] " mwilck 2021-06-11 20:25 ` [PATCH v3 1/2] scsi: export __scsi_result_to_blk_status() in scsi_ioctl.c mwilck 2021-06-11 20:25 ` [dm-devel] " mwilck 2021-06-11 20:25 ` [PATCH v3 2/2] dm: add CONFIG_DM_MULTIPATH_SG_IO - failover for SG_IO on dm-multipath mwilck 2021-06-11 20:25 ` [dm-devel] " mwilck 2021-06-15 17:10 ` Mike Snitzer 2021-06-15 17:10 ` [dm-devel] " Mike Snitzer 2021-06-16 9:56 ` Martin Wilck 2021-06-16 9:56 ` [dm-devel] " Martin Wilck 2021-06-14 15:15 ` Mike Snitzer [this message] 2021-06-14 15:15 ` [dm-devel] [PATCH v3 0/2] dm: dm_blk_ioctl(): implement " Mike Snitzer 2021-06-15 10:54 ` Martin Wilck 2021-06-15 10:54 ` [dm-devel] " Martin Wilck 2021-06-15 17:11 ` Mike Snitzer 2021-06-15 17:11 ` [dm-devel] " Mike Snitzer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YMdyh62mR/lEifMR@redhat.com \ --to=snitzer@redhat.com \ --cc=Bart.VanAssche@sandisk.com \ --cc=agk@redhat.com \ --cc=bmarzins@redhat.com \ --cc=dm-devel@redhat.com \ --cc=dwagner@suse.de \ --cc=hare@suse.de \ --cc=hch@lst.de \ --cc=linux-block@vger.kernel.org \ --cc=linux-scsi@vger.kernel.org \ --cc=mwilck@suse.com \ --cc=pbonzini@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.