Re: [PATCH v4 1/3] tty: serial: Add UART driver for Cortina-Access platform

Re: [PATCH v4 1/3] tty: serial: Add UART driver for Cortina-Access platform

[Greg Kroah-Hartman]

On Sun, May 09, 2021 at 11:45:16AM -0700, Alex Nemirovsky wrote:
> From: Jason Li <jason.li@cortina-access.com>
> 
> This driver supports Cortina Access UART IP integrated
> in most all CAXXXX line of SoCs. Earlycom is also supported
> 
> Signed-off-by: Jason Li <jason.li@cortina-access.com>
> ---

I can't take this without the DT maintainers acking the DT changes.

So can you resend this so that they can notice that it requires their
review?

thanks,

greg k-h

Re: [PATCH v4 1/3] tty: serial: Add UART driver for Cortina-Access platform

[Alex Nemirovsky]

The DT maintainers were CC’ed for the DT related files.  However, I suspect they won’t 
ACK it until you ACK the actual serial port driver.

> On Jun 15, 2021, at 4:52 AM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> 
> On Sun, May 09, 2021 at 11:45:16AM -0700, Alex Nemirovsky wrote:
>> From: Jason Li <jason.li@cortina-access.com>
>> 
>> This driver supports Cortina Access UART IP integrated
>> in most all CAXXXX line of SoCs. Earlycom is also supported
>> 
>> Signed-off-by: Jason Li <jason.li@cortina-access.com>
>> ---
> 
> I can't take this without the DT maintainers acking the DT changes.
> 
> So can you resend this so that they can notice that it requires their
> review?
> 
> thanks,
> 
> greg k-h

Re: [PATCH v4 1/3] tty: serial: Add UART driver for Cortina-Access platform

[Greg Kroah-Hartman]

On Tue, Jun 15, 2021 at 01:32:51PM +0000, Alex Nemirovsky wrote:
> The DT maintainers were CC’ed for the DT related files.  However, I suspect they won’t 
> ACK it until you ACK the actual serial port driver.

It goes the other way around :)

Re: [PATCH v4 1/3] tty: serial: Add UART driver for Cortina-Access platform

[Alex Nemirovsky]

Does the serial driver portion in the first patch, require any more changes from your point of view
as the serial driver maintainer?  If there are no issues with the driver itself, we can engage with the DT team to figure out why they have not 
ACK or provided any feedback on the DT portion.   Are you good with the content of the serial driver itself minus the lack of ACK from the DT team?

> On Jun 15, 2021, at 7:13 AM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> 
> On Tue, Jun 15, 2021 at 01:32:51PM +0000, Alex Nemirovsky wrote:
>> The DT maintainers were CC’ed for the DT related files.  However, I suspect they won’t 
>> ACK it until you ACK the actual serial port driver.
> 
> It goes the other way around :)

Re: [PATCH v4 1/3] tty: serial: Add UART driver for Cortina-Access platform

[Greg Kroah-Hartman]

A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Tue, Jun 15, 2021 at 02:33:57PM +0000, Alex Nemirovsky wrote:
> Does the serial driver portion in the first patch, require any more changes from your point of view
> as the serial driver maintainer?  If there are no issues with the driver itself, we can engage with the DT team to figure out why they have not 
> ACK or provided any feedback on the DT portion.   Are you good with the content of the serial driver itself minus the lack of ACK from the DT team?

I was waiting for the DT review before I looked at the serial driver
again.

thanks,

greg k-h

Re: [PATCH v4 1/3] tty: serial: Add UART driver for Cortina-Access platform

[Alex Nemirovsky]

> On Jun 15, 2021, at 8:40 AM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> 
> A: http://en.wikipedia.org/wiki/Top_post
> Q: Were do I find info about this thing called top-posting?
> A: Because it messes up the order in which people normally read text.
> Q: Why is top-posting such a bad thing?
> A: Top-posting.
> Q: What is the most annoying thing in e-mail?
> 
> A: No.
> Q: Should I include quotations after my reply?
> 
> http://daringfireball.net/2007/07/on_top
> 
> On Tue, Jun 15, 2021 at 02:33:57PM +0000, Alex Nemirovsky wrote:
>> Does the serial driver portion in the first patch, require any more changes from your point of view
>> as the serial driver maintainer?  If there are no issues with the driver itself, we can engage with the DT team to figure out why they have not 
>> ACK or provided any feedback on the DT portion.   Are you good with the content of the serial driver itself minus the lack of ACK from the DT team?
> 
> I was waiting for the DT review before I looked at the serial driver
> again.
> 
> thanks,
> 
> greg k-h

Seems like we might be in a catch-22 situation here.  This patch series has been in review around 6 months no and I have yet to see any feedback from the DT team.
Do you ever reach out to them to try to get closer?  If you have had luck, perhaps you can send a quick email to them to get this driver off your plate. I’m sure you
would rather have this resolved on off your queue so you can have more time for other more important matters.

Re: [PATCH v4 2/3] dt-bindings: serial: Convert Cortina-Access UART to json-schema

[Greg Kroah-Hartman]

On Sun, May 09, 2021 at 11:45:17AM -0700, Alex Nemirovsky wrote:
> From: Jason Li <jason.li@cortina-access.com>
> 
> Convert the Cortina-Access UART binding to DT schema format.
> 
> Signed-off-by: Jason Li <jason.li@cortina-access.com>
> ---
>  .../serial/cortina-access,serial.yaml         | 46 +++++++++++++++++++
>  .../devicetree/bindings/vendor-prefixes.yaml  |  2 +
>  MAINTAINERS                                   |  6 +++

You are also adding a MAINTAINERS entry here, which is not listed in the
changelog text, so I couldn't take it anyway :(

greg k-h

Re: [PATCH v4 2/3] dt-bindings: serial: Convert Cortina-Access UART to json-schema

[Alex Nemirovsky]

MAINTAINERS modification was made in the initial version 1.  We made no changes to it since then,
thus not sure what we could at to  Changelog which would add value or clarity for others
from the v1.

> On Jun 15, 2021, at 4:53 AM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> 
> On Sun, May 09, 2021 at 11:45:17AM -0700, Alex Nemirovsky wrote:
>> From: Jason Li <jason.li@cortina-access.com>
>> 
>> Convert the Cortina-Access UART binding to DT schema format.
>> 
>> Signed-off-by: Jason Li <jason.li@cortina-access.com>
>> ---
>> .../serial/cortina-access,serial.yaml         | 46 +++++++++++++++++++
>> .../devicetree/bindings/vendor-prefixes.yaml  |  2 +
>> MAINTAINERS                                   |  6 +++
> 
> You are also adding a MAINTAINERS entry here, which is not listed in the
> changelog text, so I couldn't take it anyway :(
> 
> greg k-h

Re: [PATCH v4 2/3] dt-bindings: serial: Convert Cortina-Access UART to json-schema

[Greg Kroah-Hartman]

On Tue, Jun 15, 2021 at 01:36:39PM +0000, Alex Nemirovsky wrote:
> MAINTAINERS modification was made in the initial version 1.  We made no changes to it since then,
> thus not sure what we could at to  Changelog which would add value or clarity for others
> from the v1.
> 
> > On Jun 15, 2021, at 4:53 AM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> > 
> > On Sun, May 09, 2021 at 11:45:17AM -0700, Alex Nemirovsky wrote:
> >> From: Jason Li <jason.li@cortina-access.com>
> >> 
> >> Convert the Cortina-Access UART binding to DT schema format.
> >> 
> >> Signed-off-by: Jason Li <jason.li@cortina-access.com>
> >> ---
> >> .../serial/cortina-access,serial.yaml         | 46 +++++++++++++++++++
> >> .../devicetree/bindings/vendor-prefixes.yaml  |  2 +
> >> MAINTAINERS                                   |  6 +++
> > 
> > You are also adding a MAINTAINERS entry here, which is not listed in the
> > changelog text, so I couldn't take it anyway :(

Add the maintainers entry in the first patch, with the driver please.

Re: [PATCH v4 2/3] dt-bindings: serial: Convert Cortina-Access UART to json-schema

[Alex Nemirovsky]

> On Jun 15, 2021, at 7:13 AM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> 
> On Tue, Jun 15, 2021 at 01:36:39PM +0000, Alex Nemirovsky wrote:
>> MAINTAINERS modification was made in the initial version 1.  We made no changes to it since then,
>> thus not sure what we could at to  Changelog which would add value or clarity for others
>> from the v1.
>> 
>>> On Jun 15, 2021, at 4:53 AM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
>>> 
>>> On Sun, May 09, 2021 at 11:45:17AM -0700, Alex Nemirovsky wrote:
>>>> From: Jason Li <jason.li@cortina-access.com>
>>>> 
>>>> Convert the Cortina-Access UART binding to DT schema format.
>>>> 
>>>> Signed-off-by: Jason Li <jason.li@cortina-access.com>
>>>> ---
>>>> .../serial/cortina-access,serial.yaml         | 46 +++++++++++++++++++
>>>> .../devicetree/bindings/vendor-prefixes.yaml  |  2 +
>>>> MAINTAINERS                                   |  6 +++
>>> 
>>> You are also adding a MAINTAINERS entry here, which is not listed in the
>>> changelog text, so I couldn't take it anyway :(
> 
> Add the maintainers entry in the first patch, with the driver please.

The change to MAINTAINERS here add a new file into the DT documentation. 
Should it not be grouped into the dt-binding portion and reviewed by the DT time for which this patch
is CC’ed to? Why would moving the DT documentation file that is introduced be into the first patch, which is the 
serial driver itself be the correct approach?

Re: [PATCH v4 2/3] dt-bindings: serial: Convert Cortina-Access UART to json-schema

[Greg Kroah-Hartman]

On Tue, Jun 15, 2021 at 02:39:08PM +0000, Alex Nemirovsky wrote:
> 
> 
> > On Jun 15, 2021, at 7:13 AM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> > 
> > On Tue, Jun 15, 2021 at 01:36:39PM +0000, Alex Nemirovsky wrote:
> >> MAINTAINERS modification was made in the initial version 1.  We made no changes to it since then,
> >> thus not sure what we could at to  Changelog which would add value or clarity for others
> >> from the v1.
> >> 
> >>> On Jun 15, 2021, at 4:53 AM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> >>> 
> >>> On Sun, May 09, 2021 at 11:45:17AM -0700, Alex Nemirovsky wrote:
> >>>> From: Jason Li <jason.li@cortina-access.com>
> >>>> 
> >>>> Convert the Cortina-Access UART binding to DT schema format.
> >>>> 
> >>>> Signed-off-by: Jason Li <jason.li@cortina-access.com>
> >>>> ---
> >>>> .../serial/cortina-access,serial.yaml         | 46 +++++++++++++++++++
> >>>> .../devicetree/bindings/vendor-prefixes.yaml  |  2 +
> >>>> MAINTAINERS                                   |  6 +++
> >>> 
> >>> You are also adding a MAINTAINERS entry here, which is not listed in the
> >>> changelog text, so I couldn't take it anyway :(
> > 
> > Add the maintainers entry in the first patch, with the driver please.
> 
> The change to MAINTAINERS here add a new file into the DT documentation. 
> Should it not be grouped into the dt-binding portion and reviewed by the DT time for which this patch
> is CC’ed to? Why would moving the DT documentation file that is introduced be into the first patch, which is the 
> serial driver itself be the correct approach?

Add it as a stand-alone patch at the end of the series, that just adds
the MAINTAINERS entry.

thanks,

greg k-h

Re: [PATCH v4 2/3] dt-bindings: serial: Convert Cortina-Access UART to json-schema

[Rob Herring]

On Tue, Jun 15, 2021 at 8:39 AM Alex Nemirovsky
<Alex.Nemirovsky@cortina-access.com> wrote:
>
>
>
> > On Jun 15, 2021, at 7:13 AM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> >
> > On Tue, Jun 15, 2021 at 01:36:39PM +0000, Alex Nemirovsky wrote:
> >> MAINTAINERS modification was made in the initial version 1.  We made no changes to it since then,
> >> thus not sure what we could at to  Changelog which would add value or clarity for others
> >> from the v1.
> >>
> >>> On Jun 15, 2021, at 4:53 AM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> >>>
> >>> On Sun, May 09, 2021 at 11:45:17AM -0700, Alex Nemirovsky wrote:
> >>>> From: Jason Li <jason.li@cortina-access.com>
> >>>>
> >>>> Convert the Cortina-Access UART binding to DT schema format.
> >>>>
> >>>> Signed-off-by: Jason Li <jason.li@cortina-access.com>
> >>>> ---
> >>>> .../serial/cortina-access,serial.yaml         | 46 +++++++++++++++++++
> >>>> .../devicetree/bindings/vendor-prefixes.yaml  |  2 +
> >>>> MAINTAINERS                                   |  6 +++
> >>>
> >>> You are also adding a MAINTAINERS entry here, which is not listed in the
> >>> changelog text, so I couldn't take it anyway :(
> >
> > Add the maintainers entry in the first patch, with the driver please.
>
> The change to MAINTAINERS here add a new file into the DT documentation.
> Should it not be grouped into the dt-binding portion and reviewed by the DT time for which this patch
> is CC’ed to? Why would moving the DT documentation file that is introduced be into the first patch, which is the
> serial driver itself be the correct approach?

The binding doesn't actually need a MAINTAINERS entry (though having
one is fine). get_maintainers.pl will also pull emails from the
binding schema.

Rob

Re: [PATCH v4 2/3] dt-bindings: serial: Convert Cortina-Access UART to json-schema

[Alex Nemirovsky]

> On Jun 15, 2021, at 8:44 AM, Rob Herring <robh+dt@kernel.org> wrote:
> 
> On Tue, Jun 15, 2021 at 8:39 AM Alex Nemirovsky
> <Alex.Nemirovsky@cortina-access.com> wrote:
>> 
>> 
>> 
>>> On Jun 15, 2021, at 7:13 AM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
>>> 
>>> On Tue, Jun 15, 2021 at 01:36:39PM +0000, Alex Nemirovsky wrote:
>>>> MAINTAINERS modification was made in the initial version 1.  We made no changes to it since then,
>>>> thus not sure what we could at to  Changelog which would add value or clarity for others
>>>> from the v1.
>>>> 
>>>>> On Jun 15, 2021, at 4:53 AM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
>>>>> 
>>>>> On Sun, May 09, 2021 at 11:45:17AM -0700, Alex Nemirovsky wrote:
>>>>>> From: Jason Li <jason.li@cortina-access.com>
>>>>>> 
>>>>>> Convert the Cortina-Access UART binding to DT schema format.
>>>>>> 
>>>>>> Signed-off-by: Jason Li <jason.li@cortina-access.com>
>>>>>> ---
>>>>>> .../serial/cortina-access,serial.yaml         | 46 +++++++++++++++++++
>>>>>> .../devicetree/bindings/vendor-prefixes.yaml  |  2 +
>>>>>> MAINTAINERS                                   |  6 +++
>>>>> 
>>>>> You are also adding a MAINTAINERS entry here, which is not listed in the
>>>>> changelog text, so I couldn't take it anyway :(
>>> 
>>> Add the maintainers entry in the first patch, with the driver please.
>> 
>> The change to MAINTAINERS here add a new file into the DT documentation.
>> Should it not be grouped into the dt-binding portion and reviewed by the DT time for which this patch
>> is CC’ed to? Why would moving the DT documentation file that is introduced be into the first patch, which is the
>> serial driver itself be the correct approach?
> 
> The binding doesn't actually need a MAINTAINERS entry (though having
> one is fine). get_maintainers.pl will also pull emails from the
> binding schema.
> 
> Rob

Hi Rob,
It sounds like you are find with patch 2/3 from a DT point of view.  Could we review the rest from the DT point of view
to get either feedback for changes or ACK these, so we can unblock this series?  
Thanks
Alex

Re: [PATCH v4 2/3] dt-bindings: serial: Convert Cortina-Access UART to json-schema

[Rob Herring]

On Tue, Jun 15, 2021 at 10:06 AM Alex Nemirovsky
<Alex.Nemirovsky@cortina-access.com> wrote:
>
>
>
> > On Jun 15, 2021, at 8:44 AM, Rob Herring <robh+dt@kernel.org> wrote:
> >
> > On Tue, Jun 15, 2021 at 8:39 AM Alex Nemirovsky
> > <Alex.Nemirovsky@cortina-access.com> wrote:
> >>
> >>
> >>
> >>> On Jun 15, 2021, at 7:13 AM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> >>>
> >>> On Tue, Jun 15, 2021 at 01:36:39PM +0000, Alex Nemirovsky wrote:
> >>>> MAINTAINERS modification was made in the initial version 1.  We made no changes to it since then,
> >>>> thus not sure what we could at to  Changelog which would add value or clarity for others
> >>>> from the v1.
> >>>>
> >>>>> On Jun 15, 2021, at 4:53 AM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> >>>>>
> >>>>> On Sun, May 09, 2021 at 11:45:17AM -0700, Alex Nemirovsky wrote:
> >>>>>> From: Jason Li <jason.li@cortina-access.com>
> >>>>>>
> >>>>>> Convert the Cortina-Access UART binding to DT schema format.
> >>>>>>
> >>>>>> Signed-off-by: Jason Li <jason.li@cortina-access.com>
> >>>>>> ---
> >>>>>> .../serial/cortina-access,serial.yaml         | 46 +++++++++++++++++++
> >>>>>> .../devicetree/bindings/vendor-prefixes.yaml  |  2 +
> >>>>>> MAINTAINERS                                   |  6 +++
> >>>>>
> >>>>> You are also adding a MAINTAINERS entry here, which is not listed in the
> >>>>> changelog text, so I couldn't take it anyway :(
> >>>
> >>> Add the maintainers entry in the first patch, with the driver please.
> >>
> >> The change to MAINTAINERS here add a new file into the DT documentation.
> >> Should it not be grouped into the dt-binding portion and reviewed by the DT time for which this patch
> >> is CC’ed to? Why would moving the DT documentation file that is introduced be into the first patch, which is the
> >> serial driver itself be the correct approach?
> >
> > The binding doesn't actually need a MAINTAINERS entry (though having
> > one is fine). get_maintainers.pl will also pull emails from the
> > binding schema.
> >
> > Rob
>
> Hi Rob,
> It sounds like you are find with patch 2/3 from a DT point of view.  Could we review the rest from the DT point of view
> to get either feedback for changes or ACK these, so we can unblock this series?

Can't say I've seen it as I only see replies in my mail. Did this
originally go to the DT list? If not, it's never in my queue[1].

Rob

[1] https://patchwork.ozlabs.org/project/devicetree-bindings/list/

Re: [PATCH v4 2/3] dt-bindings: serial: Convert Cortina-Access UART to json-schema

[Geert Uytterhoeven]

On Tue, Jun 15, 2021 at 6:21 PM Rob Herring <robh+dt@kernel.org> wrote:
> On Tue, Jun 15, 2021 at 10:06 AM Alex Nemirovsky
> <Alex.Nemirovsky@cortina-access.com> wrote:
> > > On Jun 15, 2021, at 8:44 AM, Rob Herring <robh+dt@kernel.org> wrote:
> > > On Tue, Jun 15, 2021 at 8:39 AM Alex Nemirovsky
> > > <Alex.Nemirovsky@cortina-access.com> wrote:
> > >>
> > >>
> > >>
> > >>> On Jun 15, 2021, at 7:13 AM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> > >>>
> > >>> On Tue, Jun 15, 2021 at 01:36:39PM +0000, Alex Nemirovsky wrote:
> > >>>> MAINTAINERS modification was made in the initial version 1.  We made no changes to it since then,
> > >>>> thus not sure what we could at to  Changelog which would add value or clarity for others
> > >>>> from the v1.
> > >>>>
> > >>>>> On Jun 15, 2021, at 4:53 AM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> > >>>>>
> > >>>>> On Sun, May 09, 2021 at 11:45:17AM -0700, Alex Nemirovsky wrote:
> > >>>>>> From: Jason Li <jason.li@cortina-access.com>
> > >>>>>>
> > >>>>>> Convert the Cortina-Access UART binding to DT schema format.
> > >>>>>>
> > >>>>>> Signed-off-by: Jason Li <jason.li@cortina-access.com>
> > >>>>>> ---
> > >>>>>> .../serial/cortina-access,serial.yaml         | 46 +++++++++++++++++++
> > >>>>>> .../devicetree/bindings/vendor-prefixes.yaml  |  2 +
> > >>>>>> MAINTAINERS                                   |  6 +++
> > >>>>>
> > >>>>> You are also adding a MAINTAINERS entry here, which is not listed in the
> > >>>>> changelog text, so I couldn't take it anyway :(
> > >>>
> > >>> Add the maintainers entry in the first patch, with the driver please.
> > >>
> > >> The change to MAINTAINERS here add a new file into the DT documentation.
> > >> Should it not be grouped into the dt-binding portion and reviewed by the DT time for which this patch
> > >> is CC’ed to? Why would moving the DT documentation file that is introduced be into the first patch, which is the
> > >> serial driver itself be the correct approach?
> > >
> > > The binding doesn't actually need a MAINTAINERS entry (though having
> > > one is fine). get_maintainers.pl will also pull emails from the
> > > binding schema.
> > >
> > > Rob
> >
> > Hi Rob,
> > It sounds like you are find with patch 2/3 from a DT point of view.  Could we review the rest from the DT point of view
> > to get either feedback for changes or ACK these, so we can unblock this series?
>
> Can't say I've seen it as I only see replies in my mail. Did this
> originally go to the DT list? If not, it's never in my queue[1].
>
> Rob
>
> [1] https://patchwork.ozlabs.org/project/devicetree-bindings/list/

None of the patches in this series ended up on a mailing list or on
lore, so no one could comment on them, except for people CCed directly.

The driver has been accepted in tty-next, commit b61c8bf4694b5115
("tty: serial: Add UART driver for Cortina-Access platform").  From a
quick glance, it could have used some review.

The driver is using the compatible value "cortina-access,serial", so I
guess the binding patch added "cortina-access" to vendor-prefixes.yaml.
According to https://www.cortina-access.com/news-and-events, this is
the same company as Cortina Systems, which already has the "cortina"
vendor prefix.  In 2015, it was acquired by Realtek, so perhaps it
should use the "realtek" prefix instead for new development?

The SERIAL_CORTINA_ACCESS symbol doesn't depend on anything, so
it will show up on everyone's oldconfig radar soon, regardless of
building a kernel for a Cortina Access system or not.
I wanted to change it to something like:

     config SERIAL_CORTINA_ACCESS
            tristate "Cortina-Access serial port support"
    +       depends on FIXME || COMPILE_TEST
            select SERIAL_CORE
            help
              This driver is for Cortina-Access SoC's UART. If you
have a machine
              based on the Cortina-Access SoC and wish to use the serial port,
              say 'Y' here. Otherwise, say 'N'.

but given there is no evidence of patches to add support for the
CAXXXX line of SoCs, there's no symbol to depend on...

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v4 2/3] dt-bindings: serial: Convert Cortina-Access UART to json-schema

[Alex Nemirovsky]

This is NOT the same company as Cortina Systems and is NOT Realtek.  It’s is it’s own entity and does not have the right to use the Cortina Systems name with is owned by a different company. 

> On Jun 22, 2021, at 4:28 AM, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> 
> On Tue, Jun 15, 2021 at 6:21 PM Rob Herring <robh+dt@kernel.org> wrote:
>> On Tue, Jun 15, 2021 at 10:06 AM Alex Nemirovsky
>> <Alex.Nemirovsky@cortina-access.com> wrote:
>>>> On Jun 15, 2021, at 8:44 AM, Rob Herring <robh+dt@kernel.org> wrote:
>>>> On Tue, Jun 15, 2021 at 8:39 AM Alex Nemirovsky
>>>> <Alex.Nemirovsky@cortina-access.com> wrote:
>>>>> 
>>>>> 
>>>>> 
>>>>>> On Jun 15, 2021, at 7:13 AM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
>>>>>> 
>>>>>> On Tue, Jun 15, 2021 at 01:36:39PM +0000, Alex Nemirovsky wrote:
>>>>>>> MAINTAINERS modification was made in the initial version 1.  We made no changes to it since then,
>>>>>>> thus not sure what we could at to  Changelog which would add value or clarity for others
>>>>>>> from the v1.
>>>>>>> 
>>>>>>>> On Jun 15, 2021, at 4:53 AM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
>>>>>>>> 
>>>>>>>>> On Sun, May 09, 2021 at 11:45:17AM -0700, Alex Nemirovsky wrote:
>>>>>>>>>> From: Jason Li <jason.li@cortina-access.com>
>>>>>>>>>> 
>>>>>>>>>> Convert the Cortina-Access UART binding to DT schema format.
>>>>>>>>>> 
>>>>>>>>>> Signed-off-by: Jason Li <jason.li@cortina-access.com>
>>>>>>>>>> ---
>>>>>>>>>> .../serial/cortina-access,serial.yaml         | 46 +++++++++++++++++++
>>>>>>>>>> .../devicetree/bindings/vendor-prefixes.yaml  |  2 +
>>>>>>>>>> MAINTAINERS                                   |  6 +++
>>>>>>>>> 
>>>>>>>>> You are also adding a MAINTAINERS entry here, which is not listed in the
>>>>>>>>> changelog text, so I couldn't take it anyway :(
>>>>>>> 
>>>>>>> Add the maintainers entry in the first patch, with the driver please.
>>>>>> 
>>>>>> The change to MAINTAINERS here add a new file into the DT documentation.
>>>>>> Should it not be grouped into the dt-binding portion and reviewed by the DT time for which this patch
>>>>>> is CC’ed to? Why would moving the DT documentation file that is introduced be into the first patch, which is the
>>>>>> serial driver itself be the correct approach?
>>>>> 
>>>>> The binding doesn't actually need a MAINTAINERS entry (though having
>>>>> one is fine). get_maintainers.pl will also pull emails from the
>>>>> binding schema.
>>>>> 
>>>>> Rob
>>> 
>>> Hi Rob,
>>> It sounds like you are find with patch 2/3 from a DT point of view.  Could we review the rest from the DT point of view
>>> to get either feedback for changes or ACK these, so we can unblock this series?
>> 
>> Can't say I've seen it as I only see replies in my mail. Did this
>> originally go to the DT list? If not, it's never in my queue[1].
>> 
>> Rob
>> 
>> [1] https://patchwork.ozlabs.org/project/devicetree-bindings/list/
> 
> None of the patches in this series ended up on a mailing list or on
> lore, so no one could comment on them, except for people CCed directly.
> 
> The driver has been accepted in tty-next, commit b61c8bf4694b5115
> ("tty: serial: Add UART driver for Cortina-Access platform").  From a
> quick glance, it could have used some review.
> 
> The driver is using the compatible value "cortina-access,serial", so I
> guess the binding patch added "cortina-access" to vendor-prefixes.yaml.
> According to https://www.cortina-access.com/news-and-events, this is
> the same company as Cortina Systems, which already has the "cortina"
> vendor prefix.  In 2015, it was acquired by Realtek, so perhaps it
> should use the "realtek" prefix instead for new development?
> 
> The SERIAL_CORTINA_ACCESS symbol doesn't depend on anything, so
> it will show up on everyone's oldconfig radar soon, regardless of
> building a kernel for a Cortina Access system or not.
> I wanted to change it to something like:
> 
>     config SERIAL_CORTINA_ACCESS
>            tristate "Cortina-Access serial port support"
>    +       depends on FIXME || COMPILE_TEST
>            select SERIAL_CORE
>            help
>              This driver is for Cortina-Access SoC's UART. If you
> have a machine
>              based on the Cortina-Access SoC and wish to use the serial port,
>              say 'Y' here. Otherwise, say 'N'.
> 
> but given there is no evidence of patches to add support for the
> CAXXXX line of SoCs, there's no symbol to depend on...
> 
> Gr{oetje,eeting}s,
> 
>                        Geert
> 
> -- 
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                -- Linus Torvalds

Re: [PATCH v4 2/3] dt-bindings: serial: Convert Cortina-Access UART to json-schema

[Arnd Bergmann]

On Tue, Jun 22, 2021 at 1:29 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> On Tue, Jun 15, 2021 at 6:21 PM Rob Herring <robh+dt@kernel.org> wrote:
> > On Tue, Jun 15, 2021 at 10:06 AM Alex Nemirovsky <Alex.Nemirovsky@cortina-access.com> wrote:
> > > It sounds like you are find with patch 2/3 from a DT point of view.  Could we review the rest from the DT point of view
> > > to get either feedback for changes or ACK these, so we can unblock this series?
> >
> > Can't say I've seen it as I only see replies in my mail. Did this
> > originally go to the DT list? If not, it's never in my queue[1].
>
> None of the patches in this series ended up on a mailing list or on
> lore, so no one could comment on them, except for people CCed directly.

Right, in fact every email I see from @cortina-access.com at
https://lore.kernel.org/lkml/?q=cortina-access.com is a reply, but the
original mails are all missing, not just this series.

It appears that there is a problem between the mail servers of cortina-access
and kernel.org. Alex and Jason, please double-check if you find
anything in

https://www.kernel.org/doc/html/latest/process/submitting-patches.html
https://www.kernel.org/doc/html/latest/process/email-clients.html

that may have caused this on your end, or otherwise contact
postmaster@vger.kernel.org for help.

> The driver has been accepted in tty-next, commit b61c8bf4694b5115
> ("tty: serial: Add UART driver for Cortina-Access platform").  From a
> quick glance, it could have used some review.
>
> The driver is using the compatible value "cortina-access,serial", so I
> guess the binding patch added "cortina-access" to vendor-prefixes.yaml.

Ah right. That patch has not made it in because of the issue, but right
away I can tell that the binding is not great because the compatible
string is way too generic: it implies that cortina-access only uses a single
serial port type in every past, present or future SoC, which is clearly
not the case.

It's obviously up to Greg to decide whether to revert the patch, but
I'd suggest we don't treat the driver as conforming to the binding until
it has been reviewed, and assume that changes will be made.

> The SERIAL_CORTINA_ACCESS symbol doesn't depend on anything, so
> it will show up on everyone's oldconfig radar soon, regardless of
> building a kernel for a Cortina Access system or not.
> I wanted to change it to something like:
>
>      config SERIAL_CORTINA_ACCESS
>             tristate "Cortina-Access serial port support"
>     +       depends on FIXME || COMPILE_TEST
>             select SERIAL_CORE
>             help
>               This driver is for Cortina-Access SoC's UART. If you
> have a machine
>               based on the Cortina-Access SoC and wish to use the serial port,
>               say 'Y' here. Otherwise, say 'N'.
>
> but given there is no evidence of patches to add support for the
> CAXXXX line of SoCs, there's no symbol to depend on...

Assuming this is a SoC based on an Arm CPU core, it's clear that
nothing from cortina-access.com ever made it through the
linux-arm-kernel@lists.infradead.org mailing list either, if anything
was sent at all.

Alex, please try to contact me off-list about merging the full SoC
support, I should be able to help you come up with a plan for
submitting the rest as soon as the email troubles are resolved.

For new Arm based SoC platforms, arch/{arm,arm64} patches
should go through the soc tree and be picked up by Olof (on Cc)
or me. The exact process is not well documented, but please
contact us by email, or on irc://irc.libera.chat/#armlinux if you
have questions.

       Arnd

Re: [PATCH v4 2/3] dt-bindings: serial: Convert Cortina-Access UART to json-schema

[Greg Kroah-Hartman]

On Tue, Jun 22, 2021 at 01:28:06PM +0200, Geert Uytterhoeven wrote:
> On Tue, Jun 15, 2021 at 6:21 PM Rob Herring <robh+dt@kernel.org> wrote:
> > On Tue, Jun 15, 2021 at 10:06 AM Alex Nemirovsky
> > <Alex.Nemirovsky@cortina-access.com> wrote:
> > > > On Jun 15, 2021, at 8:44 AM, Rob Herring <robh+dt@kernel.org> wrote:
> > > > On Tue, Jun 15, 2021 at 8:39 AM Alex Nemirovsky
> > > > <Alex.Nemirovsky@cortina-access.com> wrote:
> > > >>
> > > >>
> > > >>
> > > >>> On Jun 15, 2021, at 7:13 AM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> > > >>>
> > > >>> On Tue, Jun 15, 2021 at 01:36:39PM +0000, Alex Nemirovsky wrote:
> > > >>>> MAINTAINERS modification was made in the initial version 1.  We made no changes to it since then,
> > > >>>> thus not sure what we could at to  Changelog which would add value or clarity for others
> > > >>>> from the v1.
> > > >>>>
> > > >>>>> On Jun 15, 2021, at 4:53 AM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> > > >>>>>
> > > >>>>> On Sun, May 09, 2021 at 11:45:17AM -0700, Alex Nemirovsky wrote:
> > > >>>>>> From: Jason Li <jason.li@cortina-access.com>
> > > >>>>>>
> > > >>>>>> Convert the Cortina-Access UART binding to DT schema format.
> > > >>>>>>
> > > >>>>>> Signed-off-by: Jason Li <jason.li@cortina-access.com>
> > > >>>>>> ---
> > > >>>>>> .../serial/cortina-access,serial.yaml         | 46 +++++++++++++++++++
> > > >>>>>> .../devicetree/bindings/vendor-prefixes.yaml  |  2 +
> > > >>>>>> MAINTAINERS                                   |  6 +++
> > > >>>>>
> > > >>>>> You are also adding a MAINTAINERS entry here, which is not listed in the
> > > >>>>> changelog text, so I couldn't take it anyway :(
> > > >>>
> > > >>> Add the maintainers entry in the first patch, with the driver please.
> > > >>
> > > >> The change to MAINTAINERS here add a new file into the DT documentation.
> > > >> Should it not be grouped into the dt-binding portion and reviewed by the DT time for which this patch
> > > >> is CC’ed to? Why would moving the DT documentation file that is introduced be into the first patch, which is the
> > > >> serial driver itself be the correct approach?
> > > >
> > > > The binding doesn't actually need a MAINTAINERS entry (though having
> > > > one is fine). get_maintainers.pl will also pull emails from the
> > > > binding schema.
> > > >
> > > > Rob
> > >
> > > Hi Rob,
> > > It sounds like you are find with patch 2/3 from a DT point of view.  Could we review the rest from the DT point of view
> > > to get either feedback for changes or ACK these, so we can unblock this series?
> >
> > Can't say I've seen it as I only see replies in my mail. Did this
> > originally go to the DT list? If not, it's never in my queue[1].
> >
> > Rob
> >
> > [1] https://patchwork.ozlabs.org/project/devicetree-bindings/list/
> 
> None of the patches in this series ended up on a mailing list or on
> lore, so no one could comment on them, except for people CCed directly.

Ugh, I never noticed that I as I just applied one patch of the series,
my fault.  I'll go revert them from my tree now...

thanks,

greg k-h