* [PATCH][next] ALSA: bebob: Fix bit flag quirk constants
@ 2021-06-15 14:20 Colin King
2021-06-15 22:39 ` Takashi Sakamoto
2021-06-16 6:53 ` Takashi Iwai
0 siblings, 2 replies; 5+ messages in thread
From: Colin King @ 2021-06-15 14:20 UTC (permalink / raw)
To: Clemens Ladisch, Takashi Sakamoto, Jaroslav Kysela, Takashi Iwai,
alsa-devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The quirking bit-flags are currently set as contiguous integer enum values
and so currently SND_BEBOB_QUIRK_INITIAL_DISCONTINUOUS_DBC is zero and so
he quirking never getting set or tested correctly for this quirk. Fix this
by setting the quirking constants as shifted bit values.
Addresses-Coverity: ("Bitwise-and with zero")
Fixes: 93cd12d6e88a ("ALSA: bebob: code refactoring for model-dependent quirks")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
sound/firewire/bebob/bebob.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/firewire/bebob/bebob.h b/sound/firewire/bebob/bebob.h
index c06579d9380e..4d73ecb30d79 100644
--- a/sound/firewire/bebob/bebob.h
+++ b/sound/firewire/bebob/bebob.h
@@ -76,8 +76,8 @@ struct snd_bebob_spec {
};
enum snd_bebob_quirk {
- SND_BEBOB_QUIRK_INITIAL_DISCONTINUOUS_DBC,
- SND_BEBOB_QUIRK_WRONG_DBC,
+ SND_BEBOB_QUIRK_INITIAL_DISCONTINUOUS_DBC = (1 << 0),
+ SND_BEBOB_QUIRK_WRONG_DBC = (1 << 1),
};
struct snd_bebob {
--
2.31.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH][next] ALSA: bebob: Fix bit flag quirk constants
2021-06-15 14:20 [PATCH][next] ALSA: bebob: Fix bit flag quirk constants Colin King
@ 2021-06-15 22:39 ` Takashi Sakamoto
2021-06-16 6:53 ` Takashi Iwai
1 sibling, 0 replies; 5+ messages in thread
From: Takashi Sakamoto @ 2021-06-15 22:39 UTC (permalink / raw)
To: Colin King
Cc: Clemens Ladisch, Jaroslav Kysela, Takashi Iwai, alsa-devel,
kernel-janitors, linux-kernel
Hi,
On Tue, Jun 15, 2021 at 03:20:48PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The quirking bit-flags are currently set as contiguous integer enum values
> and so currently SND_BEBOB_QUIRK_INITIAL_DISCONTINUOUS_DBC is zero and so
> he quirking never getting set or tested correctly for this quirk. Fix this
> by setting the quirking constants as shifted bit values.
>
> Addresses-Coverity: ("Bitwise-and with zero")
> Fixes: 93cd12d6e88a ("ALSA: bebob: code refactoring for model-dependent quirks")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> sound/firewire/bebob/bebob.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/firewire/bebob/bebob.h b/sound/firewire/bebob/bebob.h
> index c06579d9380e..4d73ecb30d79 100644
> --- a/sound/firewire/bebob/bebob.h
> +++ b/sound/firewire/bebob/bebob.h
> @@ -76,8 +76,8 @@ struct snd_bebob_spec {
> };
>
> enum snd_bebob_quirk {
> - SND_BEBOB_QUIRK_INITIAL_DISCONTINUOUS_DBC,
> - SND_BEBOB_QUIRK_WRONG_DBC,
> + SND_BEBOB_QUIRK_INITIAL_DISCONTINUOUS_DBC = (1 << 0),
> + SND_BEBOB_QUIRK_WRONG_DBC = (1 << 1),
> };
>
> struct snd_bebob {
> --
> 2.31.1
Nice to catch it. Indeed, I overlook it...
Acked-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Thanks
Takashi Sakamoto
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH][next] ALSA: bebob: Fix bit flag quirk constants
@ 2021-06-15 22:39 ` Takashi Sakamoto
0 siblings, 0 replies; 5+ messages in thread
From: Takashi Sakamoto @ 2021-06-15 22:39 UTC (permalink / raw)
To: Colin King
Cc: alsa-devel, Clemens Ladisch, kernel-janitors, Takashi Iwai, linux-kernel
Hi,
On Tue, Jun 15, 2021 at 03:20:48PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The quirking bit-flags are currently set as contiguous integer enum values
> and so currently SND_BEBOB_QUIRK_INITIAL_DISCONTINUOUS_DBC is zero and so
> he quirking never getting set or tested correctly for this quirk. Fix this
> by setting the quirking constants as shifted bit values.
>
> Addresses-Coverity: ("Bitwise-and with zero")
> Fixes: 93cd12d6e88a ("ALSA: bebob: code refactoring for model-dependent quirks")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> sound/firewire/bebob/bebob.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/firewire/bebob/bebob.h b/sound/firewire/bebob/bebob.h
> index c06579d9380e..4d73ecb30d79 100644
> --- a/sound/firewire/bebob/bebob.h
> +++ b/sound/firewire/bebob/bebob.h
> @@ -76,8 +76,8 @@ struct snd_bebob_spec {
> };
>
> enum snd_bebob_quirk {
> - SND_BEBOB_QUIRK_INITIAL_DISCONTINUOUS_DBC,
> - SND_BEBOB_QUIRK_WRONG_DBC,
> + SND_BEBOB_QUIRK_INITIAL_DISCONTINUOUS_DBC = (1 << 0),
> + SND_BEBOB_QUIRK_WRONG_DBC = (1 << 1),
> };
>
> struct snd_bebob {
> --
> 2.31.1
Nice to catch it. Indeed, I overlook it...
Acked-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Thanks
Takashi Sakamoto
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH][next] ALSA: bebob: Fix bit flag quirk constants
2021-06-15 14:20 [PATCH][next] ALSA: bebob: Fix bit flag quirk constants Colin King
@ 2021-06-16 6:53 ` Takashi Iwai
2021-06-16 6:53 ` Takashi Iwai
1 sibling, 0 replies; 5+ messages in thread
From: Takashi Iwai @ 2021-06-16 6:53 UTC (permalink / raw)
To: Colin King
Cc: Clemens Ladisch, Takashi Sakamoto, Jaroslav Kysela, Takashi Iwai,
alsa-devel, kernel-janitors, linux-kernel
On Tue, 15 Jun 2021 16:20:48 +0200,
Colin King wrote:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> The quirking bit-flags are currently set as contiguous integer enum values
> and so currently SND_BEBOB_QUIRK_INITIAL_DISCONTINUOUS_DBC is zero and so
> he quirking never getting set or tested correctly for this quirk. Fix this
> by setting the quirking constants as shifted bit values.
>
> Addresses-Coverity: ("Bitwise-and with zero")
> Fixes: 93cd12d6e88a ("ALSA: bebob: code refactoring for model-dependent quirks")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Thanks, applied.
Takashi
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH][next] ALSA: bebob: Fix bit flag quirk constants
@ 2021-06-16 6:53 ` Takashi Iwai
0 siblings, 0 replies; 5+ messages in thread
From: Takashi Iwai @ 2021-06-16 6:53 UTC (permalink / raw)
To: Colin King
Cc: alsa-devel, Clemens Ladisch, kernel-janitors, Takashi Iwai, linux-kernel
On Tue, 15 Jun 2021 16:20:48 +0200,
Colin King wrote:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> The quirking bit-flags are currently set as contiguous integer enum values
> and so currently SND_BEBOB_QUIRK_INITIAL_DISCONTINUOUS_DBC is zero and so
> he quirking never getting set or tested correctly for this quirk. Fix this
> by setting the quirking constants as shifted bit values.
>
> Addresses-Coverity: ("Bitwise-and with zero")
> Fixes: 93cd12d6e88a ("ALSA: bebob: code refactoring for model-dependent quirks")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Thanks, applied.
Takashi
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-06-16 6:54 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-15 14:20 [PATCH][next] ALSA: bebob: Fix bit flag quirk constants Colin King
2021-06-15 22:39 ` Takashi Sakamoto
2021-06-15 22:39 ` Takashi Sakamoto
2021-06-16 6:53 ` Takashi Iwai
2021-06-16 6:53 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.