From: Joerg Roedel <joro@8bytes.org> To: Peter Zijlstra <peterz@infradead.org> Cc: x86@kernel.org, Joerg Roedel <jroedel@suse.de>, hpa@zytor.com, Andy Lutomirski <luto@kernel.org>, Dave Hansen <dave.hansen@linux.intel.com>, Jiri Slaby <jslaby@suse.cz>, Dan Williams <dan.j.williams@intel.com>, Tom Lendacky <thomas.lendacky@amd.com>, Juergen Gross <jgross@suse.com>, Kees Cook <keescook@chromium.org>, David Rientjes <rientjes@google.com>, Cfir Cohen <cfir@google.com>, Erdem Aktas <erdemaktas@google.com>, Masami Hiramatsu <mhiramat@kernel.org>, Mike Stunes <mstunes@vmware.com>, Sean Christopherson <seanjc@google.com>, Martin Radev <martin.b.radev@gmail.com>, Arvind Sankar <nivedita@alum.mit.edu>, linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH v5 3/6] x86/sev-es: Split up runtime #VC handler for correct state tracking Date: Wed, 16 Jun 2021 21:01:30 +0200 [thread overview] Message-ID: <YMpKim/3Dc41xvF7@8bytes.org> (raw) In-Reply-To: <YMohCkW/mChNpkqi@hirez.programming.kicks-ass.net> Hi Peter, sorry, missed this email before sending out v6. On Wed, Jun 16, 2021 at 06:04:26PM +0200, Peter Zijlstra wrote: > On Mon, Jun 14, 2021 at 03:53:24PM +0200, Joerg Roedel wrote: > > _ASM_NOKPROBE(\asmsym) > > SYM_CODE_END(\asmsym) > > Consistency with idtentry_mce_db would seem to suggest using \cfunc and > noist_\cfunc. > > amluto, tglx: do we have strong feelings on consistency? Yeah, but this distinction does not make sense here, as none of the #VC handlers C functions run on the actual #VC IST stack. The from-kernel function might run on the fall-back stack (not really possible today unless the hypervisor does something nasty). And the difference between the fall-back stack and the actual IST stack is, that on the fall-back stack nesting #VC exceptions is still supported. > > + vc_handle_trap_db(regs); > > It's a bit sad this does user_mode(regs) again. Okay, I will change this according your comments. Thanks, Joerg
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org> To: Peter Zijlstra <peterz@infradead.org> Cc: kvm@vger.kernel.org, Dave Hansen <dave.hansen@linux.intel.com>, virtualization@lists.linux-foundation.org, Arvind Sankar <nivedita@alum.mit.edu>, hpa@zytor.com, Jiri Slaby <jslaby@suse.cz>, x86@kernel.org, David Rientjes <rientjes@google.com>, Martin Radev <martin.b.radev@gmail.com>, Tom Lendacky <thomas.lendacky@amd.com>, Joerg Roedel <jroedel@suse.de>, Kees Cook <keescook@chromium.org>, Cfir Cohen <cfir@google.com>, linux-coco@lists.linux.dev, Andy Lutomirski <luto@kernel.org>, Dan Williams <dan.j.williams@intel.com>, Juergen Gross <jgross@suse.com>, Mike Stunes <mstunes@vmware.com>, Sean Christopherson <seanjc@google.com>, linux-kernel@vger.kernel.org, Masami Hiramatsu <mhiramat@kernel.org>, Erdem Aktas <erdemaktas@google.com> Subject: Re: [PATCH v5 3/6] x86/sev-es: Split up runtime #VC handler for correct state tracking Date: Wed, 16 Jun 2021 21:01:30 +0200 [thread overview] Message-ID: <YMpKim/3Dc41xvF7@8bytes.org> (raw) In-Reply-To: <YMohCkW/mChNpkqi@hirez.programming.kicks-ass.net> Hi Peter, sorry, missed this email before sending out v6. On Wed, Jun 16, 2021 at 06:04:26PM +0200, Peter Zijlstra wrote: > On Mon, Jun 14, 2021 at 03:53:24PM +0200, Joerg Roedel wrote: > > _ASM_NOKPROBE(\asmsym) > > SYM_CODE_END(\asmsym) > > Consistency with idtentry_mce_db would seem to suggest using \cfunc and > noist_\cfunc. > > amluto, tglx: do we have strong feelings on consistency? Yeah, but this distinction does not make sense here, as none of the #VC handlers C functions run on the actual #VC IST stack. The from-kernel function might run on the fall-back stack (not really possible today unless the hypervisor does something nasty). And the difference between the fall-back stack and the actual IST stack is, that on the fall-back stack nesting #VC exceptions is still supported. > > + vc_handle_trap_db(regs); > > It's a bit sad this does user_mode(regs) again. Okay, I will change this according your comments. Thanks, Joerg _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2021-06-16 19:01 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-14 13:53 [PATCH v5 0/6] x86/sev-es: Fixes for SEV-ES Guest Support Joerg Roedel 2021-06-14 13:53 ` Joerg Roedel 2021-06-14 13:53 ` [PATCH v5 1/6] x86/sev-es: Fix error message in runtime #VC handler Joerg Roedel 2021-06-14 13:53 ` Joerg Roedel 2021-06-15 10:51 ` [tip: x86/sev] x86/sev: " tip-bot2 for Joerg Roedel 2021-06-14 13:53 ` [PATCH v5 2/6] x86/sev-es: Make sure IRQs are disabled while GHCB is active Joerg Roedel 2021-06-14 13:53 ` Joerg Roedel 2021-06-14 16:25 ` Borislav Petkov 2021-06-14 16:25 ` Borislav Petkov 2021-06-14 16:30 ` Borislav Petkov 2021-06-14 16:30 ` Borislav Petkov 2021-06-15 9:37 ` Joerg Roedel 2021-06-15 9:37 ` Joerg Roedel 2021-06-14 13:53 ` [PATCH v5 3/6] x86/sev-es: Split up runtime #VC handler for correct state tracking Joerg Roedel 2021-06-14 13:53 ` Joerg Roedel 2021-06-16 16:04 ` Peter Zijlstra 2021-06-16 16:04 ` Peter Zijlstra 2021-06-16 19:01 ` Joerg Roedel [this message] 2021-06-16 19:01 ` Joerg Roedel 2021-06-14 13:53 ` [PATCH v5 4/6] x86/insn-eval: Make 0 a valid RIP for insn_get_effective_ip() Joerg Roedel 2021-06-14 13:53 ` Joerg Roedel 2021-06-15 10:51 ` [tip: x86/sev] " tip-bot2 for Joerg Roedel 2021-06-14 13:53 ` [PATCH v5 5/6] x86/insn: Extend error reporting from insn_fetch_from_user[_inatomic]() Joerg Roedel 2021-06-14 13:53 ` Joerg Roedel 2021-06-15 10:51 ` [tip: x86/sev] " tip-bot2 for Joerg Roedel 2021-06-14 13:53 ` [PATCH v5 6/6] x86/sev-es: Propagate #GP if getting linear instruction address failed Joerg Roedel 2021-06-14 13:53 ` Joerg Roedel 2021-06-15 10:51 ` [tip: x86/sev] x86/sev: " tip-bot2 for Joerg Roedel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YMpKim/3Dc41xvF7@8bytes.org \ --to=joro@8bytes.org \ --cc=cfir@google.com \ --cc=dan.j.williams@intel.com \ --cc=dave.hansen@linux.intel.com \ --cc=erdemaktas@google.com \ --cc=hpa@zytor.com \ --cc=jgross@suse.com \ --cc=jroedel@suse.de \ --cc=jslaby@suse.cz \ --cc=keescook@chromium.org \ --cc=kvm@vger.kernel.org \ --cc=linux-coco@lists.linux.dev \ --cc=linux-kernel@vger.kernel.org \ --cc=luto@kernel.org \ --cc=martin.b.radev@gmail.com \ --cc=mhiramat@kernel.org \ --cc=mstunes@vmware.com \ --cc=nivedita@alum.mit.edu \ --cc=peterz@infradead.org \ --cc=rientjes@google.com \ --cc=seanjc@google.com \ --cc=thomas.lendacky@amd.com \ --cc=virtualization@lists.linux-foundation.org \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.