* [PATCH] iommu: Update "iommu.strict" documentation
@ 2021-06-14 14:57 ` Robin Murphy
0 siblings, 0 replies; 8+ messages in thread
From: Robin Murphy @ 2021-06-14 14:57 UTC (permalink / raw)
To: joro; +Cc: will, john.garry, iommu, linux-kernel, baolu.lu
Consolidating the flush queue logic also meant that the "iommu.strict"
option started taking effect on x86 as well. Make sure we document that.
Fixes: a250c23f15c2 ("iommu: remove DOMAIN_ATTR_DMA_USE_FLUSH_QUEUE")
Signed-off-by: Robin Murphy <robin.murphy@arm.com>
---
Documentation/admin-guide/kernel-parameters.txt | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
index cb89dbdedc46..20a32de990ed 100644
--- a/Documentation/admin-guide/kernel-parameters.txt
+++ b/Documentation/admin-guide/kernel-parameters.txt
@@ -1987,7 +1987,7 @@
forcing Dual Address Cycle for PCI cards supporting
greater than 32-bit addressing.
- iommu.strict= [ARM64] Configure TLB invalidation behaviour
+ iommu.strict= [ARM64, X86] Configure TLB invalidation behaviour
Format: { "0" | "1" }
0 - Lazy mode.
Request that DMA unmap operations use deferred
@@ -1998,6 +1998,10 @@
1 - Strict mode (default).
DMA unmap operations invalidate IOMMU hardware TLBs
synchronously.
+ Note: on x86, the default behaviour depends on the
+ equivalent driver-specific parameters, but a strict
+ mode explicitly specified by either method takes
+ precedence.
iommu.passthrough=
[ARM64, X86] Configure DMA to bypass the IOMMU by default.
--
2.25.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] iommu: Update "iommu.strict" documentation
@ 2021-06-14 14:57 ` Robin Murphy
0 siblings, 0 replies; 8+ messages in thread
From: Robin Murphy @ 2021-06-14 14:57 UTC (permalink / raw)
To: joro; +Cc: iommu, will, linux-kernel
Consolidating the flush queue logic also meant that the "iommu.strict"
option started taking effect on x86 as well. Make sure we document that.
Fixes: a250c23f15c2 ("iommu: remove DOMAIN_ATTR_DMA_USE_FLUSH_QUEUE")
Signed-off-by: Robin Murphy <robin.murphy@arm.com>
---
Documentation/admin-guide/kernel-parameters.txt | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
index cb89dbdedc46..20a32de990ed 100644
--- a/Documentation/admin-guide/kernel-parameters.txt
+++ b/Documentation/admin-guide/kernel-parameters.txt
@@ -1987,7 +1987,7 @@
forcing Dual Address Cycle for PCI cards supporting
greater than 32-bit addressing.
- iommu.strict= [ARM64] Configure TLB invalidation behaviour
+ iommu.strict= [ARM64, X86] Configure TLB invalidation behaviour
Format: { "0" | "1" }
0 - Lazy mode.
Request that DMA unmap operations use deferred
@@ -1998,6 +1998,10 @@
1 - Strict mode (default).
DMA unmap operations invalidate IOMMU hardware TLBs
synchronously.
+ Note: on x86, the default behaviour depends on the
+ equivalent driver-specific parameters, but a strict
+ mode explicitly specified by either method takes
+ precedence.
iommu.passthrough=
[ARM64, X86] Configure DMA to bypass the IOMMU by default.
--
2.25.1
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] iommu: Update "iommu.strict" documentation
2021-06-14 14:57 ` Robin Murphy
@ 2021-06-14 16:29 ` John Garry
-1 siblings, 0 replies; 8+ messages in thread
From: John Garry @ 2021-06-14 16:29 UTC (permalink / raw)
To: Robin Murphy, joro; +Cc: will, iommu, linux-kernel, baolu.lu
On 14/06/2021 15:57, Robin Murphy wrote:
> Consolidating the flush queue logic also meant that the "iommu.strict"
> option started taking effect on x86 as well. Make sure we document that.
>
> Fixes: a250c23f15c2 ("iommu: remove DOMAIN_ATTR_DMA_USE_FLUSH_QUEUE")
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
I assumed that all bets were off when we use a cmdline param which is
not "officially" supported.
Anyway, FWIW:
Reviewed-by: John Garry <john.garry@huawei.com>
> ---
> Documentation/admin-guide/kernel-parameters.txt | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index cb89dbdedc46..20a32de990ed 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -1987,7 +1987,7 @@
> forcing Dual Address Cycle for PCI cards supporting
> greater than 32-bit addressing.
>
> - iommu.strict= [ARM64] Configure TLB invalidation behaviour
> + iommu.strict= [ARM64, X86] Configure TLB invalidation behaviour
> Format: { "0" | "1" }
> 0 - Lazy mode.
> Request that DMA unmap operations use deferred
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] iommu: Update "iommu.strict" documentation
@ 2021-06-14 16:29 ` John Garry
0 siblings, 0 replies; 8+ messages in thread
From: John Garry @ 2021-06-14 16:29 UTC (permalink / raw)
To: Robin Murphy, joro; +Cc: iommu, will, linux-kernel
On 14/06/2021 15:57, Robin Murphy wrote:
> Consolidating the flush queue logic also meant that the "iommu.strict"
> option started taking effect on x86 as well. Make sure we document that.
>
> Fixes: a250c23f15c2 ("iommu: remove DOMAIN_ATTR_DMA_USE_FLUSH_QUEUE")
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
I assumed that all bets were off when we use a cmdline param which is
not "officially" supported.
Anyway, FWIW:
Reviewed-by: John Garry <john.garry@huawei.com>
> ---
> Documentation/admin-guide/kernel-parameters.txt | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index cb89dbdedc46..20a32de990ed 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -1987,7 +1987,7 @@
> forcing Dual Address Cycle for PCI cards supporting
> greater than 32-bit addressing.
>
> - iommu.strict= [ARM64] Configure TLB invalidation behaviour
> + iommu.strict= [ARM64, X86] Configure TLB invalidation behaviour
> Format: { "0" | "1" }
> 0 - Lazy mode.
> Request that DMA unmap operations use deferred
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] iommu: Update "iommu.strict" documentation
2021-06-14 14:57 ` Robin Murphy
@ 2021-06-15 7:05 ` Lu Baolu
-1 siblings, 0 replies; 8+ messages in thread
From: Lu Baolu @ 2021-06-15 7:05 UTC (permalink / raw)
To: Robin Murphy, joro; +Cc: baolu.lu, will, john.garry, iommu, linux-kernel
On 6/14/21 10:57 PM, Robin Murphy wrote:
> Consolidating the flush queue logic also meant that the "iommu.strict"
> option started taking effect on x86 as well. Make sure we document that.
>
> Fixes: a250c23f15c2 ("iommu: remove DOMAIN_ATTR_DMA_USE_FLUSH_QUEUE")
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> ---
> Documentation/admin-guide/kernel-parameters.txt | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index cb89dbdedc46..20a32de990ed 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -1987,7 +1987,7 @@
> forcing Dual Address Cycle for PCI cards supporting
> greater than 32-bit addressing.
>
> - iommu.strict= [ARM64] Configure TLB invalidation behaviour
> + iommu.strict= [ARM64, X86] Configure TLB invalidation behaviour
> Format: { "0" | "1" }
> 0 - Lazy mode.
> Request that DMA unmap operations use deferred
> @@ -1998,6 +1998,10 @@
> 1 - Strict mode (default).
> DMA unmap operations invalidate IOMMU hardware TLBs
> synchronously.
> + Note: on x86, the default behaviour depends on the
> + equivalent driver-specific parameters, but a strict
> + mode explicitly specified by either method takes
> + precedence.
>
> iommu.passthrough=
> [ARM64, X86] Configure DMA to bypass the IOMMU by default.
>
Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>
Best regards,
baolu
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] iommu: Update "iommu.strict" documentation
@ 2021-06-15 7:05 ` Lu Baolu
0 siblings, 0 replies; 8+ messages in thread
From: Lu Baolu @ 2021-06-15 7:05 UTC (permalink / raw)
To: Robin Murphy, joro; +Cc: iommu, will, linux-kernel
On 6/14/21 10:57 PM, Robin Murphy wrote:
> Consolidating the flush queue logic also meant that the "iommu.strict"
> option started taking effect on x86 as well. Make sure we document that.
>
> Fixes: a250c23f15c2 ("iommu: remove DOMAIN_ATTR_DMA_USE_FLUSH_QUEUE")
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> ---
> Documentation/admin-guide/kernel-parameters.txt | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index cb89dbdedc46..20a32de990ed 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -1987,7 +1987,7 @@
> forcing Dual Address Cycle for PCI cards supporting
> greater than 32-bit addressing.
>
> - iommu.strict= [ARM64] Configure TLB invalidation behaviour
> + iommu.strict= [ARM64, X86] Configure TLB invalidation behaviour
> Format: { "0" | "1" }
> 0 - Lazy mode.
> Request that DMA unmap operations use deferred
> @@ -1998,6 +1998,10 @@
> 1 - Strict mode (default).
> DMA unmap operations invalidate IOMMU hardware TLBs
> synchronously.
> + Note: on x86, the default behaviour depends on the
> + equivalent driver-specific parameters, but a strict
> + mode explicitly specified by either method takes
> + precedence.
>
> iommu.passthrough=
> [ARM64, X86] Configure DMA to bypass the IOMMU by default.
>
Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>
Best regards,
baolu
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] iommu: Update "iommu.strict" documentation
2021-06-14 14:57 ` Robin Murphy
@ 2021-06-17 15:04 ` Joerg Roedel
-1 siblings, 0 replies; 8+ messages in thread
From: Joerg Roedel @ 2021-06-17 15:04 UTC (permalink / raw)
To: Robin Murphy; +Cc: will, john.garry, iommu, linux-kernel, baolu.lu
On Mon, Jun 14, 2021 at 03:57:26PM +0100, Robin Murphy wrote:
> Consolidating the flush queue logic also meant that the "iommu.strict"
> option started taking effect on x86 as well. Make sure we document that.
>
> Fixes: a250c23f15c2 ("iommu: remove DOMAIN_ATTR_DMA_USE_FLUSH_QUEUE")
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> ---
> Documentation/admin-guide/kernel-parameters.txt | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
Applied, thanks.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] iommu: Update "iommu.strict" documentation
@ 2021-06-17 15:04 ` Joerg Roedel
0 siblings, 0 replies; 8+ messages in thread
From: Joerg Roedel @ 2021-06-17 15:04 UTC (permalink / raw)
To: Robin Murphy; +Cc: iommu, will, linux-kernel
On Mon, Jun 14, 2021 at 03:57:26PM +0100, Robin Murphy wrote:
> Consolidating the flush queue logic also meant that the "iommu.strict"
> option started taking effect on x86 as well. Make sure we document that.
>
> Fixes: a250c23f15c2 ("iommu: remove DOMAIN_ATTR_DMA_USE_FLUSH_QUEUE")
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> ---
> Documentation/admin-guide/kernel-parameters.txt | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
Applied, thanks.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-06-17 15:04 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-14 14:57 [PATCH] iommu: Update "iommu.strict" documentation Robin Murphy
2021-06-14 14:57 ` Robin Murphy
2021-06-14 16:29 ` John Garry
2021-06-14 16:29 ` John Garry
2021-06-15 7:05 ` Lu Baolu
2021-06-15 7:05 ` Lu Baolu
2021-06-17 15:04 ` Joerg Roedel
2021-06-17 15:04 ` Joerg Roedel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.