All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <treding@nvidia.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: kernel test robot <lkp@intel.com>, <kbuild-all@lists.01.org>,
	<clang-built-linux@googlegroups.com>,
	<linux-arm-kernel@lists.infradead.org>,  <arm@kernel.org>
Subject: Re: [soc:tegra/memory 19/20] aarch64-linux-gnu-ld: Unexpected GOT/PLT entries detected!
Date: Fri, 18 Jun 2021 16:57:26 +0200	[thread overview]
Message-ID: <YMy0VgmIff5Nfscc@orome.fritz.box> (raw)
In-Reply-To: <bb8a27bc-5eef-7702-5e3f-1e9fa69f76ec@canonical.com>


[-- Attachment #1.1: Type: text/plain, Size: 2866 bytes --]

On Thu, Jun 17, 2021 at 04:22:56PM +0200, Krzysztof Kozlowski wrote:
> On 17/06/2021 13:54, kernel test robot wrote:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git tegra/memory
> > head:   2c1bc371268862a991a6498e1dddc8971b9076b8
> > commit: 8eb68595475ac5fcaaa3718a173283df48cb4ef1 [19/20] iommu/arm-smmu: tegra: Implement SID override programming
> > config: arm64-randconfig-r016-20210617 (attached as .config)
> > compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 64720f57bea6a6bf033feef4a5751ab9c0c3b401)
> > reproduce (this is a W=1 build):
> >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         # install arm64 cross compiling tool for clang build
> >         # apt-get install binutils-aarch64-linux-gnu
> >         # https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git/commit/?id=8eb68595475ac5fcaaa3718a173283df48cb4ef1
> >         git remote add soc https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git
> >         git fetch --no-tags soc tegra/memory
> >         git checkout 8eb68595475ac5fcaaa3718a173283df48cb4ef1
> >         # save the attached .config to linux build tree
> >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64 
> > 
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> > 
> > All errors (new ones prefixed by >>):
> > 
> >>> aarch64-linux-gnu-ld: Unexpected GOT/PLT entries detected!
> >>> aarch64-linux-gnu-ld: Unexpected run-time procedure linkages detected!
> >    aarch64-linux-gnu-ld: drivers/iommu/arm/arm-smmu/arm-smmu-nvidia.o: in function `nvidia_smmu_probe_finalize':
> >    arm-smmu-nvidia.c:(.text+0xe0): undefined reference to `tegra_mc_probe_device'
> > 
> > ---
> > 0-DAY CI Kernel Test Service, Intel Corporation
> > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
> 
> 
> Hi Thierry,
> 
> Will you take a look at this failure and prepare a follow-up patch? This
> came already from soc tree.

I thought I had sent out a reply earlier, but that doesn't seem to have
made it through.

I sent out a patch earlier that fixes this by adding a stub for
tegra_mc_probe_device() if TEGRA_MC is not set. I think that's a bit
better than adding a dependency on TEGRA_MC from the ARM_SMMU driver
because somebody may want to build the ARM_SMMU driver on non-Tegra
configurations.

Another alternative would've been to add another Kconfig symbol for the
Tegra ARM SMMU implementation, but that would've been more intrusive and
would've prevented the Tegra code from getting broader build coverage.

Let me know what you think about the fix and if you want a different
solution than the stub.

Thierry

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <treding@nvidia.com>
To: kbuild-all@lists.01.org
Subject: Re: [soc:tegra/memory 19/20] aarch64-linux-gnu-ld: Unexpected GOT/PLT entries detected!
Date: Fri, 18 Jun 2021 16:57:26 +0200	[thread overview]
Message-ID: <YMy0VgmIff5Nfscc@orome.fritz.box> (raw)
In-Reply-To: <bb8a27bc-5eef-7702-5e3f-1e9fa69f76ec@canonical.com>

[-- Attachment #1: Type: text/plain, Size: 2868 bytes --]

On Thu, Jun 17, 2021 at 04:22:56PM +0200, Krzysztof Kozlowski wrote:
> On 17/06/2021 13:54, kernel test robot wrote:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git tegra/memory
> > head:   2c1bc371268862a991a6498e1dddc8971b9076b8
> > commit: 8eb68595475ac5fcaaa3718a173283df48cb4ef1 [19/20] iommu/arm-smmu: tegra: Implement SID override programming
> > config: arm64-randconfig-r016-20210617 (attached as .config)
> > compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 64720f57bea6a6bf033feef4a5751ab9c0c3b401)
> > reproduce (this is a W=1 build):
> >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         # install arm64 cross compiling tool for clang build
> >         # apt-get install binutils-aarch64-linux-gnu
> >         # https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git/commit/?id=8eb68595475ac5fcaaa3718a173283df48cb4ef1
> >         git remote add soc https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git
> >         git fetch --no-tags soc tegra/memory
> >         git checkout 8eb68595475ac5fcaaa3718a173283df48cb4ef1
> >         # save the attached .config to linux build tree
> >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64 
> > 
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> > 
> > All errors (new ones prefixed by >>):
> > 
> >>> aarch64-linux-gnu-ld: Unexpected GOT/PLT entries detected!
> >>> aarch64-linux-gnu-ld: Unexpected run-time procedure linkages detected!
> >    aarch64-linux-gnu-ld: drivers/iommu/arm/arm-smmu/arm-smmu-nvidia.o: in function `nvidia_smmu_probe_finalize':
> >    arm-smmu-nvidia.c:(.text+0xe0): undefined reference to `tegra_mc_probe_device'
> > 
> > ---
> > 0-DAY CI Kernel Test Service, Intel Corporation
> > https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
> 
> 
> Hi Thierry,
> 
> Will you take a look at this failure and prepare a follow-up patch? This
> came already from soc tree.

I thought I had sent out a reply earlier, but that doesn't seem to have
made it through.

I sent out a patch earlier that fixes this by adding a stub for
tegra_mc_probe_device() if TEGRA_MC is not set. I think that's a bit
better than adding a dependency on TEGRA_MC from the ARM_SMMU driver
because somebody may want to build the ARM_SMMU driver on non-Tegra
configurations.

Another alternative would've been to add another Kconfig symbol for the
Tegra ARM SMMU implementation, but that would've been more intrusive and
would've prevented the Tegra code from getting broader build coverage.

Let me know what you think about the fix and if you want a different
solution than the stub.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2021-06-18 14:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-17 11:54 [soc:tegra/memory 19/20] aarch64-linux-gnu-ld: Unexpected GOT/PLT entries detected! kernel test robot
2021-06-17 11:54 ` kernel test robot
2021-06-17 14:22 ` Krzysztof Kozlowski
2021-06-17 14:22   ` Krzysztof Kozlowski
2021-06-18 14:57   ` Thierry Reding [this message]
2021-06-18 14:57     ` Thierry Reding
2021-06-18 14:58     ` Krzysztof Kozlowski
2021-06-18 14:58       ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YMy0VgmIff5Nfscc@orome.fritz.box \
    --to=treding@nvidia.com \
    --cc=arm@kernel.org \
    --cc=clang-built-linux@googlegroups.com \
    --cc=kbuild-all@lists.01.org \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=lkp@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.