From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: "Stefan Riedmüller" <S.Riedmueller@phytec.de> Cc: "daniel@ffwll.ch" <daniel@ffwll.ch>, "airlied@linux.ie" <airlied@linux.ie>, "sam@ravnborg.org" <sam@ravnborg.org>, "thierry.reding@gmail.com" <thierry.reding@gmail.com>, "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 1/3] drm/panel: Add connector_type and bus_format for AUO G104SN02 V2 panel Date: Mon, 21 Jun 2021 17:27:21 +0300 [thread overview] Message-ID: <YNChySKddg/JsMZv@pendragon.ideasonboard.com> (raw) In-Reply-To: <5942e9c67f7d50737536613b80a2cb42a3615b3d.camel@phytec.de> Hi Stefan, Thank you for the patch. On Mon, Jun 21, 2021 at 08:22:10AM +0000, Stefan Riedmüller wrote: > Hi, > > another gentle ping. Sorry for the delay, I have way too little bandwidth these days :-S > Also adding Laurent Pinchart to CC. > > On Wed, 2021-05-26 at 07:34 +0000, Stefan Riedmüller wrote: > > On Thu, 2021-04-15 at 11:16 +0200, Stefan Riedmueller wrote: > > > The AUO G104SN02 V2 is an LVDS display which supports 6 and 8 bpc PSWG. > > > Add the corresponding connector type and 8 bpc as default bus_format. > > > > > > Signed-off-by: Stefan Riedmueller <s.riedmueller@phytec.de> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> It will be interesting to add support for the 6bpp mode at some point (I assume through a custom DT property that reports the state of the panel's SEL68 pin, as it should be strapped in most cases). > > > --- > > > drivers/gpu/drm/panel/panel-simple.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/drivers/gpu/drm/panel/panel-simple.c > > > b/drivers/gpu/drm/panel/panel-simple.c > > > index 4e2dad314c79..44583d0ed902 100644 > > > --- a/drivers/gpu/drm/panel/panel-simple.c > > > +++ b/drivers/gpu/drm/panel/panel-simple.c > > > @@ -1098,6 +1098,8 @@ static const struct panel_desc auo_g104sn02 = { > > > .width = 211, > > > .height = 158, > > > }, > > > + .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG, > > > + .connector_type = DRM_MODE_CONNECTOR_LVDS, > > > }; > > > > > > static const struct drm_display_mode auo_g121ean01_mode = { -- Regards, Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: "Stefan Riedmüller" <S.Riedmueller@phytec.de> Cc: "airlied@linux.ie" <airlied@linux.ie>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>, "thierry.reding@gmail.com" <thierry.reding@gmail.com>, "sam@ravnborg.org" <sam@ravnborg.org> Subject: Re: [PATCH 1/3] drm/panel: Add connector_type and bus_format for AUO G104SN02 V2 panel Date: Mon, 21 Jun 2021 17:27:21 +0300 [thread overview] Message-ID: <YNChySKddg/JsMZv@pendragon.ideasonboard.com> (raw) In-Reply-To: <5942e9c67f7d50737536613b80a2cb42a3615b3d.camel@phytec.de> Hi Stefan, Thank you for the patch. On Mon, Jun 21, 2021 at 08:22:10AM +0000, Stefan Riedmüller wrote: > Hi, > > another gentle ping. Sorry for the delay, I have way too little bandwidth these days :-S > Also adding Laurent Pinchart to CC. > > On Wed, 2021-05-26 at 07:34 +0000, Stefan Riedmüller wrote: > > On Thu, 2021-04-15 at 11:16 +0200, Stefan Riedmueller wrote: > > > The AUO G104SN02 V2 is an LVDS display which supports 6 and 8 bpc PSWG. > > > Add the corresponding connector type and 8 bpc as default bus_format. > > > > > > Signed-off-by: Stefan Riedmueller <s.riedmueller@phytec.de> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> It will be interesting to add support for the 6bpp mode at some point (I assume through a custom DT property that reports the state of the panel's SEL68 pin, as it should be strapped in most cases). > > > --- > > > drivers/gpu/drm/panel/panel-simple.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/drivers/gpu/drm/panel/panel-simple.c > > > b/drivers/gpu/drm/panel/panel-simple.c > > > index 4e2dad314c79..44583d0ed902 100644 > > > --- a/drivers/gpu/drm/panel/panel-simple.c > > > +++ b/drivers/gpu/drm/panel/panel-simple.c > > > @@ -1098,6 +1098,8 @@ static const struct panel_desc auo_g104sn02 = { > > > .width = 211, > > > .height = 158, > > > }, > > > + .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG, > > > + .connector_type = DRM_MODE_CONNECTOR_LVDS, > > > }; > > > > > > static const struct drm_display_mode auo_g121ean01_mode = { -- Regards, Laurent Pinchart
next prev parent reply other threads:[~2021-06-21 14:27 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-15 9:16 [PATCH 1/3] drm/panel: Add connector_type and bus_format for AUO G104SN02 V2 panel Stefan Riedmueller 2021-04-15 9:16 ` Stefan Riedmueller 2021-04-15 9:16 ` [PATCH 2/3] drm/panel: Add connector_type for some EDT displays Stefan Riedmueller 2021-04-15 9:16 ` Stefan Riedmueller 2021-04-15 9:16 ` [PATCH 3/3] drm/panel: Add bus_format and bus_flags for EDT ETM0430G0DH6 Stefan Riedmueller 2021-04-15 9:16 ` Stefan Riedmueller 2021-05-26 7:34 ` [PATCH 1/3] drm/panel: Add connector_type and bus_format for AUO G104SN02 V2 panel Stefan Riedmüller 2021-05-26 7:34 ` Stefan Riedmüller 2021-06-21 8:22 ` Stefan Riedmüller 2021-06-21 8:22 ` Stefan Riedmüller 2021-06-21 14:17 ` Sam Ravnborg 2021-06-21 15:04 ` Stefan Riedmüller 2021-06-21 15:04 ` Stefan Riedmüller 2021-06-21 14:27 ` Laurent Pinchart [this message] 2021-06-21 14:27 ` Laurent Pinchart
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YNChySKddg/JsMZv@pendragon.ideasonboard.com \ --to=laurent.pinchart@ideasonboard.com \ --cc=S.Riedmueller@phytec.de \ --cc=airlied@linux.ie \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=linux-kernel@vger.kernel.org \ --cc=sam@ravnborg.org \ --cc=thierry.reding@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.