All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [RFC PATCH v2 1/1] make: Add make test{, -c, -c-run, -shell-run} targets
Date: Tue, 22 Jun 2021 10:59:42 +0200	[thread overview]
Message-ID: <YNGmfnR6/FpzHe99@yuki> (raw)
In-Reply-To: <20210618191252.12403-1-pvorel@suse.cz>

Hi!
> For testing C and shell API.
> 
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> Hi all,
> 
> another attempt for make test target.
> 
> In a long term, I'd like to wrap the execution with some script, as I
> suppose there will be some metadata in test, allowing to run tests which
> don't TPASS or TBROK (we have quite a lot of them). Then the summary
> would be even more useful.
> 
> FIXME: broken in lib/, it runs all test twice.
> 
> changes v1->v2:
> Not sure if it's a good approach to process each test separately,
> there is no loop as Cyril suggested in [1], thus there is no summary
> what happen.
> 
> I previously had in similar loop in include/mk/generic_leaf_target.inc:
> 
> test-c-run: $(TEST_TARGETS)
> 	@set -e; echo; echo "===== Test C API ====="; \
> 	for i in $(TEST_TARGETS); do \
> 	    echo; echo "* $$i"; \
> 	    echo "PATH $(top_srcdir)/testcases/lib:$$PATH"; \
> 	    PATH="$(top_srcdir)/testcases/lib:$$PATH" ./$$i || [ $$? -eq 32 ]; \
> 	done; echo; \
> 	echo "All C API tests passed or TCONF"
> 
> test-shell-run:
> 	@set -e; echo; echo "===== Test shell API ====="; \
> 	for i in $(TEST_SHELL_TARGETS); do \
> 	    echo; echo "* $$i"; \
> 	    PATH="$(abs_top_srcdir)/testcases/lib:$(abs_top_builddir)/testcases/lib:$$PATH" $(abs_srcdir)/$$i || [ $$? -eq 32 ]; \
> 	done; echo; \
> 	echo "All shell API tests passed or TCONF"
> 
> but that was problematic in lib (which uses generic_leaf_target.inc).

Why not just add runtest.sh into newlib_tests/ that would do all the
work, then we can forget about all the trickery and just run the scritp
on 'make test-c'. Well we would have to call make in newlib_tests first
to make sure it was compiled, but that should be it.

And the same for testcases/lib/.

I do not think that adding a target per a testcase is sane.

-- 
Cyril Hrubis
chrubis@suse.cz

  parent reply	other threads:[~2021-06-22  8:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-18 19:12 [LTP] [RFC PATCH v2 1/1] make: Add make test{, -c, -c-run, -shell-run} targets Petr Vorel
2021-06-21  8:41 ` Richard Palethorpe
2021-06-21  8:48   ` Petr Vorel
2021-06-22  8:59 ` Cyril Hrubis [this message]
2021-06-22  9:50   ` Petr Vorel
2021-06-22 10:10     ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YNGmfnR6/FpzHe99@yuki \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.