From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Geert Uytterhoeven <geert@linux-m68k.org> Cc: Kieran Bingham <kieran.bingham@ideasonboard.com>, Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>, "open list:DRM DRIVERS FOR RENESAS" <dri-devel@lists.freedesktop.org>, "open list:DRM DRIVERS FOR RENESAS" <linux-renesas-soc@vger.kernel.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, open list <linux-kernel@vger.kernel.org> Subject: Re: [PATCH] dt-bindings: display: renesas,du: Provide bindings for r8a779a0 Date: Wed, 23 Jun 2021 16:14:42 +0300 [thread overview] Message-ID: <YNMzwtTqhfOzdJ56@pendragon.ideasonboard.com> (raw) In-Reply-To: <CAMuHMdXJTCyfMX3nN6pbAHeqqf5OCqJR4+7GJ=71+o1iKRrHhg@mail.gmail.com> Hi Geert, On Wed, Jun 23, 2021 at 03:09:06PM +0200, Geert Uytterhoeven wrote: > On Wed, Jun 23, 2021 at 2:58 PM Laurent Pinchart wrote: > > On Wed, Jun 23, 2021 at 02:53:33PM +0200, Geert Uytterhoeven wrote: > > > On Wed, Jun 23, 2021 at 1:11 AM Kieran Bingham wrote: > > > > From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > > > > > > > > Extend the Renesas DU display bindings to support the r8a779a0 V3U. > > > > > > > > Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > > > > > > Thanks for your patch! > > > > > > > --- a/Documentation/devicetree/bindings/display/renesas,du.yaml > > > > +++ b/Documentation/devicetree/bindings/display/renesas,du.yaml > > > > @@ -39,6 +39,7 @@ properties: > > > > - renesas,du-r8a77980 # for R-Car V3H compatible DU > > > > - renesas,du-r8a77990 # for R-Car E3 compatible DU > > > > - renesas,du-r8a77995 # for R-Car D3 compatible DU > > > > + - renesas,du-r8a779a0 # for R-Car V3U compatible DU > > > > > > > > reg: > > > > maxItems: 1 > > > > @@ -774,6 +775,57 @@ allOf: > > > > - reset-names > > > > - renesas,vsps > > > > > > > > + - if: > > > > + properties: > > > > + compatible: > > > > + contains: > > > > + enum: > > > > + - renesas,du-r8a779a0 > > > > + then: > > > > + properties: > > > > + clocks: > > > > + items: > > > > + - description: Functional clock for DU0 > > > > + - description: Functional clock for DU1 > > > > + > > > > + clock-names: > > > > + items: > > > > + - const: du.0 > > > > + - const: du.1 > > > > > > The hardware block has only a single function clock for both channels, > > > like on R-Car H1. > > > > > > And what about DU_DOTCLKIN? > > > > As far as I can tell, there's no DU_DOTCLKIN in V3U. > > See Table 6.13 of the Hardware User's Manual, pin IPC_CLKIN. Maybe that's incorrect ? There's no mention of DU_DOTCLKIN anywhere else, and the DU bits that allow selection of the input clocks list the value documented for Gen3 SoCs as selected DU_DOTCLKIN as reserved. > Note that the register bits to configure it are present in > drivers/pinctrl/renesas/pfc-r8a779a0.c, but the actual pin group is > missing. -- Regards, Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Geert Uytterhoeven <geert@linux-m68k.org> Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, David Airlie <airlied@linux.ie>, Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>, Kieran Bingham <kieran.bingham@ideasonboard.com>, "open list:DRM DRIVERS FOR RENESAS" <dri-devel@lists.freedesktop.org>, open list <linux-kernel@vger.kernel.org>, "open list:DRM DRIVERS FOR RENESAS" <linux-renesas-soc@vger.kernel.org>, Rob Herring <robh+dt@kernel.org> Subject: Re: [PATCH] dt-bindings: display: renesas,du: Provide bindings for r8a779a0 Date: Wed, 23 Jun 2021 16:14:42 +0300 [thread overview] Message-ID: <YNMzwtTqhfOzdJ56@pendragon.ideasonboard.com> (raw) In-Reply-To: <CAMuHMdXJTCyfMX3nN6pbAHeqqf5OCqJR4+7GJ=71+o1iKRrHhg@mail.gmail.com> Hi Geert, On Wed, Jun 23, 2021 at 03:09:06PM +0200, Geert Uytterhoeven wrote: > On Wed, Jun 23, 2021 at 2:58 PM Laurent Pinchart wrote: > > On Wed, Jun 23, 2021 at 02:53:33PM +0200, Geert Uytterhoeven wrote: > > > On Wed, Jun 23, 2021 at 1:11 AM Kieran Bingham wrote: > > > > From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > > > > > > > > Extend the Renesas DU display bindings to support the r8a779a0 V3U. > > > > > > > > Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > > > > > > Thanks for your patch! > > > > > > > --- a/Documentation/devicetree/bindings/display/renesas,du.yaml > > > > +++ b/Documentation/devicetree/bindings/display/renesas,du.yaml > > > > @@ -39,6 +39,7 @@ properties: > > > > - renesas,du-r8a77980 # for R-Car V3H compatible DU > > > > - renesas,du-r8a77990 # for R-Car E3 compatible DU > > > > - renesas,du-r8a77995 # for R-Car D3 compatible DU > > > > + - renesas,du-r8a779a0 # for R-Car V3U compatible DU > > > > > > > > reg: > > > > maxItems: 1 > > > > @@ -774,6 +775,57 @@ allOf: > > > > - reset-names > > > > - renesas,vsps > > > > > > > > + - if: > > > > + properties: > > > > + compatible: > > > > + contains: > > > > + enum: > > > > + - renesas,du-r8a779a0 > > > > + then: > > > > + properties: > > > > + clocks: > > > > + items: > > > > + - description: Functional clock for DU0 > > > > + - description: Functional clock for DU1 > > > > + > > > > + clock-names: > > > > + items: > > > > + - const: du.0 > > > > + - const: du.1 > > > > > > The hardware block has only a single function clock for both channels, > > > like on R-Car H1. > > > > > > And what about DU_DOTCLKIN? > > > > As far as I can tell, there's no DU_DOTCLKIN in V3U. > > See Table 6.13 of the Hardware User's Manual, pin IPC_CLKIN. Maybe that's incorrect ? There's no mention of DU_DOTCLKIN anywhere else, and the DU bits that allow selection of the input clocks list the value documented for Gen3 SoCs as selected DU_DOTCLKIN as reserved. > Note that the register bits to configure it are present in > drivers/pinctrl/renesas/pfc-r8a779a0.c, but the actual pin group is > missing. -- Regards, Laurent Pinchart
next prev parent reply other threads:[~2021-06-23 13:15 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-22 23:11 [PATCH] dt-bindings: display: renesas,du: Provide bindings for r8a779a0 Kieran Bingham 2021-06-22 23:11 ` [PATCH] dt-bindings: display: renesas, du: " Kieran Bingham 2021-06-23 2:44 ` [PATCH] dt-bindings: display: renesas,du: " Laurent Pinchart 2021-06-23 2:44 ` Laurent Pinchart 2021-06-23 12:53 ` Geert Uytterhoeven 2021-06-23 12:53 ` [PATCH] dt-bindings: display: renesas, du: " Geert Uytterhoeven 2021-06-23 12:58 ` [PATCH] dt-bindings: display: renesas,du: " Laurent Pinchart 2021-06-23 12:58 ` Laurent Pinchart 2021-06-23 13:09 ` Geert Uytterhoeven 2021-06-23 13:09 ` [PATCH] dt-bindings: display: renesas, du: " Geert Uytterhoeven 2021-06-23 13:14 ` Laurent Pinchart [this message] 2021-06-23 13:14 ` [PATCH] dt-bindings: display: renesas,du: " Laurent Pinchart 2021-09-01 22:01 ` Kieran Bingham 2021-09-01 22:01 ` Kieran Bingham 2021-09-01 22:13 ` Laurent Pinchart 2021-09-01 22:13 ` Laurent Pinchart 2021-09-01 23:20 ` Kieran Bingham 2021-09-01 23:20 ` Kieran Bingham
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YNMzwtTqhfOzdJ56@pendragon.ideasonboard.com \ --to=laurent.pinchart@ideasonboard.com \ --cc=airlied@linux.ie \ --cc=daniel@ffwll.ch \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=geert@linux-m68k.org \ --cc=kieran.bingham+renesas@ideasonboard.com \ --cc=kieran.bingham@ideasonboard.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.