From: Wolfram Sang <wsa@kernel.org>
To: Shubhankar Kuranagatti <shubhankarvk@gmail.com>
Cc: sumit.semwal@linaro.org, christian.koenig@amd.com,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
linaro-mm-sig@lists.linaro.org
Subject: Re: [PATCH] drivers: i2c: i2c-core-smbus.c: Fix alignment of comment
Date: Sat, 26 Jun 2021 12:20:06 +0200 [thread overview]
Message-ID: <YNb/Vj+TWxoG1rkE@kunai> (raw)
In-Reply-To: <20210428122755.2s56uotb225rezcw@kewl-virtual-machine>
[-- Attachment #1: Type: text/plain, Size: 501 bytes --]
On Wed, Apr 28, 2021 at 05:57:55PM +0530, Shubhankar Kuranagatti wrote:
> Multi line comment have been aligned starting with a *
> The closing */ has been shifted to a new line.
> Single space replaced with tab space
> This is done to maintain code uniformity.
A step in the right direction but still not comments as they should be
according to the kernel coding style. If we touch it, we should make it
proper. Also, please use 'git log' to check how the $subject line should
be in this subsystem.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@kernel.org>
To: Shubhankar Kuranagatti <shubhankarvk@gmail.com>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
christian.koenig@amd.com, linaro-mm-sig@lists.linaro.org,
linux-i2c@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH] drivers: i2c: i2c-core-smbus.c: Fix alignment of comment
Date: Sat, 26 Jun 2021 12:20:06 +0200 [thread overview]
Message-ID: <YNb/Vj+TWxoG1rkE@kunai> (raw)
In-Reply-To: <20210428122755.2s56uotb225rezcw@kewl-virtual-machine>
[-- Attachment #1: Type: text/plain, Size: 501 bytes --]
On Wed, Apr 28, 2021 at 05:57:55PM +0530, Shubhankar Kuranagatti wrote:
> Multi line comment have been aligned starting with a *
> The closing */ has been shifted to a new line.
> Single space replaced with tab space
> This is done to maintain code uniformity.
A step in the right direction but still not comments as they should be
according to the kernel coding style. If we touch it, we should make it
proper. Also, please use 'git log' to check how the $subject line should
be in this subsystem.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-06-26 10:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-28 12:27 [PATCH] drivers: i2c: i2c-core-smbus.c: Fix alignment of comment Shubhankar Kuranagatti
2021-04-28 12:27 ` Shubhankar Kuranagatti
2021-06-26 10:20 ` Wolfram Sang [this message]
2021-06-26 10:20 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNb/Vj+TWxoG1rkE@kunai \
--to=wsa@kernel.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=shubhankarvk@gmail.com \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.