All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v1 1/1] package/fb-test-app: Move 'rosetta' prefix from VERSION to SITE
@ 2021-06-28 13:08 Andy Shevchenko
  2021-06-28 13:40 ` Thomas Petazzoni
  0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2021-06-28 13:08 UTC (permalink / raw)
  To: buildroot

Move 'rosetta' prefix from VERSION to SITE to have version be
in a standard format.

Suggested-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 package/fb-test-app/fb-test-app.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/fb-test-app/fb-test-app.mk b/package/fb-test-app/fb-test-app.mk
index f6e949015ef8..89d533ab15b4 100644
--- a/package/fb-test-app/fb-test-app.mk
+++ b/package/fb-test-app/fb-test-app.mk
@@ -4,8 +4,8 @@
 #
 ################################################################################
 
-FB_TEST_APP_VERSION = rosetta-1.1.1
-FB_TEST_APP_SITE = $(call github,andy-shev,fb-test-app,$(FB_TEST_APP_VERSION))
+FB_TEST_APP_VERSION = 1.1.1
+FB_TEST_APP_SITE = $(call github,andy-shev,fb-test-app,rosetta-$(FB_TEST_APP_VERSION))
 FB_TEST_APP_LICENSE = GPL-2.0
 FB_TEST_APP_LICENSE_FILES = COPYING
 
-- 
2.30.2

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH v1 1/1] package/fb-test-app: Move 'rosetta' prefix from VERSION to SITE
  2021-06-28 13:08 [Buildroot] [PATCH v1 1/1] package/fb-test-app: Move 'rosetta' prefix from VERSION to SITE Andy Shevchenko
@ 2021-06-28 13:40 ` Thomas Petazzoni
  2021-06-28 15:59   ` Andy Shevchenko
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni @ 2021-06-28 13:40 UTC (permalink / raw)
  To: buildroot

On Mon, 28 Jun 2021 16:08:16 +0300
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> Move 'rosetta' prefix from VERSION to SITE to have version be
> in a standard format.
> 
> Suggested-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Thanks for the patch. However, are you sure you tested it? I believe
this doesn't build, as the .hash file needs to be adjusted accordingly.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH v1 1/1] package/fb-test-app: Move 'rosetta' prefix from VERSION to SITE
  2021-06-28 13:40 ` Thomas Petazzoni
@ 2021-06-28 15:59   ` Andy Shevchenko
  0 siblings, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2021-06-28 15:59 UTC (permalink / raw)
  To: buildroot

On Mon, Jun 28, 2021 at 03:40:08PM +0200, Thomas Petazzoni wrote:
> On Mon, 28 Jun 2021 16:08:16 +0300
> Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> 
> > Move 'rosetta' prefix from VERSION to SITE to have version be
> > in a standard format.
> > 
> > Suggested-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> Thanks for the patch. However, are you sure you tested it? I believe
> this doesn't build, as the .hash file needs to be adjusted accordingly.

You are right, it wasn't tested on the repo which has this package enabled in
the configuration.
I'll send v2 which I have just tested:

--2021-06-28 18:58:28--  https://github.com/andy-shev/fb-test-app/archive/rosetta-1.1.1/fb-test-app-1.1.1.tar.gz
...
fb-test-app-1.1.1.tar.gz: OK (sha256: 45d490ed78a6e4425d9a760e81e99dc503af01704e17ab5bf186b87a31c5e3db)


-- 
With Best Regards,
Andy Shevchenko

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-06-28 15:59 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-28 13:08 [Buildroot] [PATCH v1 1/1] package/fb-test-app: Move 'rosetta' prefix from VERSION to SITE Andy Shevchenko
2021-06-28 13:40 ` Thomas Petazzoni
2021-06-28 15:59   ` Andy Shevchenko

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.