All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: Andreas Gruenbacher <agruenba@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	"Darrick J . Wong" <djwong@kernel.org>,
	linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	cluster-devel@redhat.com
Subject: Re: [PATCH 1/2] iomap: Don't create iomap_page objects for inline files
Date: Wed, 30 Jun 2021 14:35:54 +0100	[thread overview]
Message-ID: <YNxzOkOifYIIR0HW@casper.infradead.org> (raw)
In-Reply-To: <20210628172727.1894503-2-agruenba@redhat.com>

On Mon, Jun 28, 2021 at 07:27:26PM +0200, Andreas Gruenbacher wrote:
> In iomap_readpage_actor, don't create iop objects for inline inodes.
> Otherwise, iomap_read_inline_data will set PageUptodate without setting
> iop->uptodate, and iomap_page_release will eventually complain.
> 
> To prevent this kind of bug from occurring in the future, make sure the
> page doesn't have private data attached in iomap_read_inline_data.
> 
> Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>

Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>

WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <willy@infradead.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 1/2] iomap: Don't create iomap_page objects for inline files
Date: Wed, 30 Jun 2021 14:35:54 +0100	[thread overview]
Message-ID: <YNxzOkOifYIIR0HW@casper.infradead.org> (raw)
In-Reply-To: <20210628172727.1894503-2-agruenba@redhat.com>

On Mon, Jun 28, 2021 at 07:27:26PM +0200, Andreas Gruenbacher wrote:
> In iomap_readpage_actor, don't create iop objects for inline inodes.
> Otherwise, iomap_read_inline_data will set PageUptodate without setting
> iop->uptodate, and iomap_page_release will eventually complain.
> 
> To prevent this kind of bug from occurring in the future, make sure the
> page doesn't have private data attached in iomap_read_inline_data.
> 
> Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>

Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>



  reply	other threads:[~2021-06-30 13:37 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-28 17:27 [PATCH 0/2] iomap: small block problems Andreas Gruenbacher
2021-06-28 17:27 ` [Cluster-devel] " Andreas Gruenbacher
2021-06-28 17:27 ` [PATCH 1/2] iomap: Don't create iomap_page objects for inline files Andreas Gruenbacher
2021-06-28 17:27   ` [Cluster-devel] " Andreas Gruenbacher
2021-06-30 13:35   ` Matthew Wilcox [this message]
2021-06-30 13:35     ` Matthew Wilcox
2021-06-28 17:27 ` [PATCH 2/2] iomap: Add helper for un-inlining an inline inode Andreas Gruenbacher
2021-06-28 17:27   ` [Cluster-devel] " Andreas Gruenbacher
2021-06-28 17:39 ` [PATCH 0/2] iomap: small block problems Matthew Wilcox
2021-06-28 17:39   ` [Cluster-devel] " Matthew Wilcox
2021-06-28 17:47   ` Christoph Hellwig
2021-06-28 17:47     ` [Cluster-devel] " Christoph Hellwig
2021-06-28 21:28     ` Andreas Gruenbacher
2021-06-28 21:28       ` [Cluster-devel] " Andreas Gruenbacher
2021-06-28 21:59     ` Matthew Wilcox
2021-06-28 21:59       ` [Cluster-devel] " Matthew Wilcox
2021-06-29  5:29       ` Christoph Hellwig
2021-06-29  5:29         ` [Cluster-devel] " Christoph Hellwig
2021-06-29  5:42         ` Christoph Hellwig
2021-06-29  5:42           ` [Cluster-devel] " Christoph Hellwig
2021-06-30 12:29         ` Andreas Gruenbacher
2021-06-30 12:29           ` [Cluster-devel] " Andreas Gruenbacher
2021-07-05 15:51           ` Andreas Gruenbacher
2021-07-05 15:51             ` [Cluster-devel] " Andreas Gruenbacher
2021-07-05 16:55             ` Christoph Hellwig
2021-07-05 16:55               ` [Cluster-devel] " Christoph Hellwig
2021-06-28 17:55   ` Andreas Gruenbacher
2021-06-28 17:55     ` [Cluster-devel] " Andreas Gruenbacher
2021-06-29  9:12 ` Andreas Gruenbacher
2021-06-29  9:12   ` [Cluster-devel] " Andreas Gruenbacher
2021-06-30 14:08   ` Matthew Wilcox
2021-06-30 14:08     ` [Cluster-devel] " Matthew Wilcox
2021-06-30 14:45     ` Andreas Gruenbacher
2021-06-30 14:45       ` [Cluster-devel] " Andreas Gruenbacher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YNxzOkOifYIIR0HW@casper.infradead.org \
    --to=willy@infradead.org \
    --cc=agruenba@redhat.com \
    --cc=cluster-devel@redhat.com \
    --cc=djwong@kernel.org \
    --cc=hch@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.